From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by sourceware.org (Postfix) with ESMTPS id F249F3858D28; Thu, 16 Dec 2021 21:47:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F249F3858D28 Received: by mail-wr1-x433.google.com with SMTP id r17so102757wrc.3; Thu, 16 Dec 2021 13:47:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=rPHOEzoKJOR+Wn+7oR9+ZUM2V6qEqb1UWN3aHlLa+Ow=; b=P88CS+Z2/c+rHeN8YENULGbclI6zod8H/RtiHpws27ET9XPGs+SK9t033O5ObG8wHa KOht25F3i7t3GtSbQ7LH4+K8AsR3oXHArRlcTK5SrAuJS5gyY38hrseaJLUTP/SNc3ph 9AH2xGQvJL04kaC05C9bXZt0vafIromwqRVx9gfC68fWKTWLnwtKXL7p7VGPzPpkOeWm N5qKYGvSfbYHdXG1mLJY2blx/en/YxOfSvdq9HmvX7x0v8s0A5nGpGRNTfcjqnMm0etD bQqrYTR0yMpj1YpVhqRDGk5Isih/u/px6nA8EvTS1/toKFcPXeLg/wsIPIBNg4LKM/dk hDxg== X-Gm-Message-State: AOAM530L8ZtcCFZ/0sNFVyueTkEMk2Ly9jTDK941430nCK8TMcPyazn5 2LuQlLkBwmBEJb1G2iGFcxxghw9O+hc= X-Google-Smtp-Source: ABdhPJzFPzSazC+owYAW4ZH1TbO1ZiL8wkn9ykKUC85vbGCsdF5mOo8z0ifAsD33dqTXFbsg/2tVpA== X-Received: by 2002:a5d:4d4f:: with SMTP id a15mr5262289wru.268.1639691238967; Thu, 16 Dec 2021 13:47:18 -0800 (PST) Received: from smtpclient.apple ([2a01:e34:ec28:8cb0:a5b9:b62:16cf:26bf]) by smtp.gmail.com with ESMTPSA id b10sm6132192wrg.19.2021.12.16.13.47.18 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Dec 2021 13:47:18 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.40.0.1.81\)) Subject: Re: [patch] Fix PR libfortran/95177, ctype.h functions should not be called with char arguments From: FX In-Reply-To: Date: Thu, 16 Dec 2021 22:47:18 +0100 Cc: Harald Anlauf Content-Transfer-Encoding: quoted-printable Message-Id: <12368AB6-5F89-4EFA-8F12-F422134C099F@gmail.com> References: To: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org X-Mailer: Apple Mail (2.3693.40.0.1.81) X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Dec 2021 21:47:22 -0000 Hi Harald, I=E2=80=99m not on the list for now, please keep me in CC so I don=E2=80=99= t miss replies. Thought it feels nice to be working on gfortran again :) > However, I am wondering if calling the macros safe_* gives a false > impression of what they actually do. The cases where they are used > with your patch applied seem sane, for now, though. I thought about that, it=E2=80=99s not really =E2=80=9Csafer=E2=80=9D = than the underlying C library obviously. I couldn=E2=80=99t find a = better name, but I=E2=80=99ll wait before I commit so others can suggest = something else. unrelated PS: I=E2=80=99ve been thinking aloud and benchmarking faster = integer I/O for libgfortran at = https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D98076 Comments are welcome on the proposed design, I think the current = proposal is a low-hanging fruit (not risky, much faster). Best, FX=