From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from impout009.msg.chrl.nc.charter.net (impout009aa.msg.chrl.nc.charter.net [47.43.20.33]) by sourceware.org (Postfix) with ESMTPS id D3E583858C27; Fri, 5 Mar 2021 01:03:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D3E583858C27 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=charter.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=jvdelisle@charter.net Received: from [192.168.1.9] ([96.41.221.129]) by cmsmtp with ESMTPA id Hys0lK9Kbe9aEHys1lO3An; Fri, 05 Mar 2021 01:03:10 +0000 Authentication-Results: charter.net; none X-Authority-Analysis: v=2.3 cv=NdJSKFL4 c=1 sm=1 tr=0 a=07pILqX15KmGv9ZXTMmBNA==:117 a=07pILqX15KmGv9ZXTMmBNA==:17 a=IkcTkHD0fZMA:10 a=ue4NQC0u4Qs2zZ66NngA:9 a=QEXdDO2ut3YA:10 Subject: Re: [Patch] Fortran: Follow fixes to -freal-{4,8}-real* handling [PR99355,PR57871] (was: Re: [Patch] Fortran: Fix -freal-{4,8}-real* handling [PR99355]) To: Tobias Burnus , gcc-patches , fortran References: <72ad0d5c-762b-351d-6046-bdaf24e714e5@codesourcery.com> From: Jerry DeLisle Message-ID: <131e010a-a429-b52e-c7d6-e401306d2c28@charter.net> Date: Thu, 4 Mar 2021 17:03:08 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <72ad0d5c-762b-351d-6046-bdaf24e714e5@codesourcery.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CMAE-Envelope: MS4wfOrSDGRTjcQC2A6FCPJOqA2QFQOJ/u3tIeyGrGw9qQrQWj7WL5Mxoyy+8v8OaBbmZvMmTqCf9tRKfB+6X92GGplbnL4lWz2MN7oCqvW4QLML8ltXCyEE kAlNOwT8oSm64pdpAmSl+f/MXIOnGJxKAiYp45UJrLWzWJub/zc0NAk1c37l7unxRru24PFjOOCxVVuaeAcqtJELPy+RsGXdq2KwszEab2DlXtsXOibH448O ea8Ct0S+yPeLqEerpv7vag== X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00, FREEMAIL_FROM, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Mar 2021 01:03:12 -0000 OK, thanks Dominique for spotting this. On 3/4/21 9:02 AM, Tobias Burnus wrote: > Dominique found an issue ("regression") with this patch – and a testcase > omission. > > The previous patch mishandled the noncommitted testcase of PR57871 – or > in other words: It did not promote 1.0_4 or 1.0_8 – as only the > default-real-kind values 1.0 and 1.0d0 were promoted (via code in in > trans-types.c). > > I have additionally updated the documentation to more accurately state > what the option does and how it interacts with other options. > > OK for mainline? > > Tobias > > PS: Side remark: My recommendation is to avoid > -freal-{4,8}-real-{4,8,10,16} ... > > ----------------- > Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 München > Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, > Frank Thürauf