* [Patch, committed] PR67933
@ 2015-10-27 18:07 Paul Richard Thomas
2015-10-28 20:31 ` Bill Schmidt
0 siblings, 1 reply; 6+ messages in thread
From: Paul Richard Thomas @ 2015-10-27 18:07 UTC (permalink / raw)
To: fortran, gcc-patches
Dear All,
The recent patches on trunk to gfc_trans_allocate have fixed PR67933.
I have added a testcase, which has been committed as revision 229452.
Since this is a 4.9/5 regression, I will extract the minimum change
necessary and will submit it as soon as I have regtested.
Cheers
Paul
2015-01-27 Paul Thomas <pault@gcc.gnu.org>
PR fortran/67933
* gfortran.dg/allocate_with_source_15.f03: New test
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Patch, committed] PR67933
2015-10-27 18:07 [Patch, committed] PR67933 Paul Richard Thomas
@ 2015-10-28 20:31 ` Bill Schmidt
0 siblings, 0 replies; 6+ messages in thread
From: Bill Schmidt @ 2015-10-28 20:31 UTC (permalink / raw)
To: Paul Richard Thomas; +Cc: fortran, gcc-patches
On Tue, 2015-10-27 at 19:07 +0100, Paul Richard Thomas wrote:
> Dear All,
>
> The recent patches on trunk to gfc_trans_allocate have fixed PR67933.
> I have added a testcase, which has been committed as revision 229452.
This test case fails at runtime on powerpc64le-linux-gnu. From
gfortran.log:
spawn /home/wschmidt/gcc/build/gcc-mainline-test/gcc/testsuite/gfortran5/../../g
fortran -B/home/wschmidt/gcc/build/gcc-mainline-test/gcc/testsuite/gfortran5/../
../ -B/home/wschmidt/gcc/build/gcc-mainline-test/powerpc64le-unknown-linux-gnu/.
/libgfortran/ /home/wschmidt/gcc/gcc-mainline-test/gcc/testsuite/gfortran.dg/allocate_with_source_15.f03 -fno-diagnostics-show-caret -fdiagnostics-color=never -O0 -pedantic-errors -B/home/wschmidt/gcc/build/gcc-mainline-test/powerpc64le-unknown-linux-gnu/./libgfortran/.libs -L/home/wschmidt/gcc/build/gcc-mainline-test/powerpc64le-unknown-linux-gnu/./libgfortran/.libs -L/home/wschmidt/gcc/build/gcc-mainline-test/powerpc64le-unknown-linux-gnu/./libgfortran/.libs -L/home/wschmidt/gcc/build/gcc-mainline-test/powerpc64le-unknown-linux-gnu/./libatomic/.libs -lm -m64 -o ./allocate_with_source_15.exe
PASS: gfortran.dg/allocate_with_source_15.f03 -O0 (test for excess errors)
Setting LD_LIBRARY_PATH to .:/home/wschmidt/gcc/build/gcc-mainline-test/powerpc64le-unknown-linux-gnu/./libgfortran/.libs:/home/wschmidt/gcc/build/gcc-mainline-test/powerpc64le-unknown-linux-gnu/./libgfortran/.libs:/home/wschmidt/gcc/build/gcc-mainline-test/powerpc64le-unknown-linux-gnu/./libatomic/.libs:/home/wschmidt/gcc/build/gcc-mainline-test/gcc:.:/home/wschmidt/gcc/build/gcc-mainline-test/powerpc64le-unknown-linux-gnu/./libgfortran/.libs:/home/wschmidt/gcc/build/gcc-mainline-test/powerpc64le-unknown-linux-gnu/./libgfortran/.libs:/home/wschmidt/gcc/build/gcc-mainline-test/powerpc64le-unknown-linux-gnu/./libatomic/.libs:/home/wschmidt/gcc/build/gcc-mainline-test/gcc:/home/wschmidt/gcc/build/gcc-mainline-test/powerpc64le-unknown-linux-gnu/libstdc++-v3/src/.libs:/home/wschmidt/gcc/build/gcc-mainline-test/powerpc64le-unknown-linux-gnu/libsanitizer/.libs:/home/wschmidt/gcc/build/gcc-mainline-test/powerpc64le-unknown-linux-gnu/libssp/.libs:/home/wschmidt/gcc/build/gcc-mainline-test/powerpc64le-unknown-linux-gnu/libgomp/.libs:/home/wschmidt/gcc/build/gcc-mainline-test/powerpc64le-unknown-linux-gnu/libitm/.libs:/home/wschmidt/gcc/build/gcc-mainline-test/powerpc64le-unknown-linux-gnu/libatomic/.libs:/home/wschmidt/gcc/build/gcc-mainline-test/./gcc:/home/wschmidt/gcc/build/gcc-mainline-test/./prev-gcc:/home/wschmidt/gcc/build/gcc-mainline-test/powerpc64le-unknown-linux-gnu/libstdc++-v3/src/.libs:/home/wschmidt/gcc/build/gcc-mainline-test/powerpc64le-unknown-linux-gnu/libsanitizer/.libs:/home/wschmidt/gcc/build/gcc-mainline-test/powerpc64le-unknown-linux-gnu/libssp/.libs:/home/wschmidt/gcc/build/gcc-mainline-test/powerpc64le-unknown-linux-gnu/libgomp/.libs:/home/wschmidt/gcc/build/gcc-mainline-test/powerpc64le-unknown-linux-gnu/libitm/.libs:/home/wschmidt/gcc/build/gcc-mainline-test/powerpc64le-unknown-linux-gnu/libatomic/.libs:/home/wschmidt/gcc/build/gcc-mainline-test/./gcc:/home/wschmidt/gcc/build/gcc-mainline-test/./prev-gcc
spawn [open ...]
At line 38 of file /home/wschmidt/gcc/gcc-mainline-test/gcc/testsuite/gfortran.dg/allocate_with_source_15.f03
Fortran runtime error: Attempting to allocate already allocated variable 'this'
Error termination. Backtrace:
FAIL: gfortran.dg/allocate_with_source_15.f03 -O0 execution test
>
> Since this is a 4.9/5 regression, I will extract the minimum change
> necessary and will submit it as soon as I have regtested.
>
> Cheers
>
> Paul
>
> 2015-01-27 Paul Thomas <pault@gcc.gnu.org>
>
> PR fortran/67933
> * gfortran.dg/allocate_with_source_15.f03: New test
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Patch, committed] PR67933
@ 2015-10-27 18:24 Dominique d'Humières
2015-10-28 5:45 ` Paul Richard Thomas
0 siblings, 1 reply; 6+ messages in thread
From: Dominique d'Humières @ 2015-10-27 18:24 UTC (permalink / raw)
To: paul Thomas; +Cc: gfortran, gcc-patches
Dear Paul,
> I have added a testcase, which has been committed as revision 229452.
If I compile the test with -fsanitize=address,undefined I get at run time
==72440==ERROR: AddressSanitizer: global-buffer-overflow on address 0x00010adfee20 at pc 0x00010adf913d bp 0x7fff54e0a270 sp 0x7fff54e0a268
READ of size 8 at 0x00010adfee20 thread T0
#0 0x10adf913c in __test_mod_MOD_method (a.out+0x10000413c)
#1 0x10adf9aac in MAIN__ (a.out+0x100004aac)
#2 0x10adf9b30 in main (a.out+0x100004b30)
#3 0x7fff8e6de5c8 in start (libdyld.dylib+0x35c8)
#4 0x0 (<unknown module>)
0x00010adfee20 is located 0 bytes to the right of global variable 'x' defined in '/opt/gcc/_clean/gcc/testsuite/gfortran.dg/allocate_with_source_15.f03:75' (0x10adfed80) of size 160
SUMMARY: AddressSanitizer: global-buffer-overflow (a.out+0x10000413c) in __test_mod_MOD_method
Shadow bytes around the buggy address:
…
Dominique
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Patch, committed] PR67933
2015-10-27 18:24 Dominique d'Humières
@ 2015-10-28 5:45 ` Paul Richard Thomas
0 siblings, 0 replies; 6+ messages in thread
From: Paul Richard Thomas @ 2015-10-28 5:45 UTC (permalink / raw)
To: Dominique d'Humières; +Cc: gfortran, gcc-patches
Oh bother! Thanks, Dominique
Paul
On 27 October 2015 at 19:24, Dominique d'Humières <dominiq@lps.ens.fr> wrote:
> Dear Paul,
>
>> I have added a testcase, which has been committed as revision 229452.
>
> If I compile the test with -fsanitize=address,undefined I get at run time
>
> ==72440==ERROR: AddressSanitizer: global-buffer-overflow on address 0x00010adfee20 at pc 0x00010adf913d bp 0x7fff54e0a270 sp 0x7fff54e0a268
> READ of size 8 at 0x00010adfee20 thread T0
> #0 0x10adf913c in __test_mod_MOD_method (a.out+0x10000413c)
> #1 0x10adf9aac in MAIN__ (a.out+0x100004aac)
> #2 0x10adf9b30 in main (a.out+0x100004b30)
> #3 0x7fff8e6de5c8 in start (libdyld.dylib+0x35c8)
> #4 0x0 (<unknown module>)
>
> 0x00010adfee20 is located 0 bytes to the right of global variable 'x' defined in '/opt/gcc/_clean/gcc/testsuite/gfortran.dg/allocate_with_source_15.f03:75' (0x10adfed80) of size 160
> SUMMARY: AddressSanitizer: global-buffer-overflow (a.out+0x10000413c) in __test_mod_MOD_method
> Shadow bytes around the buggy address:
> …
>
> Dominique
>
--
Outside of a dog, a book is a man's best friend. Inside of a dog it's
too dark to read.
Groucho Marx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Patch, committed] PR67933
@ 2015-10-29 11:18 Dominique d'Humières
2015-10-29 12:40 ` Bill Schmidt
0 siblings, 1 reply; 6+ messages in thread
From: Dominique d'Humières @ 2015-10-29 11:18 UTC (permalink / raw)
To: wschmidt; +Cc: paul Thomas, gfortran, gcc-patches
> > The recent patches on trunk to gfc_trans_allocate have fixed PR67933.
> > I have added a testcase, which has been committed as revision 229452.
>
> This test case fails at runtime on powerpc64le-linux-gnu. …
This should be fixed after revision r229503.
Dominique
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Patch, committed] PR67933
2015-10-29 11:18 Dominique d'Humières
@ 2015-10-29 12:40 ` Bill Schmidt
0 siblings, 0 replies; 6+ messages in thread
From: Bill Schmidt @ 2015-10-29 12:40 UTC (permalink / raw)
To: Dominique d'Humières; +Cc: paul Thomas, gfortran, gcc-patches
On Thu, 2015-10-29 at 12:18 +0100, Dominique d'Humières wrote:
> > > The recent patches on trunk to gfc_trans_allocate have fixed PR67933.
> > > I have added a testcase, which has been committed as revision 229452.
> >
> > This test case fails at runtime on powerpc64le-linux-gnu. â¦
> This should be fixed after revision r229503.
> Dominique
>
It is indeed. Thanks!
Bill
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-10-29 12:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-27 18:07 [Patch, committed] PR67933 Paul Richard Thomas
2015-10-28 20:31 ` Bill Schmidt
2015-10-27 18:24 Dominique d'Humières
2015-10-28 5:45 ` Paul Richard Thomas
2015-10-29 11:18 Dominique d'Humières
2015-10-29 12:40 ` Bill Schmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).