From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95419 invoked by alias); 1 Dec 2015 12:55:23 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 95303 invoked by uid 89); 1 Dec 2015 12:55:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-wm0-f53.google.com Received: from mail-wm0-f53.google.com (HELO mail-wm0-f53.google.com) (74.125.82.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 01 Dec 2015 12:55:21 +0000 Received: by wmvv187 with SMTP id v187so205195620wmv.1; Tue, 01 Dec 2015 04:55:18 -0800 (PST) X-Received: by 10.194.24.97 with SMTP id t1mr6066817wjf.127.1448974518462; Tue, 01 Dec 2015 04:55:18 -0800 (PST) Received: from s42.loc (91-119-111-21.dynamic.xdsl-line.inode.at. [91.119.111.21]) by smtp.gmail.com with ESMTPSA id k133sm26184527wmg.18.2015.12.01.04.55.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Dec 2015 04:55:17 -0800 (PST) Received: from cow by s42.loc with local (Exim 4.86) (envelope-from ) id 1a3kSk-000855-8g; Tue, 01 Dec 2015 13:55:18 +0100 From: Bernhard Reutner-Fischer To: fortran@gcc.gnu.org Cc: Bernhard Reutner-Fischer , gcc-patches@gcc.gnu.org Subject: [PATCH] Derive interface buffers from max name length Date: Tue, 01 Dec 2015 12:55:00 -0000 Message-Id: <1448974501-30981-2-git-send-email-rep.dot.nop@gmail.com> In-Reply-To: <1448974501-30981-1-git-send-email-rep.dot.nop@gmail.com> References: <1448974501-30981-1-git-send-email-rep.dot.nop@gmail.com> X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00002.txt.bz2 These three function used a hardcoded buffer of 100 but would be better off to base off GFC_MAX_SYMBOL_LEN which denotes the maximum length of a name in any of our supported standards (63 as of f2003 ff.). Regstrapped without regressions, ok for trunk stage3 now / next stage1? gcc/fortran/ChangeLog 2015-11-29 Bernhard Reutner-Fischer * interface.c (check_sym_interfaces, check_uop_interfaces, gfc_check_interfaces): Base interface_name buffer off GFC_MAX_SYMBOL_LEN. Signed-off-by: Bernhard Reutner-Fischer --- gcc/fortran/interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gcc/fortran/interface.c b/gcc/fortran/interface.c index dcf3eae..30cc522 100644 --- a/gcc/fortran/interface.c +++ b/gcc/fortran/interface.c @@ -1696,7 +1696,7 @@ check_interface1 (gfc_interface *p, gfc_interface *q0, static void check_sym_interfaces (gfc_symbol *sym) { - char interface_name[100]; + char interface_name[GFC_MAX_SYMBOL_LEN + sizeof("generic interface ''")]; gfc_interface *p; if (sym->ns != gfc_current_ns) @@ -1733,7 +1733,7 @@ check_sym_interfaces (gfc_symbol *sym) static void check_uop_interfaces (gfc_user_op *uop) { - char interface_name[100]; + char interface_name[GFC_MAX_SYMBOL_LEN + sizeof("operator interface ''")]; gfc_user_op *uop2; gfc_namespace *ns; @@ -1810,7 +1810,7 @@ void gfc_check_interfaces (gfc_namespace *ns) { gfc_namespace *old_ns, *ns2; - char interface_name[100]; + char interface_name[GFC_MAX_SYMBOL_LEN + sizeof("intrinsic '' operator")]; int i; old_ns = gfc_current_ns; -- 2.6.2