From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id AAE313973019; Fri, 27 Nov 2020 15:47:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AAE313973019 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Tobias_Burnus@mentor.com IronPort-SDR: i8ah6KrgUssBaLtMxQWHqTKu4C/UglEQseKcijzW1APEirQehXMfMj77QFmuZcMLC3jluxl9mN R+tsBFg7sAQBMWzUsqfr/f2utxmQ3iatGGSPvb5q3J9vh3TRrkLwU56QDe3N0vVUMramakLDJv heFCOqSpuQ1vHBiyDbSW12Si1A9apbt/L7285Tvi36AZo6a+NgLmHR2MqYX2QZCfs8h7TjZ1mG JZ8pge3h1hox1KkR/kNCqUYj3CoQMc/41XlcnIsC8ZJU9qBtgVCDBn1McG5C+fHtChDn/jOgL+ l4U= X-IronPort-AV: E=Sophos;i="5.78,374,1599552000"; d="scan'208";a="55668603" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa4.mentor.iphmx.com with ESMTP; 27 Nov 2020 07:47:04 -0800 IronPort-SDR: 23ry3Nqwq5OIDHIbjDuzeOLESq5quYd2In5DE7kaxCbcQYlzVGsNaRnpzUz6qqlbHt8yJva+M9 8I51Q5sQrtDr2wSA86yo5Y1e7hZqan6KhoxiHOASoMGkDAm7/Cv4WOezDi42NrU4Sr3rPHaqlW UvNIL96moQ3aItfcPYwIgXuHfw9bg6gGfWcMKWBgif/9yvAiT9psuUjcoWwtTKHGDTpN6myuoH S9nzjTELmoYN1DmyGIFJywwdVUJEhgQoWp3f2lDMLa3MvzA5LLo8kwCAYwXeeQL3vTxGoUHIAG 6Ac= Subject: Re: [patch, fortran] Correct fndecls for some library functions From: Tobias Burnus To: Thomas Koenig , "fortran@gcc.gnu.org" CC: gcc-patches References: <7d637428-5aab-f3f6-e698-ecaf93084c96@netcologne.de> <35c31819-2a40-91a3-c917-8d4fb8f52ecc@codesourcery.com> Message-ID: <151cee55-31ec-f5a2-e2b2-ce69a47b7e6a@codesourcery.com> Date: Fri, 27 Nov 2020 16:46:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <35c31819-2a40-91a3-c917-8d4fb8f52ecc@codesourcery.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-02.mgc.mentorg.com (139.181.222.2) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Nov 2020 15:47:07 -0000 Hi Thomas, On 25.11.20 12:58, Tobias Burnus wrote: > On 15.11.20 18:52, Thomas Koenig via Fortran wrote: >> +#define ADD_CHAR(c) do { *fp++ =3D c; *fp++ =3D ' '; } while(0) >> ... >> + ADD_CHAR ('.'); /* Function return. */ > Shouldn't this be ".c" instead of ". " as neither global memory is > read nor written to? >> + if (expr->rank =3D=3D 0) >> ... >> + else >> + ADD_CHAR ('w'); /* Return value is a descriptor. */ > shouldn't this be "o"? Scratch that - as it is an array descriptor, "w" is correct =E2=80=93 the b= ounds etc. are not reset. > Otherwise, it looks good to me. Tobias ----------------- Mentor Graphics (Deutschland) GmbH, Arnulfstra=C3=9Fe 201, 80634 M=C3=BCnch= en / Germany Registergericht M=C3=BCnchen HRB 106955, Gesch=C3=A4ftsf=C3=BChrer: Thomas = Heurung, Alexander Walter