From: Andrew Benson <abenson@carnegiescience.edu>
To: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
Cc: fortran@gcc.gnu.org, Jerry DeLisle <jvdelisle@charter.net>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch, fortan] PR87103 - [OOP] ICE in gfc_new_symbol() due to overlong symbol name
Date: Fri, 30 Aug 2019 08:22:00 -0000 [thread overview]
Message-ID: <17613608.UuLZ6IUFG4@andrew-precision-3520> (raw)
In-Reply-To: <20190828210036.29080178@nbbrfq.loc>
Thanks Bernhard.
On Wednesday, August 28, 2019 9:00:36 PM PDT Bernhard Reutner-Fischer wrote:
> On Fri, 23 Aug 2019 17:17:37 -0700
>
> Andrew Benson <abenson@carnegiescience.edu> wrote:
> > This PR is still open - I re-tested the patch on the current trunk. The
> > patch still applies with some line offsets (I've attached the updated
> > patch) and regtests cleanly. It would be very helpful to me to get this
> > patch committed if possible.
>
> I think Jerry ACKed the patch back then. I'll try to find the time to
> commit it maybe during one of the coming weekends unless someone else
> beats me to it..
>
> Thanks for the reminder!
> Bernhard
>
> > Thanks,
> > Andrew
> >
> > On Wednesday, September 5, 2018 12:35:04 PM PDT Bernhard Reutner-Fischer
> >
> > wrote:
> > > On Wed, 5 Sep 2018 at 03:30, Jerry DeLisle <jvdelisle@charter.net>
wrote:
> > > > On 09/04/2018 10:43 AM, Bernhard Reutner-Fischer wrote:
> > > > > On Tue, 4 Sep 2018 at 18:43, Andrew Benson
> > > > > <abenson@carnegiescience.edu>
> >
> > wrote:
> > > > >> As suggested by Janus, PR87103 is easily fixed by the attached
> > > > >> patch
> > > > >> which
> > > > >> increases GFC_MAX_SYMBOL_LEN to 76 (sufficient to hold the maximum
> > > > >> allowed F08 symbol length of 63, plus a null terminator, plus the
> > > > >> "__tmp_class_" prefix).> >
> > > > >
> > > > > This is so much wrong.
> > > > > Note that this will be fixed properly by the changes contained in
> > > > > the
> > > > > https://gcc.gnu.org/git/?p=gcc.git;a=shortlog;h=refs/heads/aldot/for
> > > > > tran
> > > > > -fe-stringpool branch.
> > > > > There we keep the GFC_MAX_SYMBOL_LEN at 63 proper but use an
> > > > > internal
> > > > > buffer double that size which in turn is sufficient to hold all
> > > > > compiler-generated identifiers.
> > > > > See gfc_get_string() even in current TOT.
> > > > >
> > > > > Maybe we should bite the bullet and start to merge the stringpool
> > > > > changes now instead of this hack?
> > > >
> > > > It all makes sense to me, please proceed. (my 2 cents worth)
> > >
> > > Ok so i will reread the fortran-fe-stringpool series and submit it
> > > here for review.
> > >
> > > Let's return to the issue at hand for a moment, though.
> > > I tested the attached alternate fix on top of the
> > > fortran-fe-stringpool branch where it fixes PR87103.
> > > Maybe somebody has spare cycles to test it on top of current trunk?
> > >
> > > thanks,
> > >
> > > [PATCH,FORTRAN] PR87103: Remove max symbol length check from
> > > gfc_new_symbol
> > >
> > > gfc_match_name does check for too long names already. Since
> > > gfc_new_symbol is also called for symbols with internal names containing
> > > compiler-generated prefixes, these internal names can easily exceed the
> > > max_identifier_length mandated by the standard.
> > >
> > > gcc/fortran/ChangeLog
> > >
> > > 2018-09-04 Bernhard Reutner-Fischer <aldot@gcc.gnu.org>
> > >
> > > PR fortran/87103
> > > * expr.c (gfc_check_conformance): Check vsnprintf for truncation.
> > > * iresolve.c (gfc_get_string): Likewise.
> > > * symbol.c (gfc_new_symbol): Remove check for maximum symbol
> > > name length. Remove redundant 0 setting of new calloc()ed
> > > gfc_symbol.
--
* Andrew Benson: http://users.obs.carnegiescience.edu/abenson/contact.html
* Galacticus: https://bitbucket.org/galacticusdev/galacticus
next prev parent reply other threads:[~2019-08-28 19:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-25 20:51 Andrew Benson
2018-09-04 16:43 ` [patch, fortan] PR87103 - [OOP] " Andrew Benson
2018-09-04 17:43 ` Bernhard Reutner-Fischer
[not found] ` <5aa0135b-1bdd-46de-e235-daed0a9a97e1@charter.net>
2018-09-05 10:35 ` Bernhard Reutner-Fischer
2018-09-05 14:24 ` Andrew Benson
2019-08-24 21:15 ` Andrew Benson
2019-08-28 22:48 ` Bernhard Reutner-Fischer
2019-08-30 8:22 ` Andrew Benson [this message]
2020-01-29 20:19 ` Andrew Benson
2020-01-30 16:28 ` Bernhard Reutner-Fischer
2020-01-30 17:50 ` Andrew Benson
2020-01-27 20:57 ` [patch, fortran] PR93461 - Bogus "symbol is already defined" with long subroutine names in submodule Andrew Benson
2020-01-28 8:21 ` Tobias Burnus
2020-01-28 16:41 ` Andrew Benson
2020-01-28 17:50 ` Tobias Burnus
2020-01-28 18:14 ` Andrew Benson
2020-01-29 0:45 ` [patch, fortran, wwwdocs] " Andrew Benson
2020-01-29 9:08 ` Gerald Pfeifer
2020-01-29 10:57 ` Tobias Burnus
2020-01-29 16:37 ` Andrew Benson
2020-01-27 23:41 ` [patch, fortran] PR93473 - ICE on valid with long module + submodule names Andrew Benson
2020-01-28 8:28 ` Tobias Burnus
2020-01-28 16:41 ` Andrew Benson
2020-01-28 17:32 ` Tobias Burnus
2020-01-28 18:05 ` Andrew Benson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17613608.UuLZ6IUFG4@andrew-precision-3520 \
--to=abenson@carnegiescience.edu \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jvdelisle@charter.net \
--cc=rep.dot.nop@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).