From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 886863858D20; Fri, 4 Feb 2022 13:57:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 886863858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: Ymv2K9nxsqVppgFgdPzfNlPi/bVpcMkZ8k+c5o3TfyK2JKKDVH/AWHZHzazRF3p8+4LK0Ax2Ix GSKVxzeB8qnonndLcwkuz+HTZTLcGFE7NRmLtlDEVxuakll3gKRVEPEq/wZuGnbaQdPP6YZw2P 8yy980WNGV0RoeS88bVAnBtjPgy1PObtSzLwKReIi/KZgDY8FNliIRfacNQDFTuw5lQcy+t4p6 HNHtp/gHITM6NOJsYmOiK7d07oeeYxa9GTaM4I4Moi6lsN4H3zlbuUrTkf5aVM9TupafdIl1qs TOG0fZyKfXkEBjbfQnR1fgcE X-IronPort-AV: E=Sophos;i="5.88,342,1635235200"; d="diff'?scan'208";a="71609583" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa2.mentor.iphmx.com with ESMTP; 04 Feb 2022 05:57:13 -0800 IronPort-SDR: sSuBFVHuPrdA/XkVsXyV07B8VHSCXo0Dn4rliuc31a69lIecsqEfL1aJ+NmlzPi8Td88uZYIh6 TpoyAF04vIO5lXSCOMzM8hfTmahqC4+VogWW9yRa5VG/xkrfNi6cbfEDgiqZPtU3mRAWVVjQ2h oWA1okwKmKgmyShke3JzelNyKff4PlSOJjfQIB+zjxSfKlkgmsTIKm6hPozznCXhNXwppLd21P uNIHoaNYxvTdoqIelTPltJebNKeWzXhok19L3AwIbU1uT3aLWSCGMiFZ1KSjNGlfNpREnGYnZT qn8= Content-Type: multipart/mixed; boundary="------------1xEQzV04UUCimDBWJ3ETUyke" Message-ID: <195b52d9-0071-1801-dfd0-041d794e93a4@codesourcery.com> Date: Fri, 4 Feb 2022 14:57:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: [committed] libgomp.fortran/allocate-1.f90: Minor cleanup (was: Re: [PATCH] [gfortran] Add support for allocate clause (OpenMP 5.0).) Content-Language: en-US To: Thomas Schwinge , Tobias Burnus CC: Hafiz Abid Qadeer , Jakub Jelinek , , References: <20211022130502.2211568-1-abidh@codesourcery.com> <20211102162714.GF304296@tucnak> <20211220200650.GN2646553@tucnak> <8735lh6mcx.fsf@euler.schwinge.homeip.net> <48d8c123-fa4f-d4a3-17de-b082de32f0bf@codesourcery.com> <87mtj7rn02.fsf@euler.schwinge.homeip.net> From: Tobias Burnus In-Reply-To: <87mtj7rn02.fsf@euler.schwinge.homeip.net> X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_SHORT, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Feb 2022 13:57:18 -0000 --------------1xEQzV04UUCimDBWJ3ETUyke Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable Hi Thomas, On 04.02.22 10:37, Thomas Schwinge wrote: >> I have attached a patch (not commited), which silences the three kind of >> warnings and fixes the interface issue. >> TODO: commit it. > Still "TODO: commit it" ;-) -- and while I haven't reviewed the changes > in detail, I did spot one item that should be addressed, I suppose: I had also spotted the 'stop' which was a left over from -fsanitized=3D... checking and had removed it locally. But good that you also keep checking patches :-) In any case, I have now _finally_ committed the patch. Attached is the simplified (-w) diff, where I did exclude the indentation changes to make the diff more readable. For the full diff, see e.g. https://gcc.gnu.org/r12-7053 Tobias ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955 --------------1xEQzV04UUCimDBWJ3ETUyke Content-Type: text/x-patch; charset="UTF-8"; name="committed.diff" Content-Disposition: attachment; filename="committed.diff" Content-Transfer-Encoding: base64 Y29tbWl0IDZkNDk4MTM1MDE2OGYxZWIzZjcyMTQ5YmQ3ZTA1YjliYTZiZWMxZmQKQXV0aG9y OiBUb2JpYXMgQnVybnVzIDx0b2JpYXNAY29kZXNvdXJjZXJ5LmNvbT4KRGF0ZTogICBGcmkg RmViIDQgMTQ6NTE6MDEgMjAyMiArMDEwMAoKICAgIGxpYmdvbXAuZm9ydHJhbi9hbGxvY2F0 ZS0xLmY5MDogTWlub3IgY2xlYW51cAogICAgCiAgICBsaWJnb21wL0NoYW5nZUxvZzoKICAg ICAgICAgICAgKiB0ZXN0c3VpdGUvbGliZ29tcC5mb3J0cmFuL2FsbG9jYXRlLTEuYyAoaXNf NjRiaXRfYWxpZ25lZCk6IFJlbmFtZWQKICAgICAgICAgICAgZnJvbSBpc182NGJpdF9hbGln bmVkXy4KICAgICAgICAgICAgKiB0ZXN0c3VpdGUvbGliZ29tcC5mb3J0cmFuL2FsbG9jYXRl LTEuZjkwOiBGaXggaW50ZXJmYWNlIGRlY2wKICAgICAgICAgICAgYW5kIHVzZSBpdCwgbW9y ZSBpbXBsaWNpdCBub25lLCByZW1vdmUgdW51c2VkIGFyZ3VtZW50LgoKZGlmZiAtLWdpdCBh L2xpYmdvbXAvdGVzdHN1aXRlL2xpYmdvbXAuZm9ydHJhbi9hbGxvY2F0ZS0xLmMgYi9saWJn b21wL3Rlc3RzdWl0ZS9saWJnb21wLmZvcnRyYW4vYWxsb2NhdGUtMS5jCmluZGV4IGQzM2Fj YzZmZWVmLi5jYjZkMzU1YWZjNiAxMDA2NDQKLS0tIGEvbGliZ29tcC90ZXN0c3VpdGUvbGli Z29tcC5mb3J0cmFuL2FsbG9jYXRlLTEuYworKysgYi9saWJnb21wL3Rlc3RzdWl0ZS9saWJn b21wLmZvcnRyYW4vYWxsb2NhdGUtMS5jCkBAIC0xLDcgKzEsNyBAQAogI2luY2x1ZGUgPHN0 ZGludC5oPgogCiBpbnQKLWlzXzY0Yml0X2FsaWduZWRfICh1aW50cHRyX3QgYSkKK2lzXzY0 Yml0X2FsaWduZWQgKHVpbnRwdHJfdCBhKQogewogICByZXR1cm4gKCAoYSAmIDB4M2YpID09 IDApOwogfQpkaWZmIC0tZ2l0IGEvbGliZ29tcC90ZXN0c3VpdGUvbGliZ29tcC5mb3J0cmFu L2FsbG9jYXRlLTEuZjkwIGIvbGliZ29tcC90ZXN0c3VpdGUvbGliZ29tcC5mb3J0cmFuL2Fs bG9jYXRlLTEuZjkwCmluZGV4IDM1ZDE3NTBiODc4Li4wNjIyNzhmOTkwOCAxMDA2NDQKLS0t IGEvbGliZ29tcC90ZXN0c3VpdGUvbGliZ29tcC5mb3J0cmFuL2FsbG9jYXRlLTEuZjkwCisr KyBiL2xpYmdvbXAvdGVzdHN1aXRlL2xpYmdvbXAuZm9ydHJhbi9hbGxvY2F0ZS0xLmY5MApA QCAtNSwzMCArNSwzMCBAQAogbW9kdWxlIG0KICAgdXNlIG9tcF9saWIKICAgdXNlIGlzb19j X2JpbmRpbmcKLSAgaW1wbGljaXQgbm9uZQorICBpbXBsaWNpdCBub25lICh0eXBlLCBleHRl cm5hbCkKIAogICBpbnRlcmZhY2UKICAgICBpbnRlZ2VyKGNfaW50KSBmdW5jdGlvbiBpc182 NGJpdF9hbGlnbmVkIChhKSBiaW5kKEMpCiAgICAgICBpbXBvcnQgOjogY19pbnQKLSAgICAg IGludGVnZXIgIDo6IGEKKyAgICAgIHR5cGUoKikgIDo6IGEKICAgICBlbmQKICAgZW5kIGlu dGVyZmFjZQotZW5kIG1vZHVsZSBtCiAKLXN1YnJvdXRpbmUgZm9vICh4LCBwLCBxLCBweCwg aCwgZmwpCitjb250YWlucworCitzdWJyb3V0aW5lIGZvbyAoeCwgcCwgcSwgaCwgZmwpCiAg IHVzZSBvbXBfbGliCiAgIHVzZSBpc29fY19iaW5kaW5nCiAgIGludGVnZXIgIDo6IHgKICAg aW50ZWdlciwgZGltZW5zaW9uKDQpIDo6IHAKICAgaW50ZWdlciwgZGltZW5zaW9uKDQpIDo6 IHEKLSAgaW50ZWdlciAgOjogcHgKICAgaW50ZWdlciAoa2luZD1vbXBfYWxsb2NhdG9yX2hh bmRsZV9raW5kKSA6OiBoCiAgIGludGVnZXIgIDo6IGZsCiAKICAgaW50ZWdlciAgOjogeQog ICBpbnRlZ2VyICA6OiByLCBpLCBpMSwgaTIsIGkzLCBpNCwgaTUKICAgaW50ZWdlciAgOjog bCwgbDMsIGw0LCBsNSwgbDYKLSAgaW50ZWdlciAgOjogbiwgbjEsIG4yLCBuMywgbjQKKyAg aW50ZWdlciAgOjogbiwgbjIsIG4zLCBuNAogICBpbnRlZ2VyICA6OiBqMiwgajMsIGo0CiAg IGludGVnZXIsIGRpbWVuc2lvbig0KSA6OiBsMgogICBpbnRlZ2VyLCBkaW1lbnNpb24oNCkg OjogcjIKQEAgLTc0LDYgKzc0LDggQEAgc3Vicm91dGluZSBmb28gKHgsIHAsIHEsIHB4LCBo LCBmbCkKICAgaWYgKHggLz0gNDIpIHRoZW4KICAgICBzdG9wIDEKICAgZW5kIGlmCisKKyAg ISEkb21wIGJhcnJpZXIKICAgdigxKSA9IDcKICAgaWYgKCAoYW5kKGZsLCAyKSAvPSAwKSAu YW5kLiAgICAgICAgICAmCiAgICAgICAgKChpc182NGJpdF9hbGlnbmVkKHgpID09IDApIC5v ci4gJgpAQCAtOTUsNyArOTcsNyBAQCBzdWJyb3V0aW5lIGZvbyAoeCwgcCwgcSwgcHgsIGgs IGZsKQogICAgIHN0b3AgNAogICBlbmQgaWYKICAgISRvbXAgZW5kIHBhcmFsbGVsCi0KK3N0 b3AKICAgISRvbXAgdGVhbXMKICAgISRvbXAgcGFyYWxsZWwgcHJpdmF0ZSAoeSkgZmlyc3Rw cml2YXRlICh4LCB3KSBhbGxvY2F0ZSAoaDogeCwgeSwgdykKIApAQCAtMzA1LDExICszMDcs MTMgQEAgc3Vicm91dGluZSBmb28gKHgsIHAsIHEsIHB4LCBoLCBmbCkKICAgICAgIC5vci4g cjIoMSkgLz0gKDUgKiBwKDMpKSAub3IuIHIyKDQpIC89ICg2ICogcCgzKSkpIHRoZW4KICAg ICBzdG9wIDI1CiAgIGVuZCBpZgotCiBlbmQgc3Vicm91dGluZQorZW5kIG1vZHVsZSBtCiAK IHByb2dyYW0gbWFpbgogICB1c2Ugb21wX2xpYgorICB1c2UgbQorICBpbXBsaWNpdCBub25l ICh0eXBlLCBleHRlcm5hbCkKICAgaW50ZWdlciwgZGltZW5zaW9uKDQpIDo6IHAKICAgaW50 ZWdlciwgZGltZW5zaW9uKDQpIDo6IHEKIApAQCAtMzIzLDExICszMjcsMTEgQEAgcHJvZ3Jh bSBtYWluCiAgIGlmIChhID09IG9tcF9udWxsX2FsbG9jYXRvcikgc3RvcCAxCiAKICAgY2Fs bCBvbXBfc2V0X2RlZmF1bHRfYWxsb2NhdG9yIChvbXBfZGVmYXVsdF9tZW1fYWxsb2MpOwot ICBjYWxsIGZvbyAoNDIsIHAsIHEsIDIsIGEsIDApOwotICBjYWxsIGZvbyAoNDIsIHAsIHEs IDIsIG9tcF9kZWZhdWx0X21lbV9hbGxvYywgMCk7Ci0gIGNhbGwgZm9vICg0MiwgcCwgcSwg MiwgYSwgMSk7CisgIGNhbGwgZm9vICg0MiwgcCwgcSwgYSwgMCk7CisgIGNhbGwgZm9vICg0 MiwgcCwgcSwgb21wX2RlZmF1bHRfbWVtX2FsbG9jLCAwKTsKKyAgY2FsbCBmb28gKDQyLCBw LCBxLCBhLCAxKTsKICAgY2FsbCBvbXBfc2V0X2RlZmF1bHRfYWxsb2NhdG9yIChhKTsKLSAg Y2FsbCBmb28gKDQyLCBwLCBxLCAyLCBvbXBfbnVsbF9hbGxvY2F0b3IsIDMpOwotICBjYWxs IGZvbyAoNDIsIHAsIHEsIDIsIG9tcF9kZWZhdWx0X21lbV9hbGxvYywgMik7CisgIGNhbGwg Zm9vICg0MiwgcCwgcSwgb21wX251bGxfYWxsb2NhdG9yLCAzKTsKKyAgY2FsbCBmb28gKDQy LCBwLCBxLCBvbXBfZGVmYXVsdF9tZW1fYWxsb2MsIDIpOwogICBjYWxsIG9tcF9kZXN0cm95 X2FsbG9jYXRvciAoYSk7CiBlbmQK --------------1xEQzV04UUCimDBWJ3ETUyke--