From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by sourceware.org (Postfix) with ESMTPS id 054533858CDA; Tue, 9 Apr 2024 07:32:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 054533858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 054533858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::331 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712647946; cv=none; b=QWHE3sObrtLUN4JiqK2eE4mc3HyVx+T/Si8gaHmFxqFCrkfsb705TD6UnJZImaKOkhhEgOLM5T3vaPswqszWhUO8KiErA+0C/vb9JX5OTgZNS+Wp2QtbLCccZaRLEmCQYdztOIl1/pxGtCPIabr5o+casClljnLkaKVfl7Zsq6s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712647946; c=relaxed/simple; bh=F3NACpTLXQsmoWVT1Cs6xyuxSPJeHw0LeiMEVqoEEGM=; h=DKIM-Signature:Mime-Version:Subject:From:Date:Message-Id:To; b=QLRTMXqtqyhEU0TJcyO/0SDs3FpUcUJB+Xq0PdXvalkHlG9dT22FbtduI2sx4KZWcVzvDJ4JyIlVQPfzHfRcukA2ewrrobWZ+ZUjh4YhekRRXiGN2nOe1Q2SdDHFRm55f9zSGN5hbPFV+CkYniMCAzrcRhzyaFwPtwLn73yjngY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-4167082dabdso3325725e9.0; Tue, 09 Apr 2024 00:32:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712647943; x=1713252743; darn=gcc.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GCNkpSdjGYapWb0g/iuML9v78Abw30t+GmqoaRt00XY=; b=AVIx56mGXFnHK2go+rLPoVFtzZn2fBoCqVCYHwtxsE5S5e/0VjAIeT3dwIaKZEBeNL YvN0N2PrmGjwR+yOhYo5xx/MRrv5liId3FdghbWxzXCLedhvFnn4CKf04NLNUR3wLWEU ZC2vV+SFOGSZFnv+vCmxu3hrzvJfP38jOjXXRG7o7t8T79OIisKC4fVXoKLDtWTV5WUw oPSQW831tRsoJYR38rzN87ApbC/asGOCrt/R3LfVLsOtIEms5RMkl3PpK6Q2YcpI44L8 IyqfRdQx9BC3CMVmNxPyfz0ZssbcDviYoxtOKZgRzMYIAOFVQQBol9E9Nahj+QAvsD0+ WRaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712647943; x=1713252743; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GCNkpSdjGYapWb0g/iuML9v78Abw30t+GmqoaRt00XY=; b=hLjIY97UAnkDItziRRKhkqBjj8qlzKxhAyuNbFBkGWtXVI1i9tHkn+RLHfOiYfY7pb avonG6sAHKj+D9GUiZ8nrGDlP7U8p/fVOmlFD9OL8OnShIfL7LwJx2UnP8yVhMAOEGw5 sqf2xcfTr3CRRpHkgnwul6Dyk5w3wbN1nJ90OtoRUVZs6ajOM8RcNDTzT48HeE8cqoiQ L+MXAFz7ddU9Q6E0ZbeahFT3ShJhRgoA5CQqm9+yDAiSdl2m0GoOeoYJzqBzApT8L0na lfVBEk5YEKo/PLlQ0zdPAv3YWpn5ENKnqQNiKihdgGL3fJCxLaBvvDj7hTx8nCTb2TeR JJmA== X-Forwarded-Encrypted: i=1; AJvYcCXkXnjOd4UWzwFDnI5h1C+Hh8n/2LIcvkHl48x97M0jUP6596FxciT2IRPEv0NijqlgaTCvn5HVof3DHjzMQEvxa8286k6LHA== X-Gm-Message-State: AOJu0Yy0Re9q/mOLRVv8zTntzPGuCHrsrxzas7xnvPCNdybIOgl5EdFc GibfRV0S9phY2di+0XFOwjIT1BTd16UlMzVHL4XI9OzsLkBiCkYC X-Google-Smtp-Source: AGHT+IHchL3Bembk9eKhXwA+oinGDSTn0r0T6mlmqTyXUXDNkyE4RLiTx/ZLUuUcWEc6Phn4SRT5zw== X-Received: by 2002:a5d:4b83:0:b0:343:ba7d:8ea8 with SMTP id b3-20020a5d4b83000000b00343ba7d8ea8mr6338492wrt.0.1712647942461; Tue, 09 Apr 2024 00:32:22 -0700 (PDT) Received: from smtpclient.apple ([2a01:e34:ec56:2a80:b123:a213:2e13:24c0]) by smtp.gmail.com with ESMTPSA id j3-20020adfff83000000b00341e2146b53sm10725946wrr.106.2024.04.09.00.32.22 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Apr 2024 00:32:22 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.171.1.1\)) Subject: Re: [PATCH] Fortran: fix argument checking of intrinsics C_SIZEOF, C_F_POINTER [PR106500] From: FX Coudert X-Priority: 3 In-Reply-To: Date: Tue, 9 Apr 2024 09:32:11 +0200 Cc: fortran , gcc-patches Content-Transfer-Encoding: quoted-printable Message-Id: <1BADB9B4-62BF-43FE-845F-545128503616@gmail.com> References: To: Harald Anlauf X-Mailer: Apple Mail (2.3774.500.171.1.1) X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Harald, Thanks for the patch. > + if (attr.function) > + { > + gfc_error ("FPTR at %L to C_F_POINTER is a function returning a = pointer", > + &fptr->where); > + return false; > + } > + > if (fptr->rank > 0 && !is_c_interoperable (fptr, &msg, false, = true)) > return gfc_notify_std (GFC_STD_F2018, "Noninteroperable array = FPTR " > "at %L to C_F_POINTER: %s", &fptr->where, msg); In both of these gfc_error(), could we change our error message to say = "FPTR argument=E2=80=9D instead of =E2=80=9CFPTR=E2=80=9D? =E2=80=9CFPTR = to C_F_POINTER=E2=80=9D does not really make sense to me. This would be more in line with what the generally do: > Error: 'x' argument of 'sqrt' intrinsic at (1) must be REAL or COMPLEX So maybe =E2=80=9CFPTR argument to C_F_POINTER at %L=E2=80=9D ? That=E2=80= =99s much more readable to me. Otherwise, OK. FX=