[patch, doc] Update people who can review gfortran patches

[patch, doc] Update people who can review gfortran patches

[Thomas Koenig]

[-- Attachment #1: Type: text/plain, Size: 841 bytes --]

Hello world,

for review of its patches, gfortran relies on a group of people
who can approve patches.  Unfortuntately, many of them are not
active. Others, who have the capability and who have acted as
de facto approvers (without anybody minding) are missing.

This (somewhat overdue) patch rectifies that.  It adds Tobias Burnus,
Jakub Jelinek and Dominique d'Humieres to the list of people
who can approve other people's patches in gfortran and libgfortran.
Among the people who are currently acitive reviewers, there
was unanimous consent that this should be done.

I'm not 100% sure we need steering committee approval for this
(Toon?), if so, I'd like to request it with this mail.

I'll be AFK for a week, so I'll be able to catch up on the discussion
then and hopefully commit this patch or a variant thereof.

Best regards

	Thomas

[-- Attachment #2: index.txt --]
[-- Type: text/plain, Size: 389 bytes --]

diff --git a/htdocs/fortran/index.html b/htdocs/fortran/index.html
index 1d140b3a..242ae56c 100644
--- a/htdocs/fortran/index.html
+++ b/htdocs/fortran/index.html
@@ -104,6 +104,9 @@ people:</p>
 <li>Janus Weil</li>
 <li>Daniel Kraft</li>
 <li>Daniel Franke</li>
+<li>Tobias Burnus</li>
+<li>Jakub Jelinek</li>
+<li>Dominique d'Humieres</li>
 </ul>
 
 <p>Under the rules specified below: 

Re: [patch, doc] Update people who can review gfortran patches

[Toon Moene]

On 9/25/20 8:02 AM, Thomas Koenig via Fortran wrote:

> Hello world,
> 
> for review of its patches, gfortran relies on a group of people
> who can approve patches.  Unfortuntately, many of them are not
> active. Others, who have the capability and who have acted as
> de facto approvers (without anybody minding) are missing.
> 
> This (somewhat overdue) patch rectifies that.  It adds Tobias Burnus,
> Jakub Jelinek and Dominique d'Humieres to the list of people
> who can approve other people's patches in gfortran and libgfortran.
> Among the people who are currently acitive reviewers, there
> was unanimous consent that this should be done.
> 
> I'm not 100% sure we need steering committee approval for this
> (Toon?), if so, I'd like to request it with this mail.

Well, I would say, given the procedure you followed in asking relevant 
people for their consent and the fact that these are not names "out of 
the blue", I am convinced the steering committee would approve of this.

If questions arise, I will take care of them.

Thanks for your effort !

Kind regards,

-- 
Toon Moene - e-mail: toon@moene.org - phone: +31 346 214290
Saturnushof 14, 3738 XG  Maartensdijk, The Netherlands

Re: [patch, doc] Update people who can review gfortran patches

[Tobias Burnus]

On 9/25/20 8:02 AM, Thomas Koenig via Fortran wrote:

> for review of its patches, gfortran relies on a group of people
> who can approve patches.  Unfortuntately, many of them are not
> active. Others, who have the capability and who have acted as
> de facto approvers (without anybody minding) are missing.

I think you want to link to
https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=MAINTAINERS
which is the official list. — At least additionally.

I note the the HTML page states "contributions will be reviewed"
and not "approved" – and (nearly) any review comment is welcome,
be it from an experienced maintainer or just by someone who passes
by. Still, it is a bit misleading if this list includes
someone who is not an official reviewer.

New reviewers get added by approval of the steering committee
(https://gcc.gnu.org/steering.html, typically by some existing
maintainer/reviewer proposing a new one – by sending a private
email to one of the SC members.)

Regarding Jakub: while he is a global reviewer and very active,
for Fortran, he is mostly reviewing OpenMP and – to a lesser extent –
OpenACC patches and only a very few other patches. Thus, listing
him under 'contributions will be reviewed' is a bit misleading.

Cheers,

Tobias