public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: Harald Anlauf <anlauf@gmx.de>
To: Mikael Morin <morin-mikael@orange.fr>,
	gfortran <fortran@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] fortran: Explicitly set name for *LOC default BACK argument [PR108450]
Date: Sun, 29 Jan 2023 20:36:04 +0100	[thread overview]
Message-ID: <1b064e71-d934-b032-bd78-f837cc8d6b3d@gmx.de> (raw)
In-Reply-To: <673726a8-fdce-6c8a-0814-3d0ad666fa2c@orange.fr>

Hi Mikael,

Am 29.01.23 um 17:21 schrieb Mikael Morin:
> Hello,
>
> this is a fix for a gcc-12 ICE regression.
> This ICE rings a bell to me, and I think the change by Tobias which
> triggers it only uncovers a bug that can also happen independently in
> other cases.
>
> The problem is resolution of maxloc expressions is not idempotent, that
> is resolution changes the expression in such a way that it can't be
> successfully resolved again.
>
> I have not tried to prevent multiple resolutions, and fixed instead the
> way the expression is changed.  The patch explains the details.
>
> No regression on x86_64-pc-linux-gnu.
> OK for master and 12?

yes, ok for both.

Thanks for the patch!

Harald


      reply	other threads:[~2023-01-29 19:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-29 16:21 Mikael Morin
2023-01-29 19:36 ` Harald Anlauf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b064e71-d934-b032-bd78-f837cc8d6b3d@gmx.de \
    --to=anlauf@gmx.de \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=morin-mikael@orange.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).