From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=R2k1=6R=netcologne.de=tkoenig@sourceware.org>
Received: from cc-smtpout3.netcologne.de (cc-smtpout3.netcologne.de [89.1.8.213])
	by sourceware.org (Postfix) with ESMTPS id C77663858D1E;
	Tue, 21 Feb 2023 07:19:57 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C77663858D1E
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=netcologne.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=netcologne.de
Received: from cc-smtpin2.netcologne.de (cc-smtpin2.netcologne.de [89.1.8.202])
	by cc-smtpout3.netcologne.de (Postfix) with ESMTP id 663F1123AA;
	Tue, 21 Feb 2023 08:19:55 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=netcologne.de;
	s=nc1116a; t=1676963995;
	bh=JocuDqN8E2vJ9qROlVAcoOLlu+Yx48HGZXoFkJ08lSI=;
	h=Message-ID:Date:Subject:To:References:From:In-Reply-To:From;
	b=RuEiWLugimpILSR9xnh5GqGRcAVA7qIlwuKDFgJwTE7smo//nxpLI1ET+OyaFcDh0
	 3geWNgTu4K8TWRFyxKsdnkC86jPnFtuSFUFF1Yy10XZPJH6ss8LZBCNcDRmt0dh0Nz
	 U9AYxQ/XTeJU3eQWk41PpaKA/vqDvjncB+++snncJRfF/hm3JvR4j7moAGG/IM+UwT
	 T/yQxGwtF0AcJoW4+G+eXwa4np7qY+kohKVcJRZ6MPfmypuFUa6EI/xToH8TyZxq8w
	 B75gTok9ycy8pj+aMjSxjawRQpY+n+sAN7XPDRSZ3zV5uwW8SO/+mmawnuNb1yeHGS
	 KFBLUzG8Mf8BA==
Received: from [IPV6:2a0a:a540:2c35:0:7285:c2ff:fe6c:992d] (2a0a-a540-2c35-0-7285-c2ff-fe6c-992d.ipv6dyn.netcologne.de [IPv6:2a0a:a540:2c35:0:7285:c2ff:fe6c:992d])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	by cc-smtpin2.netcologne.de (Postfix) with ESMTPSA id 0465111DA8;
	Tue, 21 Feb 2023 08:19:52 +0100 (CET)
Message-ID: <1b3cbb1c-8994-09d0-7681-d997e9700302@netcologne.de>
Date: Tue, 21 Feb 2023 08:19:52 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] Fortran: improve checking of character length
 specification [PR96025]
To: Harald Anlauf <anlauf@gmx.de>, fortran <fortran@gcc.gnu.org>,
 gcc-patches <gcc-patches@gcc.gnu.org>
References: <trinity-70379611-3104-41fb-b298-b55372325a13-1676925762184@3c-app-gmx-bap60>
Content-Language: en-US
From: Thomas Koenig <tkoenig@netcologne.de>
In-Reply-To: <trinity-70379611-3104-41fb-b298-b55372325a13-1676925762184@3c-app-gmx-bap60>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-NetCologne-Spam: L
X-Rspamd-Action: no action
X-Rspamd-Queue-Id: 0465111DA8
X-Spamd-Bar: -
X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <fortran.gcc.gnu.org>

Hi Harald,

> the attached patch fixes an ICE on invalid (non-integer)
> specification expressions for character length in function
> declarations.  It appears that the error handling was
> already in place (mostly) and we need to essentially
> prevent run-on errors.
> 
> Regtested on x86_64-pc-linux-gnu.  OK for mainline?
As a very minor matter of style, you might want to write

           function_result_typed = check_function_result_typed ();

instead of

	  if (check_function_result_typed ())
	    function_result_typed = true;

OK either way.

> The PR is marked as a 10/11/12/13 regression, so I would
> like to backport this as far as it seems reasonable.

Also OK.

Thanks for the patch!

Best regards

	Thomas