From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by sourceware.org (Postfix) with ESMTPS id 2F6DE3858C52; Thu, 19 Jan 2023 20:21:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2F6DE3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1674159655; bh=QNh5ZAEByd0Pj5mwpBOUmawuoIK5A1fNeG+zu1c0ARg=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=L3133zLU02+mgBtiuufNKQeGXwtDM1NGcydd7tvJP7eFuZ6C3RQhgZu48KZhZeYJa 5EuNm72dXCDJdhMNlDkT/d+TUIQCevym8cJzlGzhSsdbpkT8SBNSau3ATokCaEZkPT bloVNeU/Li4Tga8sXzT3Uri6K2i6iAWxoJ665GcSKjBgUxc/JCtsWNYy7mjNobKn0B Po5fY/xySCNcsnkwCsN7KMTTHSZUB7UuEVXaLVwi2R0V363ztV/1J8zrgjOCPY7EBp t0ezR8HzlETKCetO2i2cVPEX8IppIu4opTU1dyXLFHX9MsfkznPpeITnE2Hqf96dZL BSM0donYVUBiQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.178.29] ([93.207.87.220]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MbAgq-1oh4nP2kG0-00bXhk; Thu, 19 Jan 2023 21:20:55 +0100 Message-ID: <1dd13478-afd8-0d72-7d38-8ba51a819bd1@gmx.de> Date: Thu, 19 Jan 2023 21:20:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: git out-of-order commit (was Re: [PATCH] Fortran: Remove unused declaration) To: Jason Merrill Cc: Bernhard Reutner-Fischer , gfortran , gcc-patches List , Bernhard Reutner-Fischer , Carlos O'Donell Newsgroups: gmane.comp.gcc.patches,gmane.comp.gcc.fortran References: <20221112210535.45202-1-aldot@gcc.gnu.org> <933d0150-32fd-84df-6a8a-a19f8c7d6dbc@gmx.de> Content-Language: en-US From: Harald Anlauf In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:fIEmewUIgZH4IwVlEjrlxenlwXlLgzE33z3Edl6uV5nNuXbIvyW 1Jvn7hiQjEFu8jaFSTdn9lxK1QBOm7myAfDF2VkBjd8WErU/5Lqw45tLB/6kqr0u7Jv+fPN SvEAZFYhPWlb9zAzcGVchx6b3K6mWB+MfNbaO6WbQbwFkD0Pkr5lceD9kji20EOTQWyhKrY +gT/cmeLvHtkX0COyMhAg== UI-OutboundReport: notjunk:1;M01:P0:BdLp7q7+laM=;iqI1h5KuAOp3D7vMVdh0zIfLo8M hRc2I6dBlLh+HrpoFtm0ojksfvAvBCo82qYe4iw3MAlDvC+JpMwIRZRU1OHDdJyRdDDXEW1AY zNU1egW3njeHahADAjCPMTGb9PvfBZa8ha9q09cRJiZUh09StWg0fit6iRMOnz2aTU3HDKA10 XyWUo0m1sSlf/ivt9z+9It6LqDxdtEBj2RUkz3LMQ+LTc7zvf5HGwSzC3HVh3ouL5FjZL8viq dOD+dzqnxawUOg/arzC9Ck1UslIcufozfdpdcW2gNpM6u1X8LHz1x60+goF/wixce0+Q7opFM W+gqnEHkqvdY4RkaD7um10SqNeSD8I64GvuGi9hqZ4dMkYRJBjFotFGu5fIb8Ty1/ZiqALIrr 1a/umGaWJ4VM+UxubGChI4lEi8fk7IA900LdYv0ERDeT/hHeUg8mRFVe2ndgj/FnFwDBTM3U3 z0YqZApUYrwqkwd3bMqMdoCWVCFc1gZWlteCGhPNcygR7YkIqdrfuS1o7JthGwglibrSGkY3w 8sSJvkTk27ssK5hnFjEsfOpM4x+J0MZofA1cWEY3wa8MrJ7VylyyCLwkp0G+htM20IG9U8hPg uQ21Ysgvg2HywjF6efUWDa9fo/C4q9c9k5zbxK8nefk2slxGLRPcDd2u9v/w2TJV9lFQarUZG VLd/tqJAj3fGS2Fh3YA4HIwnIOz9GIQmCxbM6YPjH6P3Cu22DwwTnJy3wNb2SNX5+ncK6+Se0 LKBDfbI2/eCe8Zef2BLqEmg4nh/vvfjFUmn1j2Fx1UQ71u5Fqgm4V/0atvpB8MTRbPSPAhy/i Lq69qFlSoJFsw+IyAzz72vqgmX42yRw+Qwp5Ty+U19oi/uLWYnPpraDRM/eXEB6bOjFUWWM9V A59IM2sGDMHnnvqkZbvHEHDCHWnKSgI0WM4tF+A3QyJvuDih7yi5+CUoS48J/Knlu84U6pCzo HTBWwAcr3LJczPvxYzENhA2R6G8= X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Am 19.01.23 um 20:39 schrieb Jason Merrill via Gcc-patches: > On Sat, Nov 12, 2022 at 4:24 PM Harald Anlauf via Gcc-patches > wrote: >> >> Am 12.11.22 um 22:05 schrieb Bernhard Reutner-Fischer via Gcc-patches: >>> This function definition was removed years ago, remove it's prototype. >>> >>> gcc/fortran/ChangeLog: >>> >>> * gfortran.h (gfc_check_include): Remove declaration. >>> --- >>> gcc/fortran/gfortran.h | 1 - >>> 1 file changed, 1 deletion(-) >>> --- >>> Regtests cleanly, ok for trunk? >>> >>> diff --git a/gcc/fortran/gfortran.h b/gcc/fortran/gfortran.h >>> index c4deec0d5b8..ce3ad61bb52 100644 >>> --- a/gcc/fortran/gfortran.h >>> +++ b/gcc/fortran/gfortran.h >>> @@ -3208,7 +3208,6 @@ int gfc_at_eof (void); >>> int gfc_at_bol (void); >>> int gfc_at_eol (void); >>> void gfc_advance_line (void); >>> -int gfc_check_include (void); >>> int gfc_define_undef_line (void); >>> >>> int gfc_wide_is_printable (gfc_char_t); >> >> OK, thanks. > > Somehow this was applied with a CommitDate in 2021, breaking scripts > that assume monotonically increasing CommitDate. Anyone know how that > could have happened? It is quite unusual that the CommitDate is before the AuthorDate: % git show --pretty=3Dfuller 7ce0cee77adf33397d0ba61e7445effd8a5d8fcc | head -5 commit 7ce0cee77adf33397d0ba61e7445effd8a5d8fcc Author: Bernhard Reutner-Fischer AuthorDate: Sat Nov 6 06:51:00 2021 +0100 Commit: Bernhard Reutner-Fischer CommitDate: Sat Nov 6 06:48:00 2021 +0100 Could this have prevented checks to work properly? Harald > Jason > >