From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id CAA2F3858412; Sat, 5 Feb 2022 19:09:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CAA2F3858412 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=mentor.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: 0PHJsWi7e2VgxELwDNNHNsFx9W1auNkyIuEnaSnMV4jNGj8eJktL9Jrvj2cC1jBj0Lsyd4qI4h Zm2/T7/X5uhc3W7dTMrscWyvh9VVaWBKt2KciGnr0QEPD/fhFzGipQAM5ehokLuOfTeyQ8rMwV Y7aE86ubwU/P0lqntsveFjUDthHbLBBHi1hirsgOfEQiqdrGKuHOsHiZmNe8mHm1janRK9m+0e RNuoQChUjTMalPos3s0sJRFsKWR1veL5ahLlYnNUoNmthFZj5cAdE4EXoIn6dmykBECZ9LjsQc FoO9FeNL2OZz/jL23B87RqrC X-IronPort-AV: E=Sophos;i="5.88,346,1635235200"; d="scan'208,223";a="71599837" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa4.mentor.iphmx.com with ESMTP; 05 Feb 2022 11:09:40 -0800 IronPort-SDR: X69Xy/I+8vqbnKZd/yAbknxYOiNt0LqOilon1av3Vn+Ek6vZj/z76XHqJJnG+i4vctXk3BJaFe nPZJQsygTPxStfYBtpfOjWJtlGhHXeZ2NR6NEYUFEKfqKl8nysCoIvEcQUi9G6QM6fUWMHdowZ S+jXBnN7mVnCKjmHjdGqapSrFGB0RtShru2cZQm75IsWdL7sZIiqvYYQnfXWQHvDoeG6KCX9T5 goP3INqDMfZDgwnPgqcRfC0YaYg3It8kX50Lv8nZFcw5HKmtah2zvvtEDi87ADusg+Cj7EnVUc 6Ug= Content-Type: multipart/mixed; boundary="------------LoyVY40aUHuvGRA99lE1Jd3G" Message-ID: <1fff44cf-e1c4-110b-80a6-78ca00b9ce4a@mentor.com> Date: Sat, 5 Feb 2022 19:09:35 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] [gfortran] Add support for allocate clause (OpenMP 5.0). Content-Language: en-US From: Hafiz Abid Qadeer To: Thomas Schwinge , Tobias Burnus , Jakub Jelinek CC: , References: <20211022130502.2211568-1-abidh@codesourcery.com> <20211102162714.GF304296@tucnak> <20211220200650.GN2646553@tucnak> <8735lh6mcx.fsf@euler.schwinge.homeip.net> <48d8c123-fa4f-d4a3-17de-b082de32f0bf@codesourcery.com> <87r18wtbol.fsf@euler.schwinge.homeip.net> <343f7669-0e6a-11eb-3580-e351711f02b9@mentor.com> <87k0ebrmk6.fsf@euler.schwinge.homeip.net> In-Reply-To: X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-07.mgc.mentorg.com (139.181.222.7) To SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3) X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_SHORT, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Feb 2022 19:09:43 -0000 --------------LoyVY40aUHuvGRA99lE1Jd3G Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On 04/02/2022 11:25, Hafiz Abid Qadeer wrote: > On 04/02/2022 09:46, Thomas Schwinge wrote: > >> >> Abid, are you going to address these? I think it does make sense if the >> C/C++ and Fortran test cases match as much as feasible. >> > Sure. I will do that. The attached patch address those issues apart from removing pool_size trait. Thanks -- Hafiz Abid Qadeer --------------LoyVY40aUHuvGRA99lE1Jd3G Content-Type: text/x-patch; charset="UTF-8"; name="0001-libgomp-Fix-multiple-issue-in-the-testcase-allocate-.patch" Content-Disposition: attachment; filename*0="0001-libgomp-Fix-multiple-issue-in-the-testcase-allocate-.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA3YjRkYmQ1YjdjODUzZjAxNjU0MzZlZjU4MzM5NjYzZWRjZTgwMmQ1IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIYWZpeiBBYmlkIFFhZGVlciA8YWJpZGhAY29kZXNv dXJjZXJ5LmNvbT4KRGF0ZTogTW9uLCAzMSBKYW4gMjAyMiAxOTowMjoxNCArMDAwMApTdWJq ZWN0OiBbUEFUQ0hdIFtsaWJnb21wXSBGaXggbXVsdGlwbGUgaXNzdWUgaW4gdGhlIHRlc3Rj YXNlIGFsbG9jYXRlLTEuZjkwLgoKMS4gVGhvbWFzIHJlcG9ydGVkIGluCmh0dHBzOi8vZ2Nj LmdudS5vcmcvcGlwZXJtYWlsL2djYy1wYXRjaGVzLzIwMjItSmFudWFyeS81ODkwMzkuaHRt bAp0aGF0IHRoaXMgdGVzdGNhc2UgaXMgcmFuZG9tbHkgZmFpbGluZy4gVGhlIHByb2JsZW0g d2FzIGZpeGVkIHBvb2wKc2l6ZSB3aGljaCB3YXMgZXhoYXVzdGVkIHdoZW4gdGhlcmUgd2Vy ZSBhIGxvdCBvZiB0aHJlYWRzLiBGaXhlZCBpdApieSByZW1vdmluZyBwb29sX3NpemUgdHJh aXQgd2hpY2ggY2F1c2VzIGRlZmF1bHQgcG9vbCBzaXplIHRvIGJlIHVzZWQKd2hpY2ggc2hv dWxkIGJlIGJpZyBlbm91Z2guCgoyLiBBcnJheSBpbmRpY2VzIGhhdmUgYmVlbiBjaGFuZ2Vk IHRvIGNoZWNrIHRoZSBsYXN0IGVsZW1lbnQgaW4gdGhlCmFycmF5LgoKMy4gUmVtb3ZlIGEg cmVkdW5kYW50IGFzc2lnbm1lbnQgYW5kIG1vdmUgc29tZSBjb2RlIHRvIGJldHRlciBtYXRj aApDIHRlc3RjYXNlLgoKbGliZ29tcC9DaGFuZ2VMb2c6CgoJKiB0ZXN0c3VpdGUvbGliZ29t cC5mb3J0cmFuL2FsbG9jYXRlLTEuZjkwOiBSZW1vdmUgcG9vbF9zaXplCgl0cmFpdC4gIFRl c3QgbGFzdCBpbmRleCBpbiB3IGFuZCB2IGFycmF5LiAgUmVtb3ZlIHJlZHVuZGFudAoJYXNz aWdubWVudCB0byBWKDEpLiAgTW92ZSBhbGlnbm1lbnQgY2hlY2tzIGF0IHRoZSBlbmQgb2YK CXBhcmFsbGVsIHJlZ2lvbi4KLS0tCiAuLi4vdGVzdHN1aXRlL2xpYmdvbXAuZm9ydHJhbi9h bGxvY2F0ZS0xLmY5MCAgfCAyNiArKysrKysrKystLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdl ZCwgMTIgaW5zZXJ0aW9ucygrKSwgMTQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGli Z29tcC90ZXN0c3VpdGUvbGliZ29tcC5mb3J0cmFuL2FsbG9jYXRlLTEuZjkwIGIvbGliZ29t cC90ZXN0c3VpdGUvbGliZ29tcC5mb3J0cmFuL2FsbG9jYXRlLTEuZjkwCmluZGV4IDBhMzFk MzVkNWFjLi4xNTQ3ZDJiYWVlZiAxMDA2NDQKLS0tIGEvbGliZ29tcC90ZXN0c3VpdGUvbGli Z29tcC5mb3J0cmFuL2FsbG9jYXRlLTEuZjkwCisrKyBiL2xpYmdvbXAvdGVzdHN1aXRlL2xp YmdvbXAuZm9ydHJhbi9hbGxvY2F0ZS0xLmY5MApAQCAtNzQsMzEgKzc0LDMwIEBAIHN1YnJv dXRpbmUgZm9vICh4LCBwLCBxLCBoLCBmbCkKICAgaWYgKHggLz0gNDIpIHRoZW4KICAgICBz dG9wIDEKICAgZW5kIGlmCi0gIHYoMSkgPSA3Ci0gIGlmICggKGFuZChmbCwgMikgLz0gMCkg LmFuZC4gICAgICAgICAgJgotICAgICAgICgoaXNfNjRiaXRfYWxpZ25lZCh4KSA9PSAwKSAu b3IuICYKLSAgICAgICAgKGlzXzY0Yml0X2FsaWduZWQoeSkgPT0gMCkgLm9yLiAmCi0gICAg ICAgIChpc182NGJpdF9hbGlnbmVkKHYoMSkpID09IDApKSkgdGhlbgotICAgICAgc3RvcCAy Ci0gIGVuZCBpZgogCiAgICEkb21wIGJhcnJpZXIKICAgeSA9IDE7CiAgIHggPSB4ICsgMQog ICB2KDEpID0gNwotICB2KDQxKSA9IDgKKyAgdig0MikgPSA4CiAgICEkb21wIGJhcnJpZXIK ICAgaWYgKHggLz0gNDMgLm9yLiB5IC89IDEpIHRoZW4KICAgICBzdG9wIDMKICAgZW5kIGlm Ci0gIGlmICh2KDEpIC89IDcgLm9yLiB2KDQxKSAvPSA4KSB0aGVuCisgIGlmICh2KDEpIC89 IDcgLm9yLiB2KDQyKSAvPSA4KSB0aGVuCiAgICAgc3RvcCA0CiAgIGVuZCBpZgorICBpZiAo IChhbmQoZmwsIDIpIC89IDApIC5hbmQuICAgICAgICAmCisgICAgICgoaXNfNjRiaXRfYWxp Z25lZCh4KSA9PSAwKSAub3IuICYKKyAgICAgIChpc182NGJpdF9hbGlnbmVkKHkpID09IDAp IC5vci4gJgorICAgICAgKGlzXzY0Yml0X2FsaWduZWQodigxKSkgPT0gMCkpKSB0aGVuCisg ICAgc3RvcCAyCisgIGVuZCBpZgogICAhJG9tcCBlbmQgcGFyYWxsZWwKICAgISRvbXAgdGVh bXMKICAgISRvbXAgcGFyYWxsZWwgcHJpdmF0ZSAoeSkgZmlyc3Rwcml2YXRlICh4LCB3KSBh bGxvY2F0ZSAoaDogeCwgeSwgdykKIAotICBpZiAoeCAvPSA0MiAub3IuIHcoMTcpIC89IDE3 IC5vci4gdyg0MSkgLz0gNDEpIHRoZW4KKyAgaWYgKHggLz0gNDIgLm9yLiB3KDE3KSAvPSAx NyAub3IuIHcoNDIpIC89IDQyKSB0aGVuCiAgICAgc3RvcCA1CiAgIGVuZCBpZgogICAhJG9t cCBiYXJyaWVyCkBAIC0zMTQsMTMgKzMxMywxMiBAQCBwcm9ncmFtIG1haW4KICAgaW50ZWdl ciwgZGltZW5zaW9uKDQpIDo6IHAKICAgaW50ZWdlciwgZGltZW5zaW9uKDQpIDo6IHEKIAot ICB0eXBlIChvbXBfYWxsb2N0cmFpdCkgOjogdHJhaXRzKDMpCisgIHR5cGUgKG9tcF9hbGxv Y3RyYWl0KSA6OiB0cmFpdHMoMikKICAgaW50ZWdlciAob21wX2FsbG9jYXRvcl9oYW5kbGVf a2luZCkgOjogYQogCiAgIHRyYWl0cyA9IFtvbXBfYWxsb2N0cmFpdCAob21wX2F0a19hbGln bm1lbnQsIDY0KSwgJgotICAgICAgICAgICAgb21wX2FsbG9jdHJhaXQgKG9tcF9hdGtfZmFs bGJhY2ssIG9tcF9hdHZfbnVsbF9mYiksICYKLSAgICAgICAgICAgIG9tcF9hbGxvY3RyYWl0 IChvbXBfYXRrX3Bvb2xfc2l6ZSwgODE5MildCi0gIGEgPSBvbXBfaW5pdF9hbGxvY2F0b3Ig KG9tcF9kZWZhdWx0X21lbV9zcGFjZSwgMywgdHJhaXRzKQorICAgICAgICAgICAgb21wX2Fs bG9jdHJhaXQgKG9tcF9hdGtfZmFsbGJhY2ssIG9tcF9hdHZfbnVsbF9mYildCisgIGEgPSBv bXBfaW5pdF9hbGxvY2F0b3IgKG9tcF9kZWZhdWx0X21lbV9zcGFjZSwgMiwgdHJhaXRzKQog ICBpZiAoYSA9PSBvbXBfbnVsbF9hbGxvY2F0b3IpIHN0b3AgMQogCiAgIGNhbGwgb21wX3Nl dF9kZWZhdWx0X2FsbG9jYXRvciAob21wX2RlZmF1bHRfbWVtX2FsbG9jKTsKLS0gCjIuMjUu MQoK --------------LoyVY40aUHuvGRA99lE1Jd3G--