From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79065 invoked by alias); 20 Nov 2015 01:31:35 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 79040 invoked by uid 89); 20 Nov 2015 01:31:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.3 required=5.0 tests=AWL,BAYES_50,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: troutmask.apl.washington.edu Received: from troutmask.apl.washington.edu (HELO troutmask.apl.washington.edu) (128.95.76.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 20 Nov 2015 01:31:34 +0000 Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id tAK1VW5g054012 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 19 Nov 2015 17:31:32 -0800 (PST) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id tAK1VWNo054011; Thu, 19 Nov 2015 17:31:32 -0800 (PST) (envelope-from sgk) Date: Fri, 20 Nov 2015 01:31:00 -0000 From: Steve Kargl To: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [PATCH] (Partial) Implementation of simplificaiton of CSHIFT Message-ID: <20151120013132.GA53996@troutmask.apl.washington.edu> References: <20151120005836.GA53763@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151120005836.GA53763@troutmask.apl.washington.edu> User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00121.txt.bz2 On Thu, Nov 19, 2015 at 04:58:36PM -0800, Steve Kargl wrote: > + else > + { > + int dm; > + > + if (dim) > + { > + if (!gfc_is_constant_expr (dim)) > + return NULL; > + > + dm = mpz_get_si (dim->value.integer); > + } > + else > + dm = 1; > + > + gfc_error ("Simplification of CSHIFT with an array with rank > 1 " > + "no yet support"); > + } > + To save some time, the dim portion of the patch isn't correct. dim can be scalar or rank 1 array. I'll #if 0 ... #endif this section unless I persevere with the rank > 1 case. -- Steve