From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50008 invoked by alias); 21 Nov 2015 18:20:18 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 49990 invoked by uid 89); 21 Nov 2015 18:20:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: troutmask.apl.washington.edu Received: from troutmask.apl.washington.edu (HELO troutmask.apl.washington.edu) (128.95.76.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 21 Nov 2015 18:20:17 +0000 Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id tALIKEiW023763 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 21 Nov 2015 10:20:14 -0800 (PST) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id tALIKEAI023762; Sat, 21 Nov 2015 10:20:14 -0800 (PST) (envelope-from sgk) Date: Sat, 21 Nov 2015 18:20:00 -0000 From: Steve Kargl To: "H.J. Lu" Cc: Paul Richard Thomas , "fortran@gcc.gnu.org" , gcc-patches Subject: Re: [PATCH] (Partial) Implementation of simplificaiton of CSHIFT Message-ID: <20151121182014.GA23753@troutmask.apl.washington.edu> References: <20151120005836.GA53763@troutmask.apl.washington.edu> <20151120200947.GA61350@troutmask.apl.washington.edu> <20151121162657.GA23304@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00129.txt.bz2 On Sat, Nov 21, 2015 at 10:07:35AM -0800, H.J. Lu wrote: > On Sat, Nov 21, 2015 at 8:26 AM, Steve Kargl > wrote: > > On Sat, Nov 21, 2015 at 11:41:51AM +0100, Paul Richard Thomas wrote: > >> > >> Just a couple of small typos: > >> "Unexpected expr_type cause an ICE" ; causes? > >> "! An array of derived types workd too." ; works? > >> > >> Apart from that it's OK for trunk. > >> > >> Thanks for the patch > >> > > > > Thanks for the the review. I don't have a clue as > > to how to do simplification for rank > 2. :( > > > > It breaks bootstrap: > > int dm; > > /* DIM is only useful for rank > 1, but deal with it here as one can > set DIM = 1 for rank = 1. */ > if (dim) > { > if (!gfc_is_constant_expr (dim)) > return NULL; > dm = mpz_get_si (dim->value.integer); > } > else > dm = 1; > > dm is set, but never used. > Perhaps, bootstrap needs to set appropriate warning levels. -- Steve