From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99382 invoked by alias); 1 Dec 2015 16:41:43 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 99345 invoked by uid 89); 1 Dec 2015 16:41:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: troutmask.apl.washington.edu Received: from troutmask.apl.washington.edu (HELO troutmask.apl.washington.edu) (128.95.76.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 01 Dec 2015 16:41:42 +0000 Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id tB1GfdX5021853 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 1 Dec 2015 08:41:39 -0800 (PST) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id tB1Gfdab021852; Tue, 1 Dec 2015 08:41:39 -0800 (PST) (envelope-from sgk) Date: Tue, 01 Dec 2015 16:41:00 -0000 From: Steve Kargl To: Bernhard Reutner-Fischer Cc: gfortran , GCC Patches , David Malcolm Subject: Re: [PATCH] RFC: Use Levenshtein spelling suggestions in Fortran FE Message-ID: <20151201164139.GA21769@troutmask.apl.washington.edu> References: <1448974501-30981-1-git-send-email-rep.dot.nop@gmail.com> <1448974501-30981-4-git-send-email-rep.dot.nop@gmail.com> <20151201150153.GA20747@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00010.txt.bz2 On Tue, Dec 01, 2015 at 05:12:57PM +0100, Bernhard Reutner-Fischer wrote: > On 1 December 2015 at 16:01, Steve Kargl > wrote: > > On Tue, Dec 01, 2015 at 01:55:01PM +0100, Bernhard Reutner-Fischer wrote: > >> > >> David Malcolm nice Levenshtein distance spelling check helpers > >> were used in some parts of other frontends. This proposed patch adds > >> some spelling corrections to the fortran frontend. > > > What problem are you trying to solve here? The patch looks like > > The idea is to improve the programmer experience when writing code. > See the testcases enclosed in the patch. I consider this a feature :) Opinions differ. I consider it unnecessary bloat. > > unneeded complexity with the result of injecting C++ idioms into > > the Fortran FE. > > What C++ idioms are you referring to? The autovec? > AFAIU the light use of C++ in GCC is deemed OK. I see usage of > std::swap and std::map in the FE, not to mention the wide-int uses > (wi::). Thus we don't have to realloc/strcat but can use vectors to > the same effect, just as other frontends, including the C frontend, > do. > I take it you remember that we had to change all "try" to something > C++ friendly. If the Fortran FE meant to opt-out of being compiled > with a C++ compiler in the first place, why were all the C++ clashes > rewritten, back then? :) Yes, I know there are other C++ (mis)features within the Fortran FE especially in the trans-*.c files. Those are accepted (by some) as necessary evils to interface with the ME. Your patch injects C++ into otherwise perfectly fine C code, which makes it more difficult for those with no or very limited C++ knowledge to maintain the gfortran. There are currently 806 open bug reports for gfortran. AFAIK, your patch does not address any of those bug reports. The continued push to inject C++ into the Fortran FE will have the (un)intentional consequence of forcing at least one active gfortran contributor to stop. -- Steve