From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66866 invoked by alias); 1 Dec 2015 19:49:12 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 66813 invoked by uid 89); 1 Dec 2015 19:49:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: troutmask.apl.washington.edu Received: from troutmask.apl.washington.edu (HELO troutmask.apl.washington.edu) (128.95.76.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 01 Dec 2015 19:49:08 +0000 Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id tB1Jn6DD023626 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 1 Dec 2015 11:49:06 -0800 (PST) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id tB1Jn5uI023625; Tue, 1 Dec 2015 11:49:05 -0800 (PST) (envelope-from sgk) Date: Tue, 01 Dec 2015 19:49:00 -0000 From: Steve Kargl To: Bernhard Reutner-Fischer Cc: gfortran , GCC Patches , David Malcolm Subject: Re: [PATCH] RFC: Use Levenshtein spelling suggestions in Fortran FE Message-ID: <20151201194905.GA22678@troutmask.apl.washington.edu> References: <1448974501-30981-1-git-send-email-rep.dot.nop@gmail.com> <1448974501-30981-4-git-send-email-rep.dot.nop@gmail.com> <20151201150153.GA20747@troutmask.apl.washington.edu> <20151201164139.GA21769@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00017.txt.bz2 On Tue, Dec 01, 2015 at 06:34:57PM +0100, Bernhard Reutner-Fischer wrote: > On 1 December 2015 at 17:41, Steve Kargl > > > > Yes, I know there are other C++ (mis)features within the > > Fortran FE especially in the trans-*.c files. Those are > > accepted (by some) as necessary evils to interface with > > the ME. Your patch injects C++ into otherwise perfectly > > fine C code, which makes it more difficult for those with > > no or very limited C++ knowledge to maintain the gfortran. > > So you're in favour of using realloc and strcat, ok. I can use that. > Let me see if ipa-icf can replace all the identical tails of the > lookup_*_fuzzy into a common helper. > Shouldn't rely on LTO anyway nor ipa-icf i suppose. Yes, I would prefer it, but certainly won't demand it. There are other Fortran contributors/maintainers. They may prefer you approach, so give them time to speak up. -- Steve