From: Jakub Jelinek <jakub@redhat.com>
To: Cesar Philippidis <cesar@codesourcery.com>
Cc: Thomas Schwinge <thomas@codesourcery.com>,
Julian Brown <julian@codesourcery.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
James Norris <jnorris@codesourcery.com>,
"Joseph S. Myers" <joseph@codesourcery.com>,
Nathan Sidwell <Nathan_Sidwell@mentor.com>,
Fortran List <fortran@gcc.gnu.org>
Subject: Re: [OpenACC 0/7] host_data construct
Date: Wed, 02 Dec 2015 19:35:00 -0000 [thread overview]
Message-ID: <20151202193502.GY5675@tucnak.redhat.com> (raw)
In-Reply-To: <565F437A.6090103@codesourcery.com>
On Wed, Dec 02, 2015 at 11:16:10AM -0800, Cesar Philippidis wrote:
> > --- gcc/testsuite/gfortran.dg/goacc/coarray_2.f90
> > +++ gcc/testsuite/gfortran.dg/goacc/coarray_2.f90
> > @@ -3,6 +3,7 @@
> > !
> > ! PR fortran/63861
> > ! { dg-xfail-if "<http://gcc.gnu.org/PR63861>" { *-*-* } }
> > +! { dg-excess-errors "TODO" }
>
> This host_data patch exposed a bug in the fortran front end where it was
> allowing arrays to be used as reduction variables. If replace you
> replace codimension with dimension, you'd see a similar ICE. The
> attached patch, while it doesn't make any attempt to fix the gimplifier
> changes, does teach the fortran front end to error on acc reductions
> containing array variables.
Does the OpenACC standard disallow array reductions?
Just asking, because OpenMP allows them (up to 4.0 only in Fortran,
in 4.5 also C/C++ array sections are allowed).
If the OpenACC standard disallows them, then it is desirable to reject them
and the patch is ok, otherwise you should try harder to support them ;).
Jakub
next prev parent reply other threads:[~2015-12-02 19:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <56293476.5020801@codesourcery.com>
[not found] ` <562A578E.4080907@codesourcery.com>
[not found] ` <20151026183422.GW478@tucnak.redhat.com>
[not found] ` <20151102183339.365c3d33@octopus>
[not found] ` <20151112111621.657650bc@octopus>
[not found] ` <20151118124747.30a2ec5d@octopus>
[not found] ` <20151119131345.GX5675@tucnak.redhat.com>
[not found] ` <20151119142650.5a8842e4@octopus>
[not found] ` <20151119155723.GA5675@tucnak.redhat.com>
[not found] ` <20151130193034.71143aa4@octopus>
[not found] ` <877fkwn8p6.fsf@kepler.schwinge.homeip.net>
2015-12-02 19:16 ` Cesar Philippidis
2015-12-02 19:28 ` Steve Kargl
2015-12-02 19:35 ` Jakub Jelinek [this message]
2015-12-02 19:54 ` Cesar Philippidis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151202193502.GY5675@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=Nathan_Sidwell@mentor.com \
--cc=cesar@codesourcery.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jnorris@codesourcery.com \
--cc=joseph@codesourcery.com \
--cc=julian@codesourcery.com \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).