From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10940 invoked by alias); 10 Dec 2015 16:15:31 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 10846 invoked by uid 89); 10 Dec 2015 16:15:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.0 required=5.0 tests=AWL,BAYES_00,FAKE_REPLY_C,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: outpost18.zedat.fu-berlin.de Received: from outpost18.zedat.fu-berlin.de (HELO outpost18.zedat.fu-berlin.de) (130.133.4.111) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 10 Dec 2015 16:15:18 +0000 Received: from relay1.zedat.fu-berlin.de ([130.133.4.67]) by outpost.zedat.fu-berlin.de (Exim 4.85) with esmtp (envelope-from ) id <1a73s7-003qUa-T9>; Thu, 10 Dec 2015 17:15:11 +0100 Received: from mx.physik.fu-berlin.de ([160.45.64.218]) by relay1.zedat.fu-berlin.de (Exim 4.85) with esmtps (envelope-from ) id <1a73s7-003N08-R2>; Thu, 10 Dec 2015 17:15:11 +0100 Received: from login1.physik.fu-berlin.de ([160.45.66.207]) by mx.physik.fu-berlin.de with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1a73s1-0001Vh-B6; Thu, 10 Dec 2015 17:15:05 +0100 Received: from tburnus by login1.physik.fu-berlin.de with local (Exim 4.80 #3 (Debian)) id 1a73s1-0000qM-4P; Thu, 10 Dec 2015 17:15:05 +0100 Date: Thu, 10 Dec 2015 16:15:00 -0000 From: Tobias Burnus To: gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org, David Malcolm Cc: Mikael Morin , Bernhard Reutner-Fischer Subject: Re: [PATCH] v2 Re: [PATCH] RFC: Use Levenshtein spelling suggestions in Fortran FE Message-ID: <20151210161504.GC6991@physik.fu-berlin.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449623225.8490.98.camel@surprise> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2015-12/txt/msg00074.txt.bz2 David Malcolm wrote: > On Sat, 2015-12-05 at 20:53 +0100, Mikael Morin wrote: > > to get things moving again, a few comments on top of David Malcolm's: [...] > > It seems you are considering some candidates more than once here. [...] > > You have to start the lookup with the current namespace's sym_root (not > > with fun), otherwise you'll miss some candidates. > > You may also want to query parent namespaces for host-associated symbols. [...] I think the current patch doesn't not address those (as stated) and I think that some suggestions should honour the attributes better (variable vs. subroutine vs. function etc.). But I very much like the general patch. Regarding Malcolm's update: > I can't comment on Mikael's observations, but here's an updated version > of Bernhard's patch which moves the duplicated code into a new > "find_closest_string" function in gcc/spellcheck.c. That change looks good to me. BTW: I think you should write a quip for https://gcc.gnu.org/gcc-6/changes.html Tobias PS: Talking about the release notes, my feeling is that both the wiki and the release notes miss some changes, but I have to admit that I am really out of sync. It currently only lists Submodules at the Wiki, https://gcc.gnu.org/wiki/GFortran/News#GCC6 and https://gcc.gnu.org/gcc-6/changes.html has a few other items. (Both should be synced crosswise.) As additional item, I know of coarray events but there must be more items.