From: Andre Vehreschild <vehre@gmx.de>
To: Jerry DeLisle <jvdelisle@charter.net>
Cc: gfortran <fortran@gcc.gnu.org>, gcc patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch, fortran] PR66461 ICE on missing end program in fixed source
Date: Sun, 22 May 2016 11:53:00 -0000 [thread overview]
Message-ID: <20160522135328.402dcd61@vepi2> (raw)
In-Reply-To: <c97637b1-b86a-1c32-62b8-d5f3bbedf257@charter.net>
Hi Jerry,
I have tested your patch and gave it a review and the only thing I like
to have is a testcase. Can you provide one from the PR? With a testcase
I say the patch is ok for trunk and thanks for the patch.
Please note, I don't have review rights in the area the patch
addresses, although I am familiar with the matcher having worked in it.
This "review" is just a helper for an official reviewer to "second" my
opinion, hoping to get your patch faster into trunk.
Regards and thanks for the patch,
Andre
On Wed, 18 May 2016 11:25:57 -0700
Jerry DeLisle <jvdelisle@charter.net> wrote:
> Hi all,
>
> The following patch regression tested on x86-64. The ICE is from an attempt to
> free a bad expression after a MATCH_ERROR is returned. I have not been able to
> identify an exact cause, there being numerous matchers involved attempting to
> match the logical expression.
>
> Regardless, it is an error on invalid so I suggest we commit this patch and
> close the PR. I dont think its a regression as marked in bugzilla. I see the
> the internal error as far back as 4.5. If someone has an earlier build and can
> see where this does not occur, please let me know. (In case I missed something.
>
> The results of the patch gives the following:
>
> $ gfc s.f
> s.f:4:9:
>
> if ( x(1) < 0 .or.
> 1
> Error: Can not process after the IF statement shown at (1)
> f951: Error: Unexpected end of file in ‘s.f’
>
>
> OK for trunk?
>
> Regards,
>
> Jerry
>
> 2016-05-18 Jerry DeLisle <jvdelisle@gcc.gnu.org>
>
> PR fortran/66461
> * match.c (gfc_match_if): Catch unxpected MATCH_ERROR and issue an error
> message.
>
>
> diff --git a/gcc/fortran/match.c b/gcc/fortran/match.c
> index f3a4a43..85e6f92 100644
> --- a/gcc/fortran/match.c
> +++ b/gcc/fortran/match.c
> @@ -1560,7 +1560,16 @@ gfc_match_if (gfc_statement *if_type)
> if (m == MATCH_ERROR)
> return MATCH_ERROR;
>
> - gfc_match (" if ( %e ) ", &expr); /* Guaranteed to match. */
> + m = gfc_match (" if ( %e ) ", &expr); /* Not always guaranteed to match. */
> +
> + if (m == MATCH_ERROR)
> + {
> + /* Under some invalid conditions like unexpected end of file, one
> + can get an error in the match. We bail out here and hope for
> + the best (the best being an error reported somewhere else). */
> + gfc_error ("Can not process after the IF statement shown at %C");
> + return MATCH_ERROR;
> + }
>
> m = gfc_match_pointer_assignment ();
> if (m == MATCH_YES)
>
>
--
Andre Vehreschild * Email: vehre ad gmx dot de
next prev parent reply other threads:[~2016-05-22 11:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 18:26 Jerry DeLisle
2016-05-20 20:15 ` Jerry DeLisle
2016-05-22 11:53 ` Andre Vehreschild [this message]
2016-05-23 1:00 ` Jerry DeLisle
2016-05-24 4:26 ` Jerry DeLisle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160522135328.402dcd61@vepi2 \
--to=vehre@gmx.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jvdelisle@charter.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).