From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50550 invoked by alias); 31 May 2016 15:48:41 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 50531 invoked by uid 89); 31 May 2016 15:48:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 31 May 2016 15:48:38 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A59E13750F4; Tue, 31 May 2016 15:48:36 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-51.ams2.redhat.com [10.36.116.51]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u4VFmZ4w029644 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 31 May 2016 11:48:36 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id u4VFmX4l011823; Tue, 31 May 2016 17:48:33 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id u4VFmU2r011822; Tue, 31 May 2016 17:48:30 +0200 Date: Tue, 31 May 2016 15:48:00 -0000 From: Jakub Jelinek To: Thomas Schwinge Cc: gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org, Cesar Philippidis Subject: Re: Remove the unused OMP_CLAUSE_DEVICE_RESIDENT Message-ID: <20160531154830.GE28550@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <87wpmaqlii.fsf@kepler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87wpmaqlii.fsf@kepler.schwinge.homeip.net> User-Agent: Mutt/1.5.24 (2015-08-30) X-SW-Source: 2016-05/txt/msg00074.txt.bz2 On Tue, May 31, 2016 at 05:45:25PM +0200, Thomas Schwinge wrote: > While working on something else, I came across the following. Cesar, can > you please verify that this is really dead code in the Fortran front end, > which currently is the only producer of OMP_CLAUSE_DEVICE_RESIDENT? > > Also, I noticed that the Fortran front end never creates OMP_CLAUSE_MAP > with GOMP_MAP_LINK or GOMP_MAP_DEVICE_RESIDENT -- how is OpenACC declare > working at all? Cesar, if this is not a simple question to answer, > please file a GCC PR, for somebody to have a look later. > > Jakub, if the following patch is OK, should I also clean it up on release > branches as applicable, or just on trunk? It is ok for trunk, not worth backporting to any branches. But your ChangeLog doesn't cover the changes you've actually done. > Remove the unused OMP_CLAUSE_DEVICE_RESIDENT > > gcc/ > * tree-core.h (enum omp_clause_code): Remove > OMP_CLAUSE_DEVICE_RESIDENT. Adjust all users. Jakub