From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4196 invoked by alias); 1 Jun 2016 15:12:34 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 4177 invoked by uid 89); 1 Jun 2016 15:12:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=vars, Hx-languages-length:885, paying X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 01 Jun 2016 15:12:23 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8FD70C00C8E2; Wed, 1 Jun 2016 15:12:22 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-51.ams2.redhat.com [10.36.116.51]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u51FCKAE029922 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 1 Jun 2016 11:12:22 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id u51FCJ2d024315; Wed, 1 Jun 2016 17:12:19 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id u51FCHct024314; Wed, 1 Jun 2016 17:12:17 +0200 Date: Wed, 01 Jun 2016 15:12:00 -0000 From: Jakub Jelinek To: Thomas Schwinge Cc: gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org Subject: Re: [PR middle-end/71373] Handle more OMP_CLAUSE_* in nested function decomposition Message-ID: <20160601151217.GS28550@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <87h9ddrlrx.fsf@hertz.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87h9ddrlrx.fsf@hertz.schwinge.homeip.net> User-Agent: Mutt/1.5.24 (2015-08-30) X-SW-Source: 2016-06/txt/msg00007.txt.bz2 On Wed, Jun 01, 2016 at 05:06:42PM +0200, Thomas Schwinge wrote: > Here are the OpenACC bits of . > > As we're currently not paying attention to OpenACC tile clauses in the > middle end, and thus OMP_CLAUSE_TILE's arguments are not to be considered > stable, I opted to simply discard them early, simplifying their > gcc/tree-nested.c handling. Everything else should be self-explanatory. > > OK for trunk and gcc-6-branch? LGTM for both, but please as a follow-up try to work also on a C testcase with nested functions that covers all the clauses (both referencing vars/expressions that are defined in the current function and used by a nested function, and for vars/expressions that are defined in parent function and used in clauses inside of nested function. Jakub