From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95439 invoked by alias); 2 Jun 2016 16:25:28 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 95421 invoked by uid 89); 2 Jun 2016 16:25:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 02 Jun 2016 16:25:25 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 137BE80086; Thu, 2 Jun 2016 16:25:24 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-51.ams2.redhat.com [10.36.116.51]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u52GPMG3009878 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 2 Jun 2016 12:25:23 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id u52GPKi8004134; Thu, 2 Jun 2016 18:25:21 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id u52GPItj004133; Thu, 2 Jun 2016 18:25:18 +0200 Date: Thu, 02 Jun 2016 16:25:00 -0000 From: Jakub Jelinek To: Thomas Schwinge Cc: gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org Subject: Re: [PR middle-end/71373] Handle more OMP_CLAUSE_* in nested function decomposition Message-ID: <20160602162517.GM28550@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <87h9ddrlrx.fsf@hertz.schwinge.homeip.net> <5459732B.1010101@codesourcery.com> <20160601151217.GS28550@tucnak.redhat.com> <87d1nzsgt2.fsf@hertz.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87d1nzsgt2.fsf@hertz.schwinge.homeip.net> User-Agent: Mutt/1.5.24 (2015-08-30) X-SW-Source: 2016-06/txt/msg00011.txt.bz2 On Thu, Jun 02, 2016 at 06:20:57PM +0200, Thomas Schwinge wrote: > relevant. Nested function decomposition is not applicable to C++, so we > don't need any C++ test cases, right? C++ has lambdas, but those are already lowered in the FE, so yes, from the OpenMP/OpenACC FEs, tree-nested.c is only used by C and Fortran. > [PR middle-end/71373] Handle more OMP_CLAUSE_* in nested function decomposition > > gcc/ > * gimplify.c (gimplify_adjust_omp_clauses): Discard > OMP_CLAUSE_TILE. > * omp-low.c (scan_sharing_clauses): Don't expect OMP_CLAUSE_TILE. > gcc/testsuite/ > * c-c++-common/goacc/combined-directives.c: XFAIL tree scanning > for OpenACC tile clauses. > * gfortran.dg/goacc/combined-directives.f90: Likewise. > > gcc/ > PR middle-end/71373 > * tree-nested.c (convert_nonlocal_omp_clauses) > (convert_local_omp_clauses): Handle OMP_CLAUSE_ASYNC, > OMP_CLAUSE_WAIT, OMP_CLAUSE_INDEPENDENT, OMP_CLAUSE_AUTO, > OMP_CLAUSE__CACHE_, OMP_CLAUSE_TILE. > gcc/testsuite/ > PR middle-end/71373 > * gcc.dg/goacc/nested.c: New file. > * gcc.dg/goacc/pr71373.c: Likewise. > * gfortran.dg/goacc/subroutines.f90: Update. LGTM. Jakub