From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53246 invoked by alias); 17 Jun 2016 08:40:56 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 53154 invoked by uid 89); 17 Jun 2016 08:40:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.3 required=5.0 tests=AWL,BAYES_00,FAKE_REPLY_C,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 spammy=H*r:4.80 X-HELO: outpost18.zedat.fu-berlin.de Received: from outpost18.zedat.fu-berlin.de (HELO outpost18.zedat.fu-berlin.de) (130.133.4.111) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 17 Jun 2016 08:40:55 +0000 Received: from relay1.zedat.fu-berlin.de ([130.133.4.67]) by outpost.zedat.fu-berlin.de (Exim 4.85) with esmtps (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (envelope-from ) id <1bDpKb-002gYT-7E>; Fri, 17 Jun 2016 10:40:49 +0200 Received: from mx.physik.fu-berlin.de ([160.45.64.218]) by relay1.zedat.fu-berlin.de (Exim 4.85) with esmtps (TLSv1.2:DHE-RSA-AES128-SHA:128) (envelope-from ) id <1bDpKb-001ym1-2U>; Fri, 17 Jun 2016 10:40:49 +0200 Received: from login2.physik.fu-berlin.de ([160.45.66.208]) by mx.physik.fu-berlin.de with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1bDpKS-0000Yr-VH; Fri, 17 Jun 2016 10:40:40 +0200 Received: from tburnus by login2.physik.fu-berlin.de with local (Exim 4.84 #3 (Debian)) id 1bDpKS-0003oj-TN; Fri, 17 Jun 2016 10:40:40 +0200 Date: Fri, 17 Jun 2016 08:40:00 -0000 From: Tobias Burnus To: Cesar Philippidis Cc: gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org, Jakub Jelinek Subject: Re: [openacc] clean up acc directive matching in fortran Message-ID: <20160617084040.GA15605@physik.fu-berlin.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57636F15.3030509@mentor.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2016-06/txt/msg00043.txt.bz2 Cesar Philippidis wrote: > On 06/16/2016 08:30 PM, Cesar Philippidis wrote: > > This patch introduces a match_acc function to the fortran FE. It's > > almost identical to match_omp, but it passes openacc = true to > > gfc_match_omp_clauses. I supposed I could have consolidated those two > > functions, but they are reasonably simple so I left them separate. Maybe > > a follow up patch can consolidate them. I was able to eliminate a lot of > > duplicate code with this function. > > > > Is this ok for trunk and gcc-6? > And here's the patch. The patch seems to be reverse. If I regard the "-" lines as additions and the "+" lines as deletions, it makes sense and is in line with the ChangeLog and what you wrote above. Otherwise, it looks good to me. Tobias