From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91330 invoked by alias); 8 Jul 2016 16:18:34 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 91312 invoked by uid 89); 8 Jul 2016 16:18:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=queued X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 08 Jul 2016 16:18:32 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 390A8C0624A8; Fri, 8 Jul 2016 16:18:31 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-204-98.brq.redhat.com [10.40.204.98]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u68GITXs023848 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 8 Jul 2016 12:18:30 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id u68GIS95001082; Fri, 8 Jul 2016 18:18:28 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id u68GIPxJ001081; Fri, 8 Jul 2016 18:18:25 +0200 Date: Fri, 08 Jul 2016 16:18:00 -0000 From: Jakub Jelinek To: Cesar Philippidis Cc: gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org Subject: Re: [committed] Fix OpenMP parsing of the specification part in functions (PR fortran/71704) Message-ID: <20160708161825.GD7387@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <20160630174728.GQ7387@tucnak.redhat.com> <577FD13E.6060903@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <577FD13E.6060903@codesourcery.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-SW-Source: 2016-07/txt/msg00032.txt.bz2 On Fri, Jul 08, 2016 at 09:13:50AM -0700, Cesar Philippidis wrote: > On 06/30/2016 10:47 AM, Jakub Jelinek wrote: > > > The Fortran parser apparently relies in functions that have still undecided > > kind of the result that ST_GET_FCN_CHARACTERISTICS artificial statement is > > returned before any executable statements in the function. > > In normal statements that is ensured through decode_statement calling > > decode_specification_statement, which parses just a subset of statements, > > but for OpenMP we need to do something similar. If we figure out we want > > only the case_omp_decl statements, for any other we just try to gfc_match > > the keyword and if we match it, it means we'd be about to return an OpenMP > > executable statement, so instead return ST_GET_FCN_CHARACTERISTICS. > > > > Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk, > > queued for 6.2 backport. > > > > Cesar, note OpenACC will need something similar (though, > > decode_acc_statement uses just the match macro, so you'll need another one > > for the executable statements). > > Here's the OpenACC followup for this patch. Is it OK for trunk and gcc6? ENOPATCH Jakub