From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17447 invoked by alias); 9 Aug 2016 15:30:19 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 17324 invoked by uid 89); 9 Aug 2016 15:30:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Better X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 09 Aug 2016 15:30:05 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7807D3293; Tue, 9 Aug 2016 15:30:04 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-204-43.brq.redhat.com [10.40.204.43]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u79FU2r4010305 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 9 Aug 2016 11:30:04 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id u79FU1ca013846; Tue, 9 Aug 2016 17:30:01 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id u79FU0Tg013845; Tue, 9 Aug 2016 17:30:00 +0200 Date: Tue, 09 Aug 2016 15:30:00 -0000 From: Jakub Jelinek To: Chung-Lin Tang Cc: fortran@gcc.gnu.org, gcc-patches , Thomas Schwinge Subject: Re: [PATCH, Fortran, OpenACC] Fix PR70598, Fortran host_data ICE Message-ID: <20160809153000.GY14857@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <2b4f59d5-be38-2814-27bb-73aa7ffb4b8f@codesourcery.com> <20160721111322.GE7387@tucnak.redhat.com> <25374818-5cac-ef7a-04a6-fb46f8cd1076@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <25374818-5cac-ef7a-04a6-fb46f8cd1076@codesourcery.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-SW-Source: 2016-08/txt/msg00036.txt.bz2 On Fri, Jul 29, 2016 at 11:47:18PM +0800, Chung-Lin Tang wrote: > On 2016/7/21 07:13 PM, Jakub Jelinek wrote: > > Better put every && on a separate line if the whole if (...) doesn't fit > > on a single line. > > > >> > + && !n->sym->attr.cray_pointer > >> > + && !n->sym->attr.cray_pointee) > > This is too ugly. I'd instead move the if after the cray pointer/pointee > > tests, i.e. > > if (n->sym->attr.cray_pointer) > > gfc_error (...); > > else if (n->sym->attr.cray_pointee) > > gfc_error (...); > > else if (n->sym->attr.flavor == FL_VARIABLE > > && !n->sym->as > > && !n->sym->attr.pointer) > > gfc_error (...); > > > > Hi Jakub, I've adjusted the patch like you suggested. > > Patch has been re-tested and applied to gomp-4_0-branch, > okay for trunk as well? Ok with suitable ChangeLog entry. Jakub