From: Andre Vehreschild <vehre@gmx.de>
To: Paul Richard Thomas <paul.richard.thomas@gmail.com>
Cc: "fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch, fortran] PR69834 - Collision in derived type hashes
Date: Mon, 24 Oct 2016 10:18:00 -0000 [thread overview]
Message-ID: <20161024110700.1e1ce417@vepi2> (raw)
In-Reply-To: <CAGkQGiKGiBABq+6_m0nHtctOV_bTn9KRFmt2cdGkz897gn42EQ@mail.gmail.com>
Hi Paul,
concerning this:
> >> Index: gcc/fortran/trans-stmt.c
> >> ===================================================================
> >> *** gcc/fortran/trans-stmt.c (revision 241439)
> >> --- gcc/fortran/trans-stmt.c (working copy)
> >> *************** gfc_trans_do_while (gfc_code * code)
> >> *** 2331,2336 ****
> >> --- 2331,2455 ----
> > <snipp>
> >> +
> >> + /* Translate an assignment to a CLASS object
> >> + (pointer or ordinary assignment). */
> >> +
> >> +
> >
> > Here is no routine the above comment could document. Left over from prior
> > version?
>
> This is in your tree, not mine :-)
Well, now it is in everyone's tree. But I am guilty of pasting the wrong
location. The correct one is:
> Index: gcc/fortran/trans-expr.c
> ===================================================================
> *** gcc/fortran/trans-expr.c (revision 241439)
> --- gcc/fortran/trans-expr.c (working copy)
> *************** gfc_trans_class_init_assign (gfc_code *c
> *** 1508,1513 ****
> }
>
>
> + /* Return the backend_decl for the vtable of an arbitrary typespec
> + and the vtable symbol. */
> +
> + tree
> + gfc_get_vtable_decl (gfc_typespec *ts, gfc_symbol **vtab)
> + {
> + gfc_symbol *vtable = gfc_find_vtab (ts);
> + gcc_assert (vtable != NULL);
> + if (vtab != NULL)
> + *vtab = vtable;
> + if (vtable->backend_decl == NULL_TREE)
> + return gfc_get_symbol_decl (vtable);
> + else
> + return vtable->backend_decl;
> + }
> +
> +
> + /* Translate an assignment to a CLASS object
> + (pointer or ordinary assignment). */
> +
Still I do not see what the above documents. The next function is
realloc_lhs_warning () and the comment makes no sense to it.
> +
> /* End of prototype trans-class.c */
Regards,
Andre
--
Andre Vehreschild * Email: vehre ad gmx dot de
next prev parent reply other threads:[~2016-10-24 9:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAGkQGi+S-4qf+ifgVvKHRu=TEj4pRmMCCJrLxBJOLoZDZ1QP2Q@mail.gmail.com>
2016-10-23 18:14 ` Andre Vehreschild
2016-10-23 21:30 ` Paul Richard Thomas
2016-10-24 10:18 ` Andre Vehreschild [this message]
2016-10-24 11:53 ` Paul Richard Thomas
2016-11-05 10:51 ` Paul Richard Thomas
2016-11-05 14:24 Dominique d'Humières
2016-11-05 14:55 ` Janus Weil
[not found] <F8D03D98-0E54-4994-B7D4-23E757BE9A08@lps.ens.fr>
2016-10-22 8:21 ` Paul Richard Thomas
2016-10-22 8:51 ` Dominique d'Humières
2016-10-22 10:41 ` Paul Richard Thomas
-- strict thread matches above, loose matches on Subject: below --
2016-10-21 12:52 Paul Richard Thomas
2016-09-27 8:27 Paul Richard Thomas
2016-09-27 12:42 ` Paul Richard Thomas
2016-03-03 15:59 Paul Richard Thomas
2016-03-03 20:31 ` Jerry DeLisle
2016-03-13 17:31 ` Paul Richard Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161024110700.1e1ce417@vepi2 \
--to=vehre@gmx.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=paul.richard.thomas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).