public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: Paul Richard Thomas <paul.richard.thomas@gmail.com>
Cc: "dominiq at lps dot ens.fr" <gcc-bugzilla@gcc.gnu.org>,
	       "fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
	       gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch, fortran] PR84074 Incorrect indexing of array when actual argument is an array expression and dummy is polymorphic
Date: Sun, 11 Feb 2018 16:38:00 -0000	[thread overview]
Message-ID: <20180211163758.GB27561@troutmask.apl.washington.edu> (raw)
In-Reply-To: <CAGkQGiJ84HX5yPK+HsN40VgSoy1zjy8kU8QeTrbTZdfENLSd-w@mail.gmail.com>

On Sun, Feb 11, 2018 at 03:08:52PM +0000, Paul Richard Thomas wrote:
> 
> PR fortran/84074
> * trans-expr.c (gfc_conv_derived_to_class): Set the use_offset
> flag. If the is a vector subscript or the expression is not a
> variable, make the descriptor one-based.


"If the is a" ?

> + 
> + 	  /* Vector array references and non-variable expressions need be
> + 	     coverted to one-based descriptors.  */

s/coverted/converted


OK with the above fixed.

-- 
steve

  reply	other threads:[~2018-02-11 16:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-11 15:08 Paul Richard Thomas
2018-02-11 16:38 ` Steve Kargl [this message]
2018-02-11 18:30   ` Paul Richard Thomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180211163758.GB27561@troutmask.apl.washington.edu \
    --to=sgk@troutmask.apl.washington.edu \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=paul.richard.thomas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).