From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83257 invoked by alias); 18 Feb 2018 17:33:19 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 83235 invoked by uid 89); 18 Feb 2018 17:33:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=dear, Dear X-Spam-User: qpsmtpd, 2 recipients X-HELO: mout.gmx.net Received: from mout.gmx.net (HELO mout.gmx.net) (212.227.15.19) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 18 Feb 2018 17:33:16 +0000 Received: from vepi2 ([92.76.207.44]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0LZhoi-1eLmzx2NQK-00lUod; Sun, 18 Feb 2018 18:33:09 +0100 Date: Sun, 18 Feb 2018 17:33:00 -0000 From: Andre Vehreschild To: Richard Biener Cc: Jerry DeLisle , GCC-Patches-ML , GCC-Fortran-ML Subject: Re: [Fortran, PATCH, coarray, v1] Extend caf_*_by_ref () API by a type specifier Message-ID: <20180218183307.664b5df1@vepi2> In-Reply-To: <20180218180728.22b3d954@vepi2> References: <20180218163900.095f4a86@vepi2> <20180218180728.22b3d954@vepi2> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-UI-Out-Filterresults: notjunk:1;V01:K0:L6BAcKOjoJo=:fBoIpuWVoDk8/9nUYhjJ6o Nu8li9akgBOf+Np50tdqZJML0lBtVYkRmaMac42l5FOnXpf8ZQVkBHSQh+QISvqZ8+up23BHW T4kTV7lAubcmNYCxPTGPKRV2YdzeBr5fLh6cnbQ7OMRs4YRXYrQNlyZiZBFdPu8nHwqcM34t0 4RgOmQrgUiO7qAXQmXIANPAogd81keu19Qwdo7RBpdz9woXEBNZZTyJzum9Xp+VtDv9jH5RrT UKCWPNOU/PAqO53r9QrMjwNJqzxAFfztzXW1btJy36xiBk5m+k04b6412BlaU3XksBI3WzqLF ijNk6KbM8w+/ZfniCWF/AJnBzYgoAMskhylsUpG97LRrgD95wSYAKnQm+jLN+GIDgfC/NXh11 ebWcA1wVdTiFid8WwR12MWjJTT2N8a3mUJSwcUIoJX+gkC6LAn4X9BQFvltChHPBb6Xt+lC1J 5KADDU2Gev8d8LjNKSYiKYMnPmDSxp19c4dklslRe/uGqyNsXgFlkAxVmMdyYA/lf/1i98Qpw F4EvKZmYblquKvfq5qeAka+A3zNYpD0CcKY4tFEfpmdVKYzpHDeTZuoQA9AGM33ataCRwA9Sn pnBleJJyMh+CrTCIzhfd3TpHaxLEcuRK+Pd+N2MxPdLLUv3JthUvYkvu5aNwkKO3TqAEMlu6u d5W3RfFlQM50Pppp5kw44n2q47YPySEIopfGKb3yeUowz7/y70efpPtNEl5axVR2y/THhXOWb qfQtZ24LZu8itDPD6GK1WABABi0vxrSLybWVRsmhUtMfYT5G0Pe9kp4FvXJpVoIBp0WyP9NZU SFaCVnsbwWzt8wrDL6sCzxLhDJey0Dr8REg41o51eZMnfYhnbw= X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00130.txt.bz2 Well, after discussing on IRC whether RM should be bothered, I was asked to simplify release managers lives and propose, that if no one objects within one day, I will merge the patch. So any objections? - Andre On Sun, 18 Feb 2018 18:07:28 +0100 Andre Vehreschild wrote: > Dear release managers, > > this patch (for reference > https://gcc.gnu.org/ml/fortran/2018-02/msg00124.html) fixes a regression in > the coarray api by extending three relatively new functions with one or two > arguments, respectively. The patch has been approved by gfortran devs. Asking > your approval to merge it: Ok to merge to trunk? > > Regards, > Andre > > On Sun, 18 Feb 2018 08:53:41 -0800 > Jerry DeLisle wrote: > > > On 02/18/2018 07:39 AM, Andre Vehreschild wrote: > > > Hi all, > > > > > > attached patch fixes an issue with the coarray API. When a component of a > > > derived type coarray was referenced using a caf_*_by_ref () function and > > > that component was not an array with a descriptor, then the type of the > > > component was not known. Which additionally meant, that type conversion > > > was not applied as required. This patch fixes that issue by adding type > > > specifiers to the three caf_*_by_ref-calls and implements the > > > functionality for libcaf_single. This is harmless because other coarray > > > libraries that do not expect this argument just ignore it. > > > Additionally does this patch also provide the first working version of > > > caf_sendget_by_ref in libcaf_single, which previously only lead to a stack > > > corruption and was not usable since the array descriptor rework (nice job, > > > btw). > > > > > > I would like to have this patch in trunk knowing that I am somewhat late, > > > but it would be quite necessary, because as it is now, the coarray feature > > > for derived types is hardly usable. Furthermore do some people name this a > > > regression, because the caf_*_by_ref are also used when the lhs of a > > > caf_get_by_ref() is allocatable which now does not work as expected > > > anymore but before gcc-6 using caf_get() (w/o reallocation) did. > > > > > > Bootstrapped and regtested ok on x86_64-linux/f27. Ok for trunk? > > > > > > - Andre > > > > > > > This is OK from the Fortranners perspective. Should touch base with > > release manager. It looks harmless though it changes coarray API, which > > is hidden behind -fcoarray= > > > > Regards, > > > > Jerry > > -- Andre Vehreschild * Email: vehre ad gmx dot de