From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: Thomas Koenig <tkoenig@netcologne.de>
Cc: "fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch, fortran] Fix PR 84697
Date: Tue, 06 Mar 2018 22:00:00 -0000 [thread overview]
Message-ID: <20180306220015.GA78232@troutmask.apl.washington.edu> (raw)
In-Reply-To: <b5995f78-a509-0db3-17cb-df5b6d21849e@netcologne.de>
On Tue, Mar 06, 2018 at 10:40:14PM +0100, Thomas Koenig wrote:
>
> the attached patch fixes a bug, partly an 8 regression, for
> simplifying an expression containing minloc or maxloc.
>
> The underlying problem was that
>
> integer, dimension(0), parameter :: z=0
>
> ended up as EXPR_CONSTANT even though the rank was one, which
> was then passed to the simplification routines, which either
> ICEd or gave wrong results.
>
> In doing this, I had to change the logic of the is_size_zero_array
> function. Trying to call it from within the simplification rountines
> led to the simplification routines to be called, and so on... until
> the stack ran out.
>
> As soon as this is committed, I'll also look if there is anything left
> in PR66128, and close that bug if appropriate
I don't think there is anything of value left unless you want to
investigate the old g77 compatibility functions.
>
> Regression-tested. OK for trunk?
>
OK.
--
steve
prev parent reply other threads:[~2018-03-06 22:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 21:40 Thomas Koenig
2018-03-06 22:00 ` Steve Kargl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180306220015.GA78232@troutmask.apl.washington.edu \
--to=sgk@troutmask.apl.washington.edu \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=tkoenig@netcologne.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).