From: Jakub Jelinek <jakub@redhat.com>
To: Steve Kargl <sgk@troutmask.apl.washington.edu>
Cc: Richard Biener <richard.guenther@gmail.com>,
"Bin.Cheng" <amker.cheng@gmail.com>,
Janne Blomqvist <blomqvist.janne@gmail.com>,
Fortran List <fortran@gcc.gnu.org>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fortran -- clean up KILL
Date: Thu, 15 Mar 2018 16:35:00 -0000 [thread overview]
Message-ID: <20180315150810.GS8577@tucnak> (raw)
In-Reply-To: <20180315141026.GA57660@troutmask.apl.washington.edu>
On Thu, Mar 15, 2018 at 07:10:26AM -0700, Steve Kargl wrote:
> On Thu, Mar 15, 2018 at 01:35:23PM +0100, Richard Biener wrote:
> > >
> > > extern GFC_INTEGER_4 kill (GFC_INTEGER_4, GFC_INTEGER_4);
> > > extern __typeof(kill) kill __asm__("" "_gfortran_kill");
> >
> > Why do you need to jump through these hoops anyway? Just do ...
> >
>
> Not sure who the "you" refers to. The easiest
> fix be appending a 4 to kill. I'll do that
> later.
I think this is even easier, no need to rename anything:
2018-03-15 Jakub Jelinek <jakub@redhat.com>
PR libgfortran/84880
* intrinsics/kill.c (kill): Rename to...
(PREFIX (kill)): ... this. Use export_proto_np instead of export_proto.
--- libgfortran/intrinsics/kill.c.jj 2018-03-14 09:44:57.988975360 +0100
+++ libgfortran/intrinsics/kill.c 2018-03-15 16:01:02.725668658 +0100
@@ -51,11 +51,11 @@ kill_sub (GFC_INTEGER_4 pid, GFC_INTEGER
}
iexport(kill_sub);
-extern GFC_INTEGER_4 kill (GFC_INTEGER_4, GFC_INTEGER_4);
-export_proto(kill);
+extern GFC_INTEGER_4 PREFIX (kill) (GFC_INTEGER_4, GFC_INTEGER_4);
+export_proto_np(PREFIX (kill));
GFC_INTEGER_4
-kill (GFC_INTEGER_4 pid, GFC_INTEGER_4 signal)
+PREFIX (kill) (GFC_INTEGER_4 pid, GFC_INTEGER_4 signal)
{
int val;
val = (int)kill (pid, signal);
Jakub
next prev parent reply other threads:[~2018-03-15 16:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-11 16:52 Steve Kargl
2018-03-11 20:16 ` Janne Blomqvist
2018-03-11 20:42 ` Steve Kargl
2018-03-12 16:56 ` Janne Blomqvist
2018-03-12 17:37 ` Steve Kargl
2018-03-12 19:05 ` Janne Blomqvist
2018-03-13 4:08 ` Steve Kargl
2018-03-13 19:49 ` Janne Blomqvist
2018-03-14 0:57 ` Steve Kargl
2018-03-15 10:18 ` Bin.Cheng
2018-03-15 12:11 ` Bin.Cheng
2018-03-15 12:20 ` Bin.Cheng
2018-03-15 15:07 ` Steve Kargl
2018-03-15 12:35 ` Richard Biener
2018-03-15 14:10 ` Steve Kargl
2018-03-15 16:35 ` Jakub Jelinek [this message]
2018-03-15 15:45 ` Bin.Cheng
2018-03-15 17:35 ` Jakub Jelinek
2018-03-15 15:57 ` Bin.Cheng
2018-03-15 16:28 ` Steve Kargl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180315150810.GS8577@tucnak \
--to=jakub@redhat.com \
--cc=amker.cheng@gmail.com \
--cc=blomqvist.janne@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
--cc=sgk@troutmask.apl.washington.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).