From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9708 invoked by alias); 15 Mar 2018 16:35:36 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 9395 invoked by uid 89); 15 Mar 2018 16:35:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 15 Mar 2018 16:35:34 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6650B4270958 for ; Thu, 15 Mar 2018 16:35:29 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.36.118.110]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4A2361120AD5 for ; Thu, 15 Mar 2018 16:35:28 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id w2FF8Dmx001373; Thu, 15 Mar 2018 16:08:14 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id w2FF8Aqu001372; Thu, 15 Mar 2018 16:08:10 +0100 Date: Thu, 15 Mar 2018 16:35:00 -0000 From: Jakub Jelinek To: Steve Kargl Cc: Richard Biener , "Bin.Cheng" , Janne Blomqvist , Fortran List , GCC Patches Subject: Re: [PATCH] Fortran -- clean up KILL Message-ID: <20180315150810.GS8577@tucnak> Reply-To: Jakub Jelinek References: <20180312173706.GB61632@troutmask.apl.washington.edu> <20180313040809.GA69151@troutmask.apl.washington.edu> <20180314005722.GA43280@troutmask.apl.washington.edu> <20180315141026.GA57660@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180315141026.GA57660@troutmask.apl.washington.edu> User-Agent: Mutt/1.9.2 (2017-12-15) X-SW-Source: 2018-03/txt/msg00066.txt.bz2 On Thu, Mar 15, 2018 at 07:10:26AM -0700, Steve Kargl wrote: > On Thu, Mar 15, 2018 at 01:35:23PM +0100, Richard Biener wrote: > > > > > > extern GFC_INTEGER_4 kill (GFC_INTEGER_4, GFC_INTEGER_4); > > > extern __typeof(kill) kill __asm__("" "_gfortran_kill"); > > > > Why do you need to jump through these hoops anyway? Just do ... > > > > Not sure who the "you" refers to. The easiest > fix be appending a 4 to kill. I'll do that > later. I think this is even easier, no need to rename anything: 2018-03-15 Jakub Jelinek PR libgfortran/84880 * intrinsics/kill.c (kill): Rename to... (PREFIX (kill)): ... this. Use export_proto_np instead of export_proto. --- libgfortran/intrinsics/kill.c.jj 2018-03-14 09:44:57.988975360 +0100 +++ libgfortran/intrinsics/kill.c 2018-03-15 16:01:02.725668658 +0100 @@ -51,11 +51,11 @@ kill_sub (GFC_INTEGER_4 pid, GFC_INTEGER } iexport(kill_sub); -extern GFC_INTEGER_4 kill (GFC_INTEGER_4, GFC_INTEGER_4); -export_proto(kill); +extern GFC_INTEGER_4 PREFIX (kill) (GFC_INTEGER_4, GFC_INTEGER_4); +export_proto_np(PREFIX (kill)); GFC_INTEGER_4 -kill (GFC_INTEGER_4 pid, GFC_INTEGER_4 signal) +PREFIX (kill) (GFC_INTEGER_4 pid, GFC_INTEGER_4 signal) { int val; val = (int)kill (pid, signal); Jakub