From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fortran-return-50009-listarch-fortran=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 90329 invoked by alias); 15 Mar 2018 16:28:31 -0000
Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <fortran.gcc.gnu.org>
List-Subscribe: <mailto:fortran-subscribe@gcc.gnu.org>
List-Post: <mailto:fortran@gcc.gnu.org>
List-Help: <mailto:fortran-help@gcc.gnu.org>, <http://sourceware.org/lists.html#faqs>
Sender: fortran-owner@gcc.gnu.org
Received: (qmail 90309 invoked by uid 89); 15 Mar 2018 16:28:30 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=Hx-languages-length:910
X-Spam-User: qpsmtpd, 2 recipients
X-HELO: troutmask.apl.washington.edu
Received: from troutmask.apl.washington.edu (HELO troutmask.apl.washington.edu) (128.95.76.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 15 Mar 2018 16:28:29 +0000
Received: from troutmask.apl.washington.edu (localhost [127.0.0.1])	by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id w2FGSRtu066718	(version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);	Thu, 15 Mar 2018 09:28:27 -0700 (PDT)	(envelope-from sgk@troutmask.apl.washington.edu)
Received: (from sgk@localhost)	by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id w2FGSR0m066717;	Thu, 15 Mar 2018 09:28:27 -0700 (PDT)	(envelope-from sgk)
Date: Thu, 15 Mar 2018 16:28:00 -0000
From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Richard Biener <richard.guenther@gmail.com>,        "Bin.Cheng" <amker.cheng@gmail.com>,        Janne Blomqvist <blomqvist.janne@gmail.com>,        Fortran List <fortran@gcc.gnu.org>,        GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fortran -- clean up KILL
Message-ID: <20180315162827.GA66702@troutmask.apl.washington.edu>
Reply-To: sgk@troutmask.apl.washington.edu
References: <20180312173706.GB61632@troutmask.apl.washington.edu> <CAO9iq9HBO2z+1YGQw5yCVYBS=UoBM9qSYC--DoAEW8um1hixyQ@mail.gmail.com> <20180313040809.GA69151@troutmask.apl.washington.edu> <CAO9iq9EtnxK1vegKw_ec6Ybr9gjpz17LSnF0GSQ1DQJoMpYdcQ@mail.gmail.com> <20180314005722.GA43280@troutmask.apl.washington.edu> <CAHFci2_ufi4n4J4BocUYd6DAC3oexC8xZayhR_dk4Xhx22yEqw@mail.gmail.com> <CAHFci29aZ3SK0GpsyPHmhOdSOp2ma4VCZNjDkaNtE6iZmDOk9g@mail.gmail.com> <CAFiYyc1vGbothBDgW_iHftEfD2QvwDrpMu+TvUnq4nVJ=NZPfg@mail.gmail.com> <20180315141026.GA57660@troutmask.apl.washington.edu> <20180315150810.GS8577@tucnak>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180315150810.GS8577@tucnak>
User-Agent: Mutt/1.9.2 (2017-12-15)
X-IsSubscribed: yes
X-SW-Source: 2018-03/txt/msg00065.txt.bz2

On Thu, Mar 15, 2018 at 04:08:10PM +0100, Jakub Jelinek wrote:
> On Thu, Mar 15, 2018 at 07:10:26AM -0700, Steve Kargl wrote:
> > On Thu, Mar 15, 2018 at 01:35:23PM +0100, Richard Biener wrote:
> > > >
> > > > extern GFC_INTEGER_4 kill (GFC_INTEGER_4, GFC_INTEGER_4);
> > > > extern __typeof(kill) kill __asm__("" "_gfortran_kill");
> > > 
> > > Why do you need to jump through these hoops anyway?  Just do ...
> > > 
> > 
> > Not sure who the "you" refers to.  The easiest 
> > fix be appending a 4 to kill.  I'll do that 
> > later.
> 
> I think this is even easier, no need to rename anything:
> 
> 2018-03-15  Jakub Jelinek  <jakub@redhat.com>
> 
> 	PR libgfortran/84880
> 	* intrinsics/kill.c (kill): Rename to...
> 	(PREFIX (kill)): ... this.  Use export_proto_np instead of export_proto.
> 

If you haven't committed your patch, it's OK with me.
Sorry about the breakage.

-- 
Steve