From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29688 invoked by alias); 18 Mar 2018 23:20:27 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 29667 invoked by uid 89); 18 Mar 2018 23:20:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-Spam-User: qpsmtpd, 2 recipients X-HELO: troutmask.apl.washington.edu Received: from troutmask.apl.washington.edu (HELO troutmask.apl.washington.edu) (128.95.76.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 18 Mar 2018 23:20:26 +0000 Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id w2INKOui063314 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 18 Mar 2018 16:20:24 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id w2INKNhq063313; Sun, 18 Mar 2018 16:20:23 -0700 (PDT) (envelope-from sgk) Date: Sun, 18 Mar 2018 23:20:00 -0000 From: Steve Kargl To: Thomas =?iso-8859-1?Q?K=F6nig?= Cc: "fortran@gcc.gnu.org" , gcc-patches Subject: Re: [patch, fortran] Fix type conversion in large array constructors with iterators Message-ID: <20180318232023.GA63249@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu References: <8d5c9fb1-5779-6871-5a80-18996dfd6d1b@tkoenig.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8d5c9fb1-5779-6871-5a80-18996dfd6d1b@tkoenig.net> User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00101.txt.bz2 On Sun, Mar 18, 2018 at 11:23:37PM +0100, Thomas König wrote: > Hello world, > > the attached patch fixes the bug that Steve found; the patch itself > simply makes sure to copy a constructor instead of only the value > of the constructor when converting types. > > Regressoin-tested. OK for trunk? Looks good to me. Thanks for find the location to fix this. I was off in the trees. > > Maybe this is also a candidate for gcc-7, because of the silent > wrong-code issue. > As far as I am concerned, you can go back to 6-branch if the patch applies cleanly. -- Steve