From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: Thomas Koenig <tkoenig@netcologne.de>
Cc: "fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch, fortran] Remove parallell annotation from DO CONCURRENT
Date: Mon, 09 Apr 2018 21:19:00 -0000 [thread overview]
Message-ID: <20180409211927.GA52264@troutmask.apl.washington.edu> (raw)
In-Reply-To: <f4c9c32d-a03b-4e1a-5478-eaa6da773547@netcologne.de>
On Mon, Apr 09, 2018 at 10:58:13PM +0200, Thomas Koenig wrote:
> > On Mon, Apr 09, 2018 at 10:10:13PM +0200, Thomas Koenig wrote:
> >>
> >> the attached patch removes the parallel annotation from DO CONCURRENT.
> >> As discussed in the PR, the autoparallellizer currently generates
> >> wrong code. The only feasible way is to disable the annotation for
> >> gcc-8 and work on the wrong-code issues for gcc-9. This is an 8
> >> regression.
> >>
> >> Regression-tested. OK for trunk?
> >>
> >
> > Yes.
>
> Thanks for the review!
>
> However, just as I was about to commit, I thought of something else
> and, hopefully, better.
>
> The underlying problem is that the annotation does not go together
> with -ftree-parallelize-loops - so let's simply not set it if that
> flag is set.
>
> This way, we can avoid speed regressions for people who do not use
> -ftree-parallelize-loops, and it will be possible to downgrade the
> PR to a missed-optimization bug; it is also not necessary to xfail
> vect-do-concurrent-1.f90
>
> Regression-tested. OK for trunk, for this version?
In reviewing the PR audit trailing, I thought Richard indicated
the problem is in the autopar stage in the middle. Removing the
annotation simply prevents gfortran's DO CURRENT from a middle
in bug.
I'm fine with the new patch. I'll leave it up to you to decide
which is preferred.
--
Steve
next prev parent reply other threads:[~2018-04-09 21:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 20:10 Thomas Koenig
2018-04-09 20:28 ` Steve Kargl
2018-04-09 20:58 ` Thomas Koenig
2018-04-09 21:19 ` Steve Kargl [this message]
2018-04-10 6:44 ` Richard Biener
2018-04-10 13:36 ` Jakub Jelinek
2018-04-10 21:50 ` Thomas Koenig
2018-04-11 18:35 ` Jakub Jelinek
2018-04-11 18:18 ` Thomas Koenig
2018-04-11 18:35 ` Jakub Jelinek
2018-04-11 19:47 ` Thomas Koenig
2018-04-12 7:17 ` Jakub Jelinek
2018-04-12 21:14 ` Thomas Koenig
2018-04-12 21:35 ` Jakub Jelinek
2018-04-09 23:35 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180409211927.GA52264@troutmask.apl.washington.edu \
--to=sgk@troutmask.apl.washington.edu \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=tkoenig@netcologne.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).