From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101174 invoked by alias); 9 Apr 2018 21:19:30 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 101154 invoked by uid 89); 9 Apr 2018 21:19:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=audit, CURRENT X-Spam-User: qpsmtpd, 2 recipients X-HELO: troutmask.apl.washington.edu Received: from troutmask.apl.washington.edu (HELO troutmask.apl.washington.edu) (128.95.76.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Apr 2018 21:19:29 +0000 Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id w39LJRqO052334 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 9 Apr 2018 14:19:27 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id w39LJR9O052333; Mon, 9 Apr 2018 14:19:27 -0700 (PDT) (envelope-from sgk) Date: Mon, 09 Apr 2018 21:19:00 -0000 From: Steve Kargl To: Thomas Koenig Cc: "fortran@gcc.gnu.org" , gcc-patches Subject: Re: [patch, fortran] Remove parallell annotation from DO CONCURRENT Message-ID: <20180409211927.GA52264@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu References: <20180409202803.GB51810@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2018-04/txt/msg00037.txt.bz2 On Mon, Apr 09, 2018 at 10:58:13PM +0200, Thomas Koenig wrote: > > On Mon, Apr 09, 2018 at 10:10:13PM +0200, Thomas Koenig wrote: > >> > >> the attached patch removes the parallel annotation from DO CONCURRENT. > >> As discussed in the PR, the autoparallellizer currently generates > >> wrong code. The only feasible way is to disable the annotation for > >> gcc-8 and work on the wrong-code issues for gcc-9. This is an 8 > >> regression. > >> > >> Regression-tested. OK for trunk? > >> > > > > Yes. > > Thanks for the review! > > However, just as I was about to commit, I thought of something else > and, hopefully, better. > > The underlying problem is that the annotation does not go together > with -ftree-parallelize-loops - so let's simply not set it if that > flag is set. > > This way, we can avoid speed regressions for people who do not use > -ftree-parallelize-loops, and it will be possible to downgrade the > PR to a missed-optimization bug; it is also not necessary to xfail > vect-do-concurrent-1.f90 > > Regression-tested. OK for trunk, for this version? In reviewing the PR audit trailing, I thought Richard indicated the problem is in the autopar stage in the middle. Removing the annotation simply prevents gfortran's DO CURRENT from a middle in bug. I'm fine with the new patch. I'll leave it up to you to decide which is preferred. -- Steve