From: Jakub Jelinek <jakub@redhat.com>
To: Thomas Schwinge <thomas@codesourcery.com>
Cc: "Thomas König" <tk@tkoenig.net>,
"fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>,
vries@gcc.gnu.org
Subject: Re: PR85463 '[nvptx] "exit" in offloaded region doesn't terminate process' (was: [patch, libfortran, committed] Implement stop_numeric for minimal targets)
Date: Thu, 19 Apr 2018 09:36:00 -0000 [thread overview]
Message-ID: <20180419091438.GX8577@tucnak> (raw)
In-Reply-To: <87in8nsgz9.fsf@euler.schwinge.homeip.net>
On Thu, Apr 19, 2018 at 11:06:18AM +0200, Thomas Schwinge wrote:
> Hi!
>
> On Wed, 4 Apr 2018 11:30:34 +0200, Thomas König <tk@tkoenig.net> wrote:
> > the recent patch to make the gfortran and libgomp testsuites more
> > standard conforming, by replacing CALL ABORT() with STOP N, led
> > to numerous testsuite failures on nvptx because stop_numeric
> > was not implemented in minimal.c.
> >
> > I have committed the patch below in r259072 as obvious after Tom
> > de Vries had confirmed that it solves the problem.
>
> ... for some meaning of "solves the problem"; see below. ;-) Which you
> couldn't know, of course. (So, definitely thanks anyway, for promptly
> addressing the issue raised!)
My preference would be just to revert the call abort to stop n changes
in target regions.
Mapping exit to abort is weird, and making exit terminate whole process even
when called from offloaded regions might be too expensive.
Jakub
next prev parent reply other threads:[~2018-04-19 9:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 9:30 [patch, libfortran, committed] Implement stop_numeric for minimal targets Thomas König
2018-04-19 9:06 ` PR85463 '[nvptx] "exit" in offloaded region doesn't terminate process' (was: [patch, libfortran, committed] Implement stop_numeric for minimal targets) Thomas Schwinge
2018-04-19 9:36 ` Jakub Jelinek [this message]
2018-04-19 9:19 ` Thomas Schwinge
2018-04-19 9:25 ` Jakub Jelinek
2018-04-19 9:36 ` Thomas Schwinge
2018-04-19 11:32 ` Thomas König
2018-04-19 11:59 ` Thomas Schwinge
2018-04-19 17:59 ` PR85463 '[nvptx] "exit" in offloaded region doesn't terminate process' Thomas König
2018-04-25 13:56 ` PR85463 '[nvptx] "exit" in offloaded region doesn't terminate process' (was: [patch, libfortran, committed] Implement stop_numeric for minimal targets) Martin Jambor
2018-04-26 10:47 ` PR85463 '[nvptx] "exit" in offloaded region doesn't terminate process' Thomas Schwinge
2018-04-26 12:39 ` Martin Jambor
[not found] ` <20230119220005.2002779-1-thomas@codesourcery.com>
2023-01-20 20:12 ` Clean up after newlib "nvptx: In offloading execution, map '_exit' to 'abort' [GCC PR85463]" Thomas Schwinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180419091438.GX8577@tucnak \
--to=jakub@redhat.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=thomas@codesourcery.com \
--cc=tk@tkoenig.net \
--cc=vries@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).