[PATCH] Fortran cleanup patch

[PATCH] Fortran cleanup patch

[Steve Kargl]

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

The attached patch removed an unused function.
OK to commit?

2018-05-10  Steven G. Kargl  <kargl@gcc.gnu.org>

   * gfortran.h: Remove prototype.
   * symbol.c (gfc_new_undo_checkpoint): Remove unused function.

-- 
Steve

[-- Attachment #2: unused.diff --]
[-- Type: text/x-diff, Size: 1449 bytes --]

Index: gcc/fortran/gfortran.h
===================================================================
--- gcc/fortran/gfortran.h	(revision 260141)
+++ gcc/fortran/gfortran.h	(working copy)
@@ -3033,7 +3033,6 @@ int gfc_get_sym_tree (const char *, gfc_namespace *, g
 int gfc_get_ha_symbol (const char *, gfc_symbol **);
 int gfc_get_ha_sym_tree (const char *, gfc_symtree **);
 
-void gfc_new_undo_checkpoint (gfc_undo_change_set &);
 void gfc_drop_last_undo_checkpoint (void);
 void gfc_restore_last_undo_checkpoint (void);
 void gfc_undo_symbols (void);
Index: gcc/fortran/symbol.c
===================================================================
--- gcc/fortran/symbol.c	(revision 260141)
+++ gcc/fortran/symbol.c	(working copy)
@@ -3484,22 +3484,6 @@ find_common_symtree (gfc_symtree *st, gfc_common_head 
 }
 
 
-/* Clear the given storage, and make it the current change set for registering
-   changed symbols.  Its contents are freed after a call to
-   gfc_restore_last_undo_checkpoint or gfc_drop_last_undo_checkpoint, but
-   it is up to the caller to free the storage itself.  It is usually a local
-   variable, so there is nothing to do anyway.  */
-
-void
-gfc_new_undo_checkpoint (gfc_undo_change_set &chg_syms)
-{
-  chg_syms.syms = vNULL;
-  chg_syms.tbps = vNULL;
-  chg_syms.previous = latest_undo_chgset;
-  latest_undo_chgset = &chg_syms;
-}
-
-
 /* Restore previous state of symbol.  Just copy simple stuff.  */
 
 static void

Re: [PATCH] Fortran cleanup patch

[Andre Vehreschild]

On Thu, 10 May 2018 16:08:17 -0700
Steve Kargl <sgk@troutmask.apl.washington.edu> wrote:

> The attached patch removed an unused function.
> OK to commit?

Removing unused code, can only make things easier. Ok to commit IMHO.

- Andre

> 
> 2018-05-10  Steven G. Kargl  <kargl@gcc.gnu.org>
> 
>    * gfortran.h: Remove prototype.
>    * symbol.c (gfc_new_undo_checkpoint): Remove unused function.
> 


-- 
Andre Vehreschild * Email: vehre ad gmx dot de