From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27489 invoked by alias); 21 May 2018 18:59:02 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 26598 invoked by uid 89); 21 May 2018 18:59:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-9.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_ASCII_DIVIDERS,KAM_LAZY_DOMAIN_SECURITY autolearn=ham version=3.3.2 spammy=lm, ln, mn, LM X-Spam-User: qpsmtpd, 3 recipients X-HELO: troutmask.apl.washington.edu Received: from troutmask.apl.washington.edu (HELO troutmask.apl.washington.edu) (128.95.76.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 21 May 2018 18:59:00 +0000 Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id w4LIww0U057299 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 21 May 2018 11:58:58 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id w4LIwwJX057298; Mon, 21 May 2018 11:58:58 -0700 (PDT) (envelope-from sgk) Date: Mon, 21 May 2018 18:59:00 -0000 From: Steve Kargl To: Janus Weil Cc: gfortran , gcc-patches Subject: Re: [Patch, Fortran] PR 85841: [F2018] reject deleted features Message-ID: <20180521185858.GA57269@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu References: <20180520175226.GA6817@troutmask.apl.washington.edu> <20180520221947.GA8302@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="opJtzjQTFsWo+cga" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00071.txt.bz2 --opJtzjQTFsWo+cga Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 1005 On Mon, May 21, 2018 at 09:00:58AM +0200, Janus Weil wrote: > 2018-05-21 0:19 GMT+02:00 Steve Kargl : > > On Sun, May 20, 2018 at 09:44:47PM +0200, Janus Weil wrote: > >> > >> >> The patch still regtests cleanly. Ok for trunk? > >> > > >> > Patch looks good to me. The only thing that worries me is > >> > whether the patch will cause the SPEC benchmark to throw > >> > an error or warning that it did not before. As I don't have > >> > SPEC benchmark and it cost $$$, I'm not going to let it > >> > bother too much. > >> > >> Unfortunately I don't have access to SPEC either. Is anyone in a > >> position to check this? > > > > We'll find out evidently as one of the C/C++ developers run SPEC. > > Ok, we have plenty of time to fix up things before the next release anyway. > Janus, The attached patch fixes a few testcases that were missed in the original patch. Do you have these already in an updated patch, or would you like me to commit my patch? -- Steve --opJtzjQTFsWo+cga Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="followup.diff" Content-length: 2195 Index: gcc/testsuite/gfortran.dg/graphite/block-2.f =================================================================== --- gcc/testsuite/gfortran.dg/graphite/block-2.f (revision 260479) +++ gcc/testsuite/gfortran.dg/graphite/block-2.f (working copy) @@ -1,3 +1,5 @@ +! { dg-do compile } +! { dg-options "-std=legacy" } SUBROUTINE MATRIX_MUL_UNROLLED (A, B, C, L, M, N) DIMENSION A(L,M), B(M,N), C(L,N) Index: gcc/testsuite/gfortran.dg/graphite/id-19.f =================================================================== --- gcc/testsuite/gfortran.dg/graphite/id-19.f (revision 260479) +++ gcc/testsuite/gfortran.dg/graphite/id-19.f (working copy) @@ -1,3 +1,5 @@ +! { dg-do compile } +! { dg-options "-std=legacy" } SUBROUTINE ECCODR(FPQR) DIMENSION FPQR(25,25,25) INTEGER P,Q,R Index: gcc/testsuite/gfortran.dg/graphite/id-20.f =================================================================== --- gcc/testsuite/gfortran.dg/graphite/id-20.f (revision 260479) +++ gcc/testsuite/gfortran.dg/graphite/id-20.f (working copy) @@ -1,4 +1,4 @@ -! { dg-options "-O3 -ffast-math" } +! { dg-options "-O3 -ffast-math -std=legacy" } DIMENSION FPQR(25,25,25) INTEGER P,Q,R Index: gcc/testsuite/gfortran.dg/graphite/id-27.f90 =================================================================== --- gcc/testsuite/gfortran.dg/graphite/id-27.f90 (revision 260479) +++ gcc/testsuite/gfortran.dg/graphite/id-27.f90 (working copy) @@ -1,4 +1,5 @@ -! { dg-additional-options "-Ofast" } +! { dg-do compile } +! { dg-additional-options "-Ofast -std=legacy" } MODULE module_ra_gfdleta INTEGER, PARAMETER :: NBLY=15 REAL , SAVE :: EM1(28,180),EM1WDE(28,180),TABLE1(28,180), & Index: gcc/testsuite/gfortran.dg/graphite/pr82449.f =================================================================== --- gcc/testsuite/gfortran.dg/graphite/pr82449.f (revision 260479) +++ gcc/testsuite/gfortran.dg/graphite/pr82449.f (working copy) @@ -1,5 +1,5 @@ ! { dg-do compile } -! { dg-options "-O2 -floop-nest-optimize" } +! { dg-options "-O2 -floop-nest-optimize -std=legacy" } SUBROUTINE JDFIDX(MKL,KGSH) DIMENSION MKL(6,6) --opJtzjQTFsWo+cga--