From: Jakub Jelinek <jakub@redhat.com>
To: Janne Blomqvist <blomqvist.janne@gmail.com>
Cc: Fortran List <fortran@gcc.gnu.org>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Use getentropy() for seeding PRNG
Date: Mon, 13 Aug 2018 20:07:00 -0000 [thread overview]
Message-ID: <20180813200725.GG20910@laptop.zalov.cz> (raw)
In-Reply-To: <CAO9iq9FMz6ccmT1WYrZsjxv8EWiJaEnmC8qd6k9adc5suq4u7A@mail.gmail.com>
On Mon, Aug 13, 2018 at 01:12:12PM +0300, Janne Blomqvist wrote:
> PING
LGTM.
> > diff --git a/libgfortran/intrinsics/random.c b/libgfortran/intrinsics/
> > random.c
> > index 234c5ff95fd..229fa6995c0 100644
> > --- a/libgfortran/intrinsics/random.c
> > +++ b/libgfortran/intrinsics/random.c
> > @@ -310,11 +310,10 @@ getosrandom (void *buf, size_t buflen)
> > rand_s (&b[i]);
> > return buflen;
> > #else
> > - /*
> > - TODO: When glibc adds a wrapper for the getrandom() system call
> > - on Linux, one could use that.
> > -
> > - TODO: One could use getentropy() on OpenBSD. */
> > +#ifdef HAVE_GETENTROPY
> > + if (getentropy (buf, buflen) == 0)
> > + return 0;
> > +#endif
> > int flags = O_RDONLY;
> > #ifdef O_CLOEXEC
> > flags |= O_CLOEXEC;
> >
> >
> >
> > Just to be sure, I regtested this slightly modified patch as well. Ok for
> > trunk?
> >
> > --
> > Janne Blomqvist
> >
Jakub
next prev parent reply other threads:[~2018-08-13 20:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-03 13:19 Janne Blomqvist
2018-08-03 13:28 ` Jakub Jelinek
2018-08-03 14:05 ` Janne Blomqvist
2018-08-13 10:12 ` Janne Blomqvist
2018-08-13 20:07 ` Jakub Jelinek [this message]
2018-08-14 20:18 ` Rainer Orth
2018-08-14 20:29 ` Janne Blomqvist
2018-08-03 14:48 ` Paul Koning
2018-08-13 14:36 ` Fritz Reese
2018-08-13 20:12 ` Janne Blomqvist
2018-08-14 13:59 ` Fritz Reese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180813200725.GG20910@laptop.zalov.cz \
--to=jakub@redhat.com \
--cc=blomqvist.janne@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).