public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
* [patch, doc, fortran] Add Q edit descriptor
@ 2019-03-13 22:48 Thomas Koenig
  2019-03-13 22:56 ` Steve Kargl
  0 siblings, 1 reply; 4+ messages in thread
From: Thomas Koenig @ 2019-03-13 22:48 UTC (permalink / raw)
  To: fortran, gcc-patches

Hello world,

this doc patch adds the Q edit descriptor to the non-implemented
extension list. Tested with "make dvi", "make pdf" and "make info".

Suggestions? OK for trunk?

Regards

	Thomas

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [patch, doc, fortran] Add Q edit descriptor
  2019-03-13 22:48 [patch, doc, fortran] Add Q edit descriptor Thomas Koenig
@ 2019-03-13 22:56 ` Steve Kargl
  2019-03-13 23:18   ` Thomas Koenig
  0 siblings, 1 reply; 4+ messages in thread
From: Steve Kargl @ 2019-03-13 22:56 UTC (permalink / raw)
  To: Thomas Koenig; +Cc: fortran, gcc-patches

On Wed, Mar 13, 2019 at 11:48:12PM +0100, Thomas Koenig wrote:
> Hello world,
> 
> this doc patch adds the Q edit descriptor to the non-implemented
> extension list. Tested with "make dvi", "make pdf" and "make info".
> 
> Suggestions? OK for trunk?

How about asttaching the patch?  :-)

In all seriousness, thanks for your attack on bugzilla
over the last month or so.

-- 
Steve

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [patch, doc, fortran] Add Q edit descriptor
  2019-03-13 22:56 ` Steve Kargl
@ 2019-03-13 23:18   ` Thomas Koenig
  2019-03-13 23:31     ` Steve Kargl
  0 siblings, 1 reply; 4+ messages in thread
From: Thomas Koenig @ 2019-03-13 23:18 UTC (permalink / raw)
  To: fortran, gcc-patches

[-- Attachment #1: Type: text/plain, Size: 852 bytes --]

Am 13.03.19 um 23:55 schrieb Steve Kargl:
> On Wed, Mar 13, 2019 at 11:48:12PM +0100, Thomas Koenig wrote:
>> Hello world,
>>
>> this doc patch adds the Q edit descriptor to the non-implemented
>> extension list. Tested with "make dvi", "make pdf" and "make info".
>>
>> Suggestions? OK for trunk?
> 
> How about asttaching the patch?  :-)

You're right, that would probably help :-)

> In all seriousness, thanks for your attack on bugzilla
> over the last month or so.

Glad to be of service :-)

I have only fairly recently begun to understand some regions of the
compiler that were an almost complete mystery to me before, such as
what is going on in trans-*.

Generally, we are having a good run right now - we have been closing
two bugs per one new bug submitted since the new year started. And
this is very much a team effort.

Regards

	Thomas

[-- Attachment #2: p1.diff --]
[-- Type: text/x-patch, Size: 1800 bytes --]

Index: gfortran.texi
===================================================================
--- gfortran.texi	(Revision 269624)
+++ gfortran.texi	(Arbeitskopie)
@@ -2896,6 +2896,7 @@
 * Alternate complex function syntax::
 * Volatile COMMON blocks::
 * OPEN( ... NAME=)::
+* Q edit descriptor::
 @end menu
 
 @node ENCODE and DECODE statements
@@ -3018,7 +3019,7 @@
 
 @node OPEN( ... NAME=)
 @subsection @code{OPEN( ... NAME=)}
-@cindex @code{NAM}
+@cindex @code{NAME}
 
 Some Fortran compilers, including @command{g77}, let the user declare
 @code{OPEN( ... NAME=)}. This is
@@ -3026,8 +3027,28 @@
 @command{gfortran}.  @code{OPEN( ... NAME=)} should be replaced
 with @code{OPEN( ... FILE=)}.
 
+@node Q edit descriptor
+@subsection @code{Q} edit descriptor
+@cindex @code{Q} edit descriptor
 
+Some Fortran compilers include the @code{Q} edit descritpor, which
+transfers the numer of characters left on an input record into an
+integer variable.
 
+A direct replacement of the @code{Q} edit descriptor is not available
+in @command{gfortran}.  How to replicate its functionality using
+standard-conforming code depends on what exactly it does the original
+code.
+
+Options to replace @code{Q} may be to read the whole line into a
+character variable and then counting the number of non-blank
+characters left using @code{LEN_TRIM}.  Another method may be to use
+formatted stream, read the data up to the position where the @code{Q}
+descriptor occurred, use @code{INQUIRE} to get the file position,
+count the characters up to the next @code{NEW_LINE} and then start
+reading from the position marked previously.
+
+
 @c ---------------------------------------------------------------------
 @c ---------------------------------------------------------------------
 @c Mixed-Language Programming

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [patch, doc, fortran] Add Q edit descriptor
  2019-03-13 23:18   ` Thomas Koenig
@ 2019-03-13 23:31     ` Steve Kargl
  0 siblings, 0 replies; 4+ messages in thread
From: Steve Kargl @ 2019-03-13 23:31 UTC (permalink / raw)
  To: Thomas Koenig; +Cc: fortran, gcc-patches

On Thu, Mar 14, 2019 at 12:18:08AM +0100, Thomas Koenig wrote:
> Am 13.03.19 um 23:55 schrieb Steve Kargl:
> > On Wed, Mar 13, 2019 at 11:48:12PM +0100, Thomas Koenig wrote:
> >> Hello world,
> >>
> >> this doc patch adds the Q edit descriptor to the non-implemented
> >> extension list. Tested with "make dvi", "make pdf" and "make info".
> >>
> >> Suggestions? OK for trunk?
> > 
> > How about asttaching the patch?  :-)
> 
> You're right, that would probably help :-)
> 

See below.

> Index: gfortran.texi
> ===================================================================
> --- gfortran.texi	(Revision 269624)
> +++ gfortran.texi	(Arbeitskopie)
> @@ -2896,6 +2896,7 @@
>  * Alternate complex function syntax::
>  * Volatile COMMON blocks::
>  * OPEN( ... NAME=)::
> +* Q edit descriptor::
>  @end menu
>  
>  @node ENCODE and DECODE statements
> @@ -3018,7 +3019,7 @@
>  
>  @node OPEN( ... NAME=)
>  @subsection @code{OPEN( ... NAME=)}
> -@cindex @code{NAM}
> +@cindex @code{NAME}
>  
>  Some Fortran compilers, including @command{g77}, let the user declare
>  @code{OPEN( ... NAME=)}. This is
> @@ -3026,8 +3027,28 @@
>  @command{gfortran}.  @code{OPEN( ... NAME=)} should be replaced
>  with @code{OPEN( ... FILE=)}.
>  
> +@node Q edit descriptor
> +@subsection @code{Q} edit descriptor
> +@cindex @code{Q} edit descriptor
>  
> +Some Fortran compilers include the @code{Q} edit descritpor, which

s/include the/provide a
s/descritpor/descriptor

> +transfers the numer of characters left on an input record into an

s/numer/number
s/on/within

> +integer variable.

s/integer/@code{INTEGER}


> +A direct replacement of the @code{Q} edit descriptor is not available
> +in @command{gfortran}.  How to replicate its functionality using
> +standard-conforming code depends on what exactly it does the original
> +code.

s/what exactly it does/the intent of 

> +
> +Options to replace @code{Q} may be to read the whole line into a
> +character variable and then counting the number of non-blank
> +characters left using @code{LEN_TRIM}.  Another method may be to use
> +formatted stream, read the data up to the position where the @code{Q}
> +descriptor occurred, use @code{INQUIRE} to get the file position,
> +count the characters up to the next @code{NEW_LINE} and then start
> +reading from the position marked previously.
> +
> +

With the suggested changes, OK.

-- 
Steve

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-03-13 23:31 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-13 22:48 [patch, doc, fortran] Add Q edit descriptor Thomas Koenig
2019-03-13 22:56 ` Steve Kargl
2019-03-13 23:18   ` Thomas Koenig
2019-03-13 23:31     ` Steve Kargl

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).