From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 8A1C83987863 for ; Wed, 11 Nov 2020 09:39:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8A1C83987863 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-76-BDflXep5P3OXOgSXfs33wA-1; Wed, 11 Nov 2020 04:39:15 -0500 X-MC-Unique: BDflXep5P3OXOgSXfs33wA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 95FAD6D246; Wed, 11 Nov 2020 09:39:14 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-113-127.ams2.redhat.com [10.36.113.127]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2E50975136; Wed, 11 Nov 2020 09:39:13 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 0AB9dAvV2857554 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 11 Nov 2020 10:39:11 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 0AB9d9Xb2857553; Wed, 11 Nov 2020 10:39:09 +0100 Date: Wed, 11 Nov 2020 10:39:09 +0100 From: Jakub Jelinek To: Tobias Burnus Cc: gcc-patches , fortran Subject: Re: [committed] gfortran.dg/gomp/workshare-reduction-*.f90: Fix dumps for -m32 (was: Re: [Patch] Fortran: OpenMP 5.0 (in_, task_)reduction clause extensions) Message-ID: <20201111093909.GH3788@tucnak> Reply-To: Jakub Jelinek References: <50dd6d9f-d646-8475-14a9-da2d283ebbb6@codesourcery.com> <20201110121632.GN3788@tucnak> <3b161baf-e768-77d9-fd41-d2433a944a92@codesourcery.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Nov 2020 09:39:19 -0000 On Wed, Nov 11, 2020 at 09:25:25AM +0100, Tobias Burnus wrote: > As Sunil's regression tester pointed out, the testcases fail on x86-64 with -m32. > > The reason is that then the _ull_ variants of the GOMP functions are called; > in the C equivalent, those are always called – I assume that's because the C > testcase uses 'unsigned' which does not exist with Fortran. Yes, I didn't want to have 4 variants of everything, so we have just two. One handles what fits into signed long, another handles what fits into unsigned long long. Jakub