From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id DF68C385780C; Wed, 17 Feb 2021 14:18:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DF68C385780C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Julian_Brown@mentor.com IronPort-SDR: MP6xpT8QPUlDTa6uF/MlKVM+UPxRo8N5mI00lqdXpNicrdxCVFyId4uer46geEK7C+GTsngyKQ E459TUT/YBY29O/YyUa54MUTeWoOvliH6BCAR2OtzlHJapjyaY7Tq36P0eavBaKfdCFd12nqkx srYUKl+T8WKH5poBGflcm3gYe+00Ku+Sz+kP5Kk6jdhX7INTH6ToZEJresVn2V7vCO3DL+pSqF 5/EtV1W05ZsBXqacCuHBH6jY1lSqk+rFTAF2FXtjopkX4ueZrS/GoEDF9EhuQQ/P9lfwlLNk34 DuU= X-IronPort-AV: E=Sophos;i="5.81,184,1610438400"; d="diff'?scan'208";a="58349733" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa4.mentor.iphmx.com with ESMTP; 17 Feb 2021 06:18:43 -0800 IronPort-SDR: njSrYpvNARj22JCjBtCY8wxUhGJiI/2xjOrMd+kD7EF153V6dx23RMOIGtkWijOEOJ2/0rmlnP 0/UMc5Nlwl8kLv3e8p7kED3dgex/WTzyFi7l8sOXDEa5QeHQ2twhpKXlZ+UYhmcDtzTMzSZQ8/ E2joMIFJ1cY8eZE3Xe7gNdpv+KqTDheG8gbBVPkuHCWwmacyZGh27JCjFtkwHIAN5sZ5IFw6F6 12B0p4xB17zzm4NG1UTlG7ZTpLvbWUKcn9m+Ne6254/PtBzN2JeE9ZeoUd/TmJY+72bhD0n9MC 9SA= Date: Wed, 17 Feb 2021 14:18:36 +0000 From: Julian Brown To: Tobias Burnus CC: , , Jakub Jelinek , Thomas Schwinge Subject: Re: [PATCH 2/2] openacc: Strided array sections and components of derived-type arrays Message-ID: <20210217141836.545058aa@squid.athome> In-Reply-To: <0dd09235-2564-0545-124f-f4b31e6520f0@codesourcery.com> References: <20210212154649.96393-1-julian@codesourcery.com> <20210212154649.96393-3-julian@codesourcery.com> <0dd09235-2564-0545-124f-f4b31e6520f0@codesourcery.com> Organization: Mentor Graphics X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/Wy4fNQmp6xMkw2zidCbCMVj" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-08.mgc.mentorg.com (139.181.222.8) To SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Feb 2021 14:18:49 -0000 --MP_/Wy4fNQmp6xMkw2zidCbCMVj Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Content-Disposition: inline On Tue, 16 Feb 2021 11:09:17 +0100 Tobias Burnus wrote: > On 12.02.21 16:46, Julian Brown wrote: > > This patch disallows selecting components of array sections in > > update directives for OpenACC, as specified in OpenACC 3.0, > > "2.14.4. Update Directive", "Restrictions": > > > > "In Fortran, members of variables of derived type may appear, > > including a subarray of a member. Members of subarrays of derived > > type may not appear." > > > > The diagnostic for attempting to use the same construct on other > > directives has also been improved. > > > > OK for mainline? > > LGTM. Thanks. FYI I've committed this version with a merge conflict fixed & new tests updated. Julian --MP_/Wy4fNQmp6xMkw2zidCbCMVj Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="strides-dt-2.diff" commit 366cf1127a547ff77024a551abb01bb1a6e963cd Author: Julian Brown Date: Wed Feb 10 11:18:13 2021 -0800 openacc: Strided array sections and components of derived-type arrays This patch disallows selecting components of array sections in update directives for OpenACC, as specified in OpenACC 3.0, "2.14.4. Update Directive": In Fortran, members of variables of derived type may appear, including a subarray of a member. Members of subarrays of derived type may not appear. The diagnostic for attempting to use the same construct on other directives has also been improved. gcc/fortran/ * openmp.c (resolve_omp_clauses): Disallow selecting components of arrays of derived type. gcc/testsuite/ * gfortran.dg/goacc/array-with-dt-2.f90: Remove expected errors. * gfortran.dg/goacc/array-with-dt-6.f90: New test. * gfortran.dg/goacc/mapping-tests-2.f90: Update expected error. * gfortran.dg/goacc/ref_inquiry.f90: Update expected errors. * gfortran.dg/gomp/ref_inquiry.f90: Likewise. libgomp/ * testsuite/libgomp.oacc-fortran/array-stride-dt-1.f90: Remove expected errors. diff --git a/gcc/fortran/openmp.c b/gcc/fortran/openmp.c index 1e541ebdafa..bf0179007be 100644 --- a/gcc/fortran/openmp.c +++ b/gcc/fortran/openmp.c @@ -5174,17 +5174,31 @@ resolve_omp_clauses (gfc_code *code, gfc_omp_clauses *omp_clauses, "are allowed on ORDERED directive at %L", &n->where); } - gfc_ref *array_ref = NULL; + gfc_ref *lastref = NULL, *lastslice = NULL; bool resolved = false; if (n->expr) { - array_ref = n->expr->ref; + lastref = n->expr->ref; resolved = gfc_resolve_expr (n->expr); /* Look through component refs to find last array reference. */ if (resolved) { + for (gfc_ref *ref = n->expr->ref; ref; ref = ref->next) + if (ref->type == REF_COMPONENT + || ref->type == REF_SUBSTRING + || ref->type == REF_INQUIRY) + lastref = ref; + else if (ref->type == REF_ARRAY) + { + for (int i = 0; i < ref->u.ar.dimen; i++) + if (ref->u.ar.dimen_type[i] == DIMEN_RANGE) + lastslice = ref; + + lastref = ref; + } + /* The "!$acc cache" directive allows rectangular subarrays to be specified, with some restrictions on the form of bounds (not implemented). @@ -5192,53 +5206,51 @@ resolve_omp_clauses (gfc_code *code, gfc_omp_clauses *omp_clauses, array isn't contiguous. An expression such as arr(-n:n,-n:n) could be contiguous even if it looks like it may not be. */ - if (list != OMP_LIST_CACHE + if (code->op != EXEC_OACC_UPDATE + && list != OMP_LIST_CACHE && list != OMP_LIST_DEPEND && !gfc_is_simply_contiguous (n->expr, false, true) - && gfc_is_not_contiguous (n->expr)) + && gfc_is_not_contiguous (n->expr) + && !(lastslice + && (lastslice->next + || lastslice->type != REF_ARRAY))) gfc_error ("Array is not contiguous at %L", &n->where); - - while (array_ref - && (array_ref->type == REF_COMPONENT - || (array_ref->type == REF_ARRAY - && array_ref->next - && (array_ref->next->type - == REF_COMPONENT)))) - array_ref = array_ref->next; } } - if (array_ref + if (lastref || (n->expr && (!resolved || n->expr->expr_type != EXPR_VARIABLE))) { - if (array_ref - && (array_ref->type == REF_SUBSTRING - || (array_ref->next - && array_ref->next->type == REF_SUBSTRING))) + if (!lastslice + && lastref + && lastref->type == REF_SUBSTRING) gfc_error ("Unexpected substring reference in %s clause " "at %L", name, &n->where); - else if (array_ref && array_ref->type == REF_INQUIRY) + else if (!lastslice + && lastref + && lastref->type == REF_INQUIRY) { - gcc_assert (array_ref->u.i == INQUIRY_RE - || array_ref->u.i == INQUIRY_IM); + gcc_assert (lastref->u.i == INQUIRY_RE + || lastref->u.i == INQUIRY_IM); gfc_error ("Unexpected complex-parts designator " "reference in %s clause at %L", name, &n->where); } else if (!resolved - || n->expr->expr_type != EXPR_VARIABLE - || array_ref->next - || array_ref->type != REF_ARRAY) + || n->expr->expr_type != EXPR_VARIABLE + || (lastslice + && (lastslice->next + || lastslice->type != REF_ARRAY))) gfc_error ("%qs in %s clause at %L is not a proper " "array section", n->sym->name, name, &n->where); - else + else if (lastslice) { int i; - gfc_array_ref *ar = &array_ref->u.ar; + gfc_array_ref *ar = &lastslice->u.ar; for (i = 0; i < ar->dimen; i++) - if (ar->stride[i]) + if (ar->stride[i] && code->op != EXEC_OACC_UPDATE) { gfc_error ("Stride should not be specified for " "array section in %s clause at %L", diff --git a/gcc/testsuite/gfortran.dg/goacc/array-with-dt-2.f90 b/gcc/testsuite/gfortran.dg/goacc/array-with-dt-2.f90 index e4a6f319772..807580d75a9 100644 --- a/gcc/testsuite/gfortran.dg/goacc/array-with-dt-2.f90 +++ b/gcc/testsuite/gfortran.dg/goacc/array-with-dt-2.f90 @@ -4,8 +4,7 @@ end type t type(t), allocatable :: b(:) -! TODO: Remove expected errors when this is supported. -!$acc update host(b(::2)) ! { dg-error "Stride should not be specified for array section in MAP clause" } -!$acc update host(b(1)%A(::3,::4)) ! { dg-error "Stride should not be specified for array section in MAP clause" } +!$acc update host(b(::2)) +!$acc update host(b(1)%A(::3,::4)) end diff --git a/gcc/testsuite/gfortran.dg/goacc/array-with-dt-6.f90 b/gcc/testsuite/gfortran.dg/goacc/array-with-dt-6.f90 new file mode 100644 index 00000000000..adac8e3945e --- /dev/null +++ b/gcc/testsuite/gfortran.dg/goacc/array-with-dt-6.f90 @@ -0,0 +1,10 @@ +type t + integer :: i, j +end type t +type t2 + type(t) :: b(4) +end type +type(t2) :: var(10) +!$acc update host(var(3)%b(:)%j) ! { dg-error "not a proper array section" } +!$acc update host(var(3)%b%j) ! { dg-error "not a proper array section" } +end diff --git a/gcc/testsuite/gfortran.dg/goacc/mapping-tests-2.f90 b/gcc/testsuite/gfortran.dg/goacc/mapping-tests-2.f90 index 1372f6af53e..6b414fb8524 100644 --- a/gcc/testsuite/gfortran.dg/goacc/mapping-tests-2.f90 +++ b/gcc/testsuite/gfortran.dg/goacc/mapping-tests-2.f90 @@ -24,9 +24,9 @@ subroutine foo ! Bad - we cannot do a strided access of 'x' ! No C/C++ equivalent !$acc enter data copyin(y(:)%i) -! { dg-error "Array is not contiguous" "" { target "*-*-*" } 26 } +! { dg-error "not a proper array section" "" { target "*-*-*" } 26 } ! Bad - again, a strided access !$acc enter data copyin(z(1)%cc(:)%i) -! { dg-error "Array is not contiguous" "" { target "*-*-*" } 30 } +! { dg-error "not a proper array section" "" { target "*-*-*" } 30 } end diff --git a/gcc/testsuite/gfortran.dg/goacc/ref_inquiry.f90 b/gcc/testsuite/gfortran.dg/goacc/ref_inquiry.f90 index 69dd38e5197..7f3cc4ae274 100644 --- a/gcc/testsuite/gfortran.dg/goacc/ref_inquiry.f90 +++ b/gcc/testsuite/gfortran.dg/goacc/ref_inquiry.f90 @@ -29,28 +29,20 @@ print *, is_contiguous(zz(:)%re) !$acc enter data copyin(z%re) ! { dg-error "Unexpected complex-parts designator" } !$acc enter data copyin(z%im) ! { dg-error "Unexpected complex-parts designator" } !$acc enter data copyin(zz%re) ! { dg-error "not a proper array section" } - ! { dg-error "Array is not contiguous" "" { target *-*-* } .-1 } !$acc enter data copyin(zz%im) ! { dg-error "not a proper array section" } - ! { dg-error "Array is not contiguous" "" { target *-*-* } .-1 } !$acc enter data copyin(x%z%re) ! { dg-error "Unexpected complex-parts designator" } !$acc enter data copyin(x%z%im) ! { dg-error "Unexpected complex-parts designator" } !$acc enter data copyin(x%zz%re) ! { dg-error "not a proper array section" } - ! { dg-error "Array is not contiguous" "" { target *-*-* } .-1 } !$acc enter data copyin(x%zz%im) ! { dg-error "not a proper array section" } - ! { dg-error "Array is not contiguous" "" { target *-*-* } .-1 } !$acc update self(z%re) ! { dg-error "Unexpected complex-parts designator" } !$acc update self(z%im) ! { dg-error "Unexpected complex-parts designator" } !$acc update self(zz%re) ! { dg-error "not a proper array section" } - ! { dg-error "Array is not contiguous" "" { target *-*-* } .-1 } !$acc update self(zz%im) ! { dg-error "not a proper array section" } - ! { dg-error "Array is not contiguous" "" { target *-*-* } .-1 } !$acc update self(x%z%re) ! { dg-error "Unexpected complex-parts designator" } !$acc update self(x%z%im) ! { dg-error "Unexpected complex-parts designator" } !$acc update self(x%zz%re) ! { dg-error "is not a proper array section" } - ! { dg-error "Array is not contiguous" "" { target *-*-* } .-1 } !$acc update self(x%zz%im) ! { dg-error "is not a proper array section" } - ! { dg-error "Array is not contiguous" "" { target *-*-* } .-1 } end diff --git a/gcc/testsuite/gfortran.dg/gomp/ref_inquiry.f90 b/gcc/testsuite/gfortran.dg/gomp/ref_inquiry.f90 index 37461040560..610d9ec0b95 100644 --- a/gcc/testsuite/gfortran.dg/gomp/ref_inquiry.f90 +++ b/gcc/testsuite/gfortran.dg/gomp/ref_inquiry.f90 @@ -25,15 +25,11 @@ print *, is_contiguous(zz(:)%re) !$omp target enter data map(to: z%re) ! { dg-error "Unexpected complex-parts designator" } !$omp target enter data map(to: z%im) ! { dg-error "Unexpected complex-parts designator" } !$omp target enter data map(to: zz%re) ! { dg-error "not a proper array section" } - ! { dg-error "Array is not contiguous" "" { target *-*-* } .-1 } !$omp target enter data map(to: zz%im) ! { dg-error "not a proper array section" } - ! { dg-error "Array is not contiguous" "" { target *-*-* } .-1 } !$omp target enter data map(to: x%z%re) ! { dg-error "Unexpected complex-parts designator" } !$omp target enter data map(to: x%z%im) ! { dg-error "Unexpected complex-parts designator" } !$omp target enter data map(to: x%zz%re) ! { dg-error "not a proper array section" } - ! { dg-error "Array is not contiguous" "" { target *-*-* } .-1 } !$omp target enter data map(to: x%zz%im) ! { dg-error "not a proper array section" } - ! { dg-error "Array is not contiguous" "" { target *-*-* } .-1 } end diff --git a/libgomp/testsuite/libgomp.oacc-fortran/array-stride-dt-1.f90 b/libgomp/testsuite/libgomp.oacc-fortran/array-stride-dt-1.f90 index 61250708197..f04d76d583a 100644 --- a/libgomp/testsuite/libgomp.oacc-fortran/array-stride-dt-1.f90 +++ b/libgomp/testsuite/libgomp.oacc-fortran/array-stride-dt-1.f90 @@ -24,9 +24,8 @@ end do b(1)%A(:,:) = 5 -! TODO: Remove expected errors once this is supported. -!$acc update device(b(::2)) ! { dg-error "Stride should not be specified for array section in MAP clause" } -!$acc update device(b(1)%A(::3,::4)) ! { dg-error "Stride should not be specified for array section in MAP clause" } +!$acc update device(b(::2)) +!$acc update device(b(1)%A(::3,::4)) do i=1,20 !$acc exit data copyout(b(i)%A) --MP_/Wy4fNQmp6xMkw2zidCbCMVj--