From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 65E28384BC17 for ; Wed, 17 Mar 2021 18:30:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 65E28384BC17 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-266-Xzpu5jSFMxql8IMqelZMYQ-1; Wed, 17 Mar 2021 14:30:09 -0400 X-MC-Unique: Xzpu5jSFMxql8IMqelZMYQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A5F98593A6; Wed, 17 Mar 2021 18:30:07 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-112-34.ams2.redhat.com [10.36.112.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1A1E05D9C0; Wed, 17 Mar 2021 18:30:04 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 12HIToHk145561 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 17 Mar 2021 19:30:00 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 12HITa0Q145560; Wed, 17 Mar 2021 19:29:36 +0100 Date: Wed, 17 Mar 2021 19:29:36 +0100 From: Jakub Jelinek To: Tobias Burnus Cc: gcc-patches , fortran Subject: Re: [Patch][GCC12] Fortran/OpenMP: Add 'omp depobj' and 'depend(mutexinoutset:' Message-ID: <20210317182936.GJ231854@tucnak> Reply-To: Jakub Jelinek References: <338fe202-6d13-8d8e-dde2-975269266615@codesourcery.com> MIME-Version: 1.0 In-Reply-To: <338fe202-6d13-8d8e-dde2-975269266615@codesourcery.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Mar 2021 18:30:14 -0000 On Wed, Mar 17, 2021 at 07:19:29PM +0100, Tobias Burnus wrote: > @@ -1831,6 +1852,7 @@ show_omp_node (int level, gfc_code *c) > case EXEC_OMP_FLUSH: name = "FLUSH"; break; > case EXEC_OMP_MASTER: name = "MASTER"; break; > case EXEC_OMP_ORDERED: name = "ORDERED"; break; > + case EXEC_OMP_DEPOBJ: name = "DEPBOBJ"; break; s/DEPBOBJ/DEPOBJ/ > + || omp_clauses->depobj->ts.kind != 2*gfc_index_integer_kind Formatting (several times), I think we should use 2 * gfc_index_integer_kind > --- a/gcc/fortran/trans-openmp.c > +++ b/gcc/fortran/trans-openmp.c > @@ -2545,6 +2545,8 @@ gfc_trans_omp_clauses (stmtblock_t *block, gfc_omp_clauses *clauses, > tree decl = gfc_trans_omp_variable (n->sym, false); > if (gfc_omp_privatize_by_reference (decl)) > decl = build_fold_indirect_ref (decl); > + if (POINTER_TYPE_P (TREE_TYPE (decl))) > + decl = build_fold_indirect_ref (decl); I'm a little bit worried about this, are you sure it won't affect anything but depobj? > + int k = -1; /* omp_clauses->destroy */ > + if (!code->ext.omp_clauses->destroy) > + switch (code->ext.omp_clauses->depobj_update != OMP_DEPEND_UNSET > + ? code->ext.omp_clauses->depobj_update : n->u.depend_op) > + { > + case OMP_DEPEND_IN: k = GOMP_DEPEND_IN; break; > + case OMP_DEPEND_OUT: k = GOMP_DEPEND_IN; break; > + case OMP_DEPEND_INOUT: k = GOMP_DEPEND_IN; break; > + case OMP_DEPEND_MUTEXINOUTSET: k = GOMP_DEPEND_MUTEXINOUTSET; break; > + case OMP_DEPEND_DEPOBJ: k = GOMP_DEPEND_MUTEXINOUTSET; break; Can depobj_update be OMP_DEPEND_DEPOBJ ? Otherwise LGTM. Jakub