From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 8FB153950437 for ; Wed, 28 Apr 2021 20:31:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8FB153950437 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-386-4SKAIooKOQmLre-85LnkRA-1; Wed, 28 Apr 2021 16:31:45 -0400 X-MC-Unique: 4SKAIooKOQmLre-85LnkRA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B98CD1927800; Wed, 28 Apr 2021 20:31:44 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-114-59.ams2.redhat.com [10.36.114.59]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3F00F772E1; Wed, 28 Apr 2021 20:31:43 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 13SKVftw1806566 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 28 Apr 2021 22:31:41 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 13SKVfoH1806565; Wed, 28 Apr 2021 22:31:41 +0200 Date: Wed, 28 Apr 2021 22:31:41 +0200 From: Jakub Jelinek To: Tobias Burnus Cc: gcc-patches , fortran Subject: Re: [Patch] Fortran/OpenMP: Fix var-list expr parsing with array/dt (was: [Patch] OpenMP: Add iterator support to Fortran's depend; add affinity clause) Message-ID: <20210428203141.GC1179226@tucnak> Reply-To: Jakub Jelinek References: <923778bf-f61e-7bd0-7926-53d28434fdab@codesourcery.com> <20210428134143.GP1179226@tucnak> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Apr 2021 20:31:50 -0000 On Wed, Apr 28, 2021 at 10:26:44PM +0200, Tobias Burnus wrote: > On 28.04.21 15:41, Jakub Jelinek wrote: > > > @@ -261,6 +263,7 @@ gfc_match_omp_variable_list (const char *str, gfc_omp_namelist **list, > > > + gfc_gobble_whitespace (); > > > if ((allow_sections && gfc_peek_ascii_char () == '(') > > > || (allow_derived && gfc_peek_ascii_char () == '%') > > Is this change specific to depend/affinity or iterators? > > If not, shouldn't it go in separately and with a testcase that shows when it > > is needed? > > I encountered it when writing a testcase - and the testcase was using it. > However, if you think it makes sense to have it separately. > > It fixes the issue: > > 7 | !$omp target enter data map( to: a (:) ) > | 1 > Error: Syntax error in OpenMP variable list at (1) > > OK for mainline? Yes, thanks. And IMHO also should be backported at least to 11. Jakub