From: Andre Vehreschild <vehre@gmx.de>
To: GCC-Fortran-ML <fortran@gcc.gnu.org>
Cc: GCC-Patches-ML <gcc-patches@gcc.gnu.org>,
Steve Kargl <sgk@troutmask.apl.washington.edu>
Subject: Re: [Ping, Patch, Fortran, Update 2] PR98301 Re: RANDOM_INIT() and coarray Fortran
Date: Mon, 3 May 2021 11:21:10 +0200 [thread overview]
Message-ID: <20210503112110.7580eb41@vepi2> (raw)
In-Reply-To: <20210426123636.7eb24c37@vepi2>
Ping!
Ok for trunk?
I have looked at other patches, but none was patching any location I have
worked on previously. Therefore I can't return the favor of reviewing any
currently open patches and have to ask for volunteers here.
- Andre
On Mon, 26 Apr 2021 12:36:36 +0200
Andre Vehreschild via Fortran <fortran@gcc.gnu.org> wrote:
> Hi Steve, hi all,
>
> I agree. The cas-things have been removed (I will put the patch for them into
> the pr98301 ticket, so safe them), streamlining the patch a bit more.
>
> Bootstraped and regtested ok on x86_64-linux/f33. Ok for trunk?
>
> Regards,
> Andre
>
> Steve Kargl <kargl@gcc.gnu.org>
>
> PR fortran/98301 - random_init() is broken
>
> Correct implementation of random_init() when -fcoarray=lib is given.
>
> gcc/fortran/ChangeLog:
>
> PR fortran/98301
> * trans-decl.c (gfc_build_builtin_function_decls): Move decl.
> * trans-intrinsic.c (conv_intrinsic_random_init): Use bool for
> lib-call of caf_random_init instead of logical (4-byte).
> * trans.h: Add tree var for random_init.
>
> libgfortran/ChangeLog:
>
> PR fortran/98302
> * caf/libcaf.h (_gfortran_caf_random_init): New function.
> * caf/single.c (_gfortran_caf_random_init): New function.
> * gfortran.map: Added fndecl.
> * intrinsics/random_init.f90: Implement random_init.
>
>
>
> On Sun, 25 Apr 2021 13:03:34 -0700
> Steve Kargl <sgk@troutmask.apl.washington.edu> wrote:
>
> > Andre,
> >
> > The patch looks fine to me. I wonder, however, if we should
> > comment out all of the shared memory stuff, i.e., the _cas_
> > stuff. I don't know when Thomas/Nicolas will merge their
> > work-in-progress.
> >
>
>
> --
> Andre Vehreschild * Email: vehre ad gmx dot de
--
Andre Vehreschild * Email: vehre ad gmx dot de
next prev parent reply other threads:[~2021-05-03 9:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-03 17:28 Steve Kargl
2021-04-04 3:30 ` Damian Rouson
2021-04-04 5:33 ` Steve Kargl
2021-04-23 16:43 ` [Patch, Fortran] PR98301 " Andre Vehreschild
2021-04-23 17:18 ` Steve Kargl
2021-04-24 10:49 ` [Patch, Fortran, Update] " Andre Vehreschild
2021-04-24 15:44 ` Steve Kargl
2021-04-24 15:56 ` Dr. Andre Vehreschild
2021-04-25 20:03 ` Steve Kargl
2021-04-26 10:36 ` [Patch, Fortran, Update 2] " Andre Vehreschild
2021-05-03 9:21 ` Andre Vehreschild [this message]
2021-05-03 15:20 ` [Ping, Patch, " Steve Kargl
2021-05-21 8:09 ` [Ping^2, Patch, Fortran] " Andre Vehreschild
2021-05-21 15:08 ` Steve Kargl
2021-05-22 2:38 ` Jerry D
2021-05-22 11:39 ` Andre Vehreschild
2021-05-22 17:58 ` Martin Liška
2021-05-23 11:59 ` Andre Vehreschild
2021-05-23 12:17 ` Martin Liška
2021-06-05 14:04 ` [Patch, Fortran, backport 2 gcc-11] " Andre Vehreschild
2021-06-05 16:27 ` Steve Kargl
2021-06-06 10:14 ` [COMITTED, Patch, " Andre Vehreschild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210503112110.7580eb41@vepi2 \
--to=vehre@gmx.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=sgk@troutmask.apl.washington.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).