From: Jakub Jelinek <jakub@redhat.com>
To: Christophe Lyon <christophe.lyon@linaro.org>
Cc: Tobias Burnus <tobias@codesourcery.com>,
gcc-patches <gcc-patches@gcc.gnu.org>,
fortran <fortran@gcc.gnu.org>,
Joseph Myers <joseph@codesourcery.com>
Subject: Re: [Patch] OpenMP: Add iterator support to Fortran's depend; add affinity clause
Date: Mon, 31 May 2021 10:19:45 +0200 [thread overview]
Message-ID: <20210531081945.GJ7746@tucnak> (raw)
In-Reply-To: <CAKdteOY9BAKOw0uC0Qp+ChvDpiKcwy8HMgpUgg9ksNeEm9Eh4Q@mail.gmail.com>
On Mon, May 31, 2021 at 10:14:34AM +0200, Christophe Lyon wrote:
> > Something I've missed during the review but it shows up during testing:
> >
> > > diff --git a/gcc/testsuite/gfortran.dg/gomp/depend-iterator-1.f90 b/gcc/testsuite/gfortran.dg/gomp/depend-iterator-1.f90
> > > new file mode 100644
> > > index 00000000000..cad36aaf8b7
> > > --- /dev/null
> > > +++ b/gcc/testsuite/gfortran.dg/gomp/depend-iterator-1.f90
> > > @@ -0,0 +1,45 @@
> > > +! { dg-do run }
> >
> > gcc/testsuite/*/gomp/ shouldn't have dg-do run tests, either
> > it is meant to be a runtime test and then it should be moved to
> > libgomp/testsuite/libgomp.fortran/ , or it should be changed to
> > dg-do compile.
> >
>
> In addition, on arm/aarch64 at least, I can see the test failing to compile:
> gfortran: fatal error: cannot read spec file 'libgomp.spec': No such
> file or directory
That is the same thing, libgomp.spec is also needed during linking with
-fopenmp, and if it would be found, libgomp.so wouldn't.
While e.g. g++.dg/ testsuite has code to find and add the libstdc++ headers
and includes also to g++.dg tests, for libgomp we have that code only in
the libgomp testsuite.
Jakub
next prev parent reply other threads:[~2021-05-31 8:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 13:36 Tobias Burnus
2021-04-28 13:41 ` Jakub Jelinek
2021-04-28 20:26 ` [Patch] Fortran/OpenMP: Fix var-list expr parsing with array/dt (was: [Patch] OpenMP: Add iterator support to Fortran's depend; add affinity clause) Tobias Burnus
2021-04-28 20:31 ` Jakub Jelinek
[not found] ` <3bfa68db-f904-a1cb-0d18-c1a17ecfc720@codesourcery.com>
[not found] ` <20210527082259.GM7746@tucnak>
2021-05-27 18:30 ` [Patch] OpenMP: Add iterator support to Fortran's depend; add affinity clause Tobias Burnus
2021-05-27 18:42 ` Jakub Jelinek
2021-05-27 19:58 ` Joseph Myers
2021-05-27 20:15 ` Jakub Jelinek
2021-05-27 22:59 ` Tobias Burnus
2021-05-29 8:03 ` Jakub Jelinek
2021-05-31 8:14 ` Christophe Lyon
2021-05-31 8:19 ` Jakub Jelinek [this message]
2021-05-31 14:43 ` Tobias Burnus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210531081945.GJ7746@tucnak \
--to=jakub@redhat.com \
--cc=christophe.lyon@linaro.org \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).