From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id B6087386100B for ; Mon, 31 May 2021 08:19:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B6087386100B Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-48-iVhTKMoBPha7fZ-ypQI3Qw-1; Mon, 31 May 2021 04:19:51 -0400 X-MC-Unique: iVhTKMoBPha7fZ-ypQI3Qw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7D6FB1013720; Mon, 31 May 2021 08:19:50 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-112-147.ams2.redhat.com [10.36.112.147]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A1C6B1E6; Mon, 31 May 2021 08:19:49 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 14V8JkrP2447289 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 31 May 2021 10:19:47 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 14V8JjCA2447288; Mon, 31 May 2021 10:19:45 +0200 Date: Mon, 31 May 2021 10:19:45 +0200 From: Jakub Jelinek To: Christophe Lyon Cc: Tobias Burnus , gcc-patches , fortran , Joseph Myers Subject: Re: [Patch] OpenMP: Add iterator support to Fortran's depend; add affinity clause Message-ID: <20210531081945.GJ7746@tucnak> Reply-To: Jakub Jelinek References: <923778bf-f61e-7bd0-7926-53d28434fdab@codesourcery.com> <20210428134143.GP1179226@tucnak> <3bfa68db-f904-a1cb-0d18-c1a17ecfc720@codesourcery.com> <20210527082259.GM7746@tucnak> <48e9f541-2e98-ce74-7af6-e0854f1d83a6@codesourcery.com> <20210529080310.GZ7746@tucnak> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 May 2021 08:19:57 -0000 On Mon, May 31, 2021 at 10:14:34AM +0200, Christophe Lyon wrote: > > Something I've missed during the review but it shows up during testing: > > > > > diff --git a/gcc/testsuite/gfortran.dg/gomp/depend-iterator-1.f90 b/gcc/testsuite/gfortran.dg/gomp/depend-iterator-1.f90 > > > new file mode 100644 > > > index 00000000000..cad36aaf8b7 > > > --- /dev/null > > > +++ b/gcc/testsuite/gfortran.dg/gomp/depend-iterator-1.f90 > > > @@ -0,0 +1,45 @@ > > > +! { dg-do run } > > > > gcc/testsuite/*/gomp/ shouldn't have dg-do run tests, either > > it is meant to be a runtime test and then it should be moved to > > libgomp/testsuite/libgomp.fortran/ , or it should be changed to > > dg-do compile. > > > > In addition, on arm/aarch64 at least, I can see the test failing to compile: > gfortran: fatal error: cannot read spec file 'libgomp.spec': No such > file or directory That is the same thing, libgomp.spec is also needed during linking with -fopenmp, and if it would be found, libgomp.so wouldn't. While e.g. g++.dg/ testsuite has code to find and add the libstdc++ headers and includes also to g++.dg tests, for libgomp we have that code only in the libgomp testsuite. Jakub