From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by sourceware.org (Postfix) with ESMTPS id 957CB385043D; Wed, 23 Jun 2021 08:23:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 957CB385043D X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from vepi2 ([79.194.171.234]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M1Ycr-1lxsmC3zbv-0034G3; Wed, 23 Jun 2021 10:23:20 +0200 Date: Wed, 23 Jun 2021 10:23:18 +0200 From: Andre Vehreschild To: GCC-Patches-ML , GCC-Fortran-ML Cc: Tobias Burnus , Brad Richardson , Damian Rouson Subject: Re: [Ping^2, Patch, Fortran] PR100337 Should be able to pass non-present optional arguments to CO_BROADCAST Message-ID: <20210623102318.09d8b23f@vepi2> In-Reply-To: <9f94b856-c988-7341-60f1-601b698262e8@codesourcery.com> References: <20210521153311.2760b4b3@vepi2> <20210604180518.5daa870d@vepi2> <20210619132332.302f1062@vepi2> <20210622094018.3ae5a403@vepi2> <9f94b856-c988-7341-60f1-601b698262e8@codesourcery.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:bIrtu2fPS1vRxgSNj2AzacoaZcnVSrjx7bYPh/q6JrzuwXVogpA wmelnt/ZmSgolvOktP4PHqQ2XnLCqmNCeM/ymC5/wegHDLUZUgmW8XrCMX96S2JShBierX5 Mf0GQHD0yFMDu62YcowrplcXZGEv6Dm4TvnMnc+f29qa87Y9rgg9zrqRNRP/J82jcCDsRyb zJlOiBz0MFT3AGZ5osb+g== X-UI-Out-Filterresults: notjunk:1;V03:K0:MhFY3nRqVI4=:jgCRPsVRGCjt/rFA1xnXUo 2s+sQIF+rrUcQ7BrtdyraddFpcFcseC2tIxotE0ZEBY2whq0H2uveZ4KNiItocHrIVn00JOKy gF1D5d08S6dBIMwbP2RKgY9nzWvTDFpUDVMvC6sRa23WFVwcIRZrQPQ55toaSt7h1wQCzLVNB znxannutYlGI9fJSZlgT9rO5Aa1BlU7rvqLIOpK6MdEFP8wrPHK7hQUZ8MBq+CnYszYF/u8ng uxj0/ijma/CGjmMJVRYaQj77zwR4fZ5nMdleF2BF/SJnhXpyoNrfx1fR7Z3Wfrlb39AlnZF5N SaVuJ8T+s4lJVdLIKdrgV8gUdkaqNl6PWtD8gFUY/zkvsmWZxiAceGcCOiKs/CZ//o+Kq3YQw t3L1JLAPkfBZT1sWYQEMrAmL8qoZPOd/eYl0XEvChN/JJH56MjizsadJQoGqEQSVTQqrmMmk9 PRkMwbRUvzoNr3cerOXES6LQvqLodqHeHw8Ld/TEfnLQ+RfqQvauPURW1Uc/txFftm1fVmLMP zXpkDsxaytSlC4NoX6XkTpcETu3tfY8BWmKHupcm4Hr+TBdcm9L7UlxnvoW0JuEz22qrZIpGB fYx2+wemOxm4m74oyLGaXe10BEnvyFnzty4WTjGwi3A3r0ZqetLTPCNPMUZr07ov0Y5AcejHw hBWiw+GVEYYiUwwtjPmm0ndsb7JEmfllEnh6rpdm72YzZGxH1xZC2W4TX+AV/HEPZDam4EwUK Bavh3MWnHmMNzafps8g5oVCLPMOt+i+ZvN3M0HC9bNkHPGaVsovWpbHFmcf7uXHSoliiEWf1f lzieoWzccCmaAlSzXCaFi7P43uytmj0Z9dJ5VrYau1tHy2+a/UaHqKnbsXxCLhrlajlpXArt5 OgEFPCcCe6khb16gxWSmrz3FS2ZpOne4bQAdBUtv3QlNQQb0eEfXBRxqUc6TNS1CVX0rOjl6J +WhzAENseq+3PWx+o21ipI47CllxKUXNaGFHRlRnXmPEeo0U7qhgC94EdIfkv3vhOvy5LT2Px FmEJ78+881fCK1/ozfwH8LVr4VArnNNq2C6HWRVXFbKeML3xh8K5Awu5HXhlLYhrbRNtKSEL3 91ojUAAPdNniGo/wSsHpvlkqTzLaF+g2H3B X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jun 2021 08:23:27 -0000 Hi all, the fix for PR100337 was submitted as da13e4ebebb07a47d5fb50eab8893f8fe3868= 3df. Thanks for the review Tobias. @Tobias: You are right, caf_single does not get much testing. But this part (not providing a stat) is tested multiple times, because of the laziness. N= early none of the tests in the testsuite provides a variable for stat. Will wait two weeks for any errors introduced by this patch before backport= ing to gcc-11, ok? Regards, Andre On Tue, 22 Jun 2021 10:37:27 +0200 Tobias Burnus wrote: > Hi Andre, >=20 > On 22.06.21 09:40, Andre Vehreschild via Fortran wrote: > > To the questions: > > - I added a test only for -fcoarray=3Dsingle because in the library cas= e the > > optional stat is just propagated to the library, which is already te= sted > > a lot of times and which needs to handle the optional stat in any case.= So > > an error there would have been detected in one of the earlier tests. I = did > > not want to add unnecessary test overhead given that the tests already= run > > for a long time. =20 > Fair point. > > - I did not add tests for the other CO_* routines, i.e. CO_MIN, CO_MAX, > > CO_REDUCE or CO_SUM, that are also handled by this routine, because I > > believe that showing that the fix works for CO_BROADCAST shows that the > > others work, too. Because the four others do not have any special handl= ing > > in their implementation in trans_intrinsic. Or do you mean other > > coarray-routines besides the five handled by conv_co_collective()? =20 > Well, that relates more to the first point =E2=80=93 for -fcoarray=3Dlib,= it > likely makes a difference. For -fcoarray=3Dsingle not. If the former is > skipped, it is much less relevant for the second. > > If it is ok for you, I would apply the patch as is, or do you see a rea= son > > to add more tests? =20 >=20 > OK. >=20 > Although, I am not that sure that libcaf_single gets that much testing. > On the other hand, -fcoarray=3Dlib with -lcaf_single is also not that > relevant in the real world, either. >=20 > Tobias >=20 > ----------------- > Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 M=C3=BCnchen > Registergericht M=C3=BCnchen HRB 106955, Gesch=C3=A4ftsf=C3=BChrer: Thoma= s Heurung, Frank > Th=C3=BCrauf --=20 Andre Vehreschild * Email: vehre ad gmx dot de=20