From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by sourceware.org (Postfix) with ESMTPS id 1DC723858C27; Wed, 27 Oct 2021 21:43:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1DC723858C27 Received: by mail-wm1-x32e.google.com with SMTP id z11-20020a1c7e0b000000b0030db7b70b6bso7503326wmc.1; Wed, 27 Oct 2021 14:43:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5tP94GtrhySXTmYzciptQomu54WH86jpBrNOgmuU9Eg=; b=k8XP6pVVHblTfzGCccr62PU1CiVwP6DlBcGMA4abPSUDQD4ASLCZenAo+DRG6Eqij1 f7tIiRViI5KHxzMfBWU+RdsM6MipwfRgYeCBsQrAGC52had+giGgdKqN6EPITvkD0Yuu +ZKiXEjv2KAaJjbKZplXPFT0G9mLBHOL23M/z6v1FDkgcS5b60SYPF3U/VTgvkLWtLd+ 5/N/plfuPfPlMxXDktZbpT3I/S+17dkt8Vn2o3z8VBcgH2gKKTVO7oOnNslGvYMr5KFg 7TliHUvjBw3jaalpqaab9IHUdmi3Bl6jmJsZLxtqAXFzClBCUlyD9nFIynNiE8/KOoSy q3nQ== X-Gm-Message-State: AOAM530qc+G2AekyvwppyX45QV4geH2tFF9DOXxQRF9NmS/vYwxxvIDR Ud9N2QjZWKt0IlLEXI5K/6A= X-Google-Smtp-Source: ABdhPJxsbqmEOeZ+edJ3w0N2drfkP9Kri+bQDnhjQHAva49XMd5LquUQldesdeMTBReBK7HI0uLEoQ== X-Received: by 2002:a05:600c:19cf:: with SMTP id u15mr303035wmq.45.1635371015199; Wed, 27 Oct 2021 14:43:35 -0700 (PDT) Received: from nbbrfq (dynamic-2bq7di4u2lfl4qjka9-pd01.res.v6.highway.a1.net. [2001:871:227:33a8:f6a3:c58c:7641:e771]) by smtp.gmail.com with ESMTPSA id q14sm1019079wrv.55.2021.10.27.14.43.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Oct 2021 14:43:35 -0700 (PDT) Date: Wed, 27 Oct 2021 23:43:20 +0200 From: Bernhard Reutner-Fischer To: fortran@gcc.gnu.org Cc: rep.dot.nop@gmail.com, gcc-patches@gcc.gnu.org Subject: Re: [PATCH,FORTRAN] Fix memory leak of gsymbol Message-ID: <20211027234320.16fc848b@nbbrfq> In-Reply-To: <20181021140434.30743-1-rep.dot.nop@gmail.com> References: <20181021140434.30743-1-rep.dot.nop@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_STOCKGEN, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Oct 2021 21:43:38 -0000 ping [I'll rebase and retest this too since it's been a while. Ok if it passes?] On Sun, 21 Oct 2018 16:04:34 +0200 Bernhard Reutner-Fischer wrote: > Hi! > > Regtested on x86_64-unknown-linux, installing on > aldot/fortran-fe-stringpool. > > We did not free global symbols. For a simplified abstract_type_3.f03 > valgrind reports: > > 96 bytes in 1 blocks are still reachable in loss record 461 of 602 > at 0x48377D5: calloc (vg_replace_malloc.c:711) > by 0x21257C3: xcalloc (xmalloc.c:162) > by 0x98611B: gfc_get_gsymbol(char const*) (symbol.c:4341) > by 0x932C58: parse_module() (parse.c:5912) > by 0x9336F8: gfc_parse_file() (parse.c:6236) > by 0x991449: gfc_be_parse_file() (f95-lang.c:204) > by 0x11D8EDE: compile_file() (toplev.c:455) > by 0x11DB9C3: do_compile() (toplev.c:2170) > by 0x11DBCAF: toplev::main(int, char**) (toplev.c:2305) > by 0x2045D37: main (main.c:39) > > This patch reduces leaks to > > LEAK SUMMARY: > definitely lost: 344 bytes in 1 blocks > indirectly lost: 3,024 bytes in 4 blocks > possibly lost: 0 bytes in 0 blocks > - still reachable: 1,576,174 bytes in 2,277 blocks > + still reachable: 1,576,078 bytes in 2,276 blocks > suppressed: 0 bytes in 0 blocks > > gcc/fortran/ChangeLog: > > 2018-10-21 Bernhard Reutner-Fischer > > * parse.c (clean_up_modules): Free gsym. > --- > gcc/fortran/parse.c | 18 +++++++++++------- > 1 file changed, 11 insertions(+), 7 deletions(-) > > diff --git a/gcc/fortran/parse.c b/gcc/fortran/parse.c > index b7265c42f58..f7c369a17ac 100644 > --- a/gcc/fortran/parse.c > +++ b/gcc/fortran/parse.c > @@ -6066,7 +6066,7 @@ resolve_all_program_units (gfc_namespace *gfc_global_ns_list) > > > static void > -clean_up_modules (gfc_gsymbol *gsym) > +clean_up_modules (gfc_gsymbol *&gsym) > { > if (gsym == NULL) > return; > @@ -6074,14 +6074,18 @@ clean_up_modules (gfc_gsymbol *gsym) > clean_up_modules (gsym->left); > clean_up_modules (gsym->right); > > - if (gsym->type != GSYM_MODULE || !gsym->ns) > + if (gsym->type != GSYM_MODULE) > return; > > - gfc_current_ns = gsym->ns; > - gfc_derived_types = gfc_current_ns->derived_types; > - gfc_done_2 (); > - gsym->ns = NULL; > - return; > + if (gsym->ns) > + { > + gfc_current_ns = gsym->ns; > + gfc_derived_types = gfc_current_ns->derived_types; > + gfc_done_2 (); > + gsym->ns = NULL; > + } > + free (gsym); > + gsym = NULL; > } > >